build: Bump `native_clang` up to 17.0.2 #28732

hebasto · 2023-10-25T19:20:19Z

This PR makes it possible to build the qt package with macOS 14 SDK (Xcode 15.0).

For more details, please refer to #28622.

DrahtBot · 2023-10-25T19:20:23Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept NACK	fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

fanquake · 2023-10-25T19:30:43Z

I don't understand how bumping Clang would fix building with a newer SDK? How is this related?

Concept NACK in any case, at least until we have LLVM 17 in Guix.

maflcko · 2023-10-25T19:36:09Z

Yes, would be good to keep guix in sync. Otherwise the CI will be less useful. See also #28337 and #28580 (comment)

DrahtBot · 2023-10-26T01:15:28Z

Guix builds (on x86_64)

File	commit `2a349f9` (master)	commit `cf2e4f5` (master and this pull)
SHA256SUMS.part	`caad4c31d5f25a98...`	`f35c8fca3463e4ee...`
*-aarch64-linux-gnu-debug.tar.gz	`3ea054e6597c0dc6...`	`501f6b23365a6ad2...`
*-aarch64-linux-gnu.tar.gz	`07c63f58b61c1540...`	`3d4588c1633d77cd...`
*-arm-linux-gnueabihf-debug.tar.gz	`045d603b322e9882...`	`31b44731505e158c...`
*-arm-linux-gnueabihf.tar.gz	`aa6cee3feb14e3c2...`	`33b1372cb094cb78...`
*-arm64-apple-darwin-unsigned.tar.gz	`5bedae6a3c6ff1b2...`	`eccaa0bc9be32752...`
*-arm64-apple-darwin-unsigned.zip	`537b16729842ae84...`	`a1d713af1e0bf365...`
*-arm64-apple-darwin.tar.gz	`372165e3cefb7c1d...`	`c1f1cddf36ea5312...`
*-powerpc64-linux-gnu-debug.tar.gz	`57f3d71d6420f425...`	`f4bdac5bafe7d69e...`
*-powerpc64-linux-gnu.tar.gz	`f75fd0ed267ff7e7...`	`f93fb7faba44e68c...`
*-powerpc64le-linux-gnu-debug.tar.gz	`2a7002fa719a8ccc...`	`5553845b30151074...`
*-powerpc64le-linux-gnu.tar.gz	`d949e85ff3ac4494...`	`370f5d9087cd253f...`
*-riscv64-linux-gnu-debug.tar.gz	`bc68d3e9d99d122d...`	`c31a94af6c67aa9b...`
*-riscv64-linux-gnu.tar.gz	`0041c26cc04243c8...`	`b72d1cf7d751635b...`
*-x86_64-apple-darwin-unsigned.tar.gz	`95115701c06625f4...`	`e4c322980ad01f0d...`
*-x86_64-apple-darwin-unsigned.zip	`af69076558fa7b19...`	`dd36ba3cacbe92cd...`
*-x86_64-apple-darwin.tar.gz	`67aa4fa79118993c...`	`3f0f13f965e34435...`
*-x86_64-linux-gnu-debug.tar.gz	`0875eb48a365db43...`	`06030a5a30af8243...`
*-x86_64-linux-gnu.tar.gz	`e824a32f574eb0d9...`	`62bceaeaf2f25a64...`
*.tar.gz	`f5cced582675dd30...`	`eae26c1c6b67611c...`
guix_build.log	`e848507d89c4fa44...`	`38acd527aa5cf84f...`
guix_build.log.diff		`82be11389f1e4af7...`

fanquake · 2023-10-26T12:31:13Z

Also, if Clang 17 is required, to compile with the Xcode 15 SDK, wouldn't that make it impossible to compile on macOS using Apple Clang, given the most recent version is only based on LLVM 16?

hebasto · 2023-10-26T12:39:59Z

Also, if Clang 17 is required, to compile with the Xcode 15 SDK, wouldn't that make it impossible to compile on macOS using Apple Clang, given the most recent version is only based on LLVM 16?

From my experience, Clang 16 causes the same errors as the current Clang 15.0.6 does.

fanquake · 2023-10-26T12:46:27Z

Sure, but I can currently use an Apple Clang 15.0.0 (based on LLVM 16), with the Xcode 15 SDK, and everything works ok. I still don't understand what the actual problem is, what has supposedly changed in Clang 17 that fixes it, or how Apple would have managed to change the SDK in such a way that it only works with the most recently released version of Clang.

fanquake · 2023-10-31T13:39:41Z

Can you explain this change? Using a newer Xcode is one of the last the blockers for C++20.

fanquake · 2023-10-31T13:58:20Z

Discussed further offline. Moving this to draft for now. As mentioned, bumping Clang isn't required to use C++20, because bitcoind and other utils can already be compiled using C++20, against the newer SDK, so the assumption is that this is something that will need to be patched in Qt?

hebasto · 2023-11-02T13:45:45Z

Closing in favour of #28775.

…version properly 05aca09 build: Patch Qt to handle minimum macOS version properly (Hennadii Stepanov) Pull request description: This PR is: - required to [switch](bitcoin/bitcoin#28622) to macOS 14 SDK (Xcode 15). - an alternative to bitcoin/bitcoin#28732 and bitcoin/bitcoin#28775. Qt relies on the `__MAC_OS_X_VERSION_MIN_REQUIRED` macro, which is set in the `AvailabilityInternal.h` SDK header to the value provided by the Clang driver from the `-mmacos-version-min` / `-mmacosx-version-min` option. Xcode 12 SDK expects the OS-specific `__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__` macro: ```c++ #ifndef __MAC_OS_X_VERSION_MIN_REQUIRED #ifdef __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ /* compiler for Mac OS X sets __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ */ #define __MAC_OS_X_VERSION_MIN_REQUIRED __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ #endif #endif /* __MAC_OS_X_VERSION_MIN_REQUIRED*/ ``` In the other hand, Xcode 15 SDK expects a general `__ENVIRONMENT_OS_VERSION_MIN_REQUIRED__` macro: ```c++ #ifndef __MAC_OS_X_VERSION_MIN_REQUIRED #if defined(__has_builtin) && __has_builtin(__is_target_os) #if __is_target_os(macos) #define __MAC_OS_X_VERSION_MIN_REQUIRED __ENVIRONMENT_OS_VERSION_MIN_REQUIRED__ #define __MAC_OS_X_VERSION_MAX_ALLOWED __MAC_14_0 #endif #elif __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ #define __MAC_OS_X_VERSION_MIN_REQUIRED __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ #define __MAC_OS_X_VERSION_MAX_ALLOWED __MAC_14_0 #endif /* __has_builtin(__is_target_os) && __is_target_os(macos) */ #endif /* __MAC_OS_X_VERSION_MIN_REQUIRED */ ``` The latter macro is not provided by LLVM Clang until llvm/llvm-project@c8e2dd8, which is available in Clang 17. The suggested patch makes Qt "borrow" the `__MAC_OS_X_VERSION_MIN_REQUIRED` value from `MAC_OS_X_VERSION_MIN_REQUIRED`, which is set in the `AvailabilityMacros.h` SDK header. ACKs for top commit: maflcko: lgtm ACK 05aca09 Tree-SHA512: 8891aefde4b8a48885abf0648f4ec71a22f7fcfca1e17ebb8c70ce1ef44751ea5db6b8b652de6ee8a716ca5f96f720fef01600bc23986162d0146c946e2e8743

…properly 05aca09 build: Patch Qt to handle minimum macOS version properly (Hennadii Stepanov) Pull request description: This PR is: - required to [switch](bitcoin#28622) to macOS 14 SDK (Xcode 15). - an alternative to bitcoin#28732 and bitcoin#28775. Qt relies on the `__MAC_OS_X_VERSION_MIN_REQUIRED` macro, which is set in the `AvailabilityInternal.h` SDK header to the value provided by the Clang driver from the `-mmacos-version-min` / `-mmacosx-version-min` option. Xcode 12 SDK expects the OS-specific `__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__` macro: ```c++ #ifndef __MAC_OS_X_VERSION_MIN_REQUIRED #ifdef __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ /* compiler for Mac OS X sets __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ */ #define __MAC_OS_X_VERSION_MIN_REQUIRED __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ #endif #endif /* __MAC_OS_X_VERSION_MIN_REQUIRED*/ ``` In the other hand, Xcode 15 SDK expects a general `__ENVIRONMENT_OS_VERSION_MIN_REQUIRED__` macro: ```c++ #ifndef __MAC_OS_X_VERSION_MIN_REQUIRED #if defined(__has_builtin) && __has_builtin(__is_target_os) #if __is_target_os(macos) #define __MAC_OS_X_VERSION_MIN_REQUIRED __ENVIRONMENT_OS_VERSION_MIN_REQUIRED__ #define __MAC_OS_X_VERSION_MAX_ALLOWED __MAC_14_0 #endif #elif __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ #define __MAC_OS_X_VERSION_MIN_REQUIRED __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__ #define __MAC_OS_X_VERSION_MAX_ALLOWED __MAC_14_0 #endif /* __has_builtin(__is_target_os) && __is_target_os(macos) */ #endif /* __MAC_OS_X_VERSION_MIN_REQUIRED */ ``` The latter macro is not provided by LLVM Clang until llvm/llvm-project@c8e2dd8, which is available in Clang 17. The suggested patch makes Qt "borrow" the `__MAC_OS_X_VERSION_MIN_REQUIRED` value from `MAC_OS_X_VERSION_MIN_REQUIRED`, which is set in the `AvailabilityMacros.h` SDK header. ACKs for top commit: maflcko: lgtm ACK 05aca09 Tree-SHA512: 8891aefde4b8a48885abf0648f4ec71a22f7fcfca1e17ebb8c70ce1ef44751ea5db6b8b652de6ee8a716ca5f96f720fef01600bc23986162d0146c946e2e8743

build: Bump native_clang up to 17.0.2

b3c8caf

DrahtBot added the Build system label Oct 25, 2023

maflcko added the DrahtBot Guix build requested label Oct 25, 2023

DrahtBot removed the DrahtBot Guix build requested label Oct 26, 2023

fanquake marked this pull request as draft October 31, 2023 13:57

hebasto mentioned this pull request Nov 2, 2023

build: Patch Qt to handle minimum macOS version properly #28775

Closed

hebasto closed this Nov 2, 2023

hebasto mentioned this pull request Nov 11, 2023

build: Patch Qt to handle minimum macOS version properly #28851

Merged

fanquake mentioned this pull request Nov 15, 2023

build: switch to using LLVM 17.x for macOS builds #28880

Merged

bitcoin locked and limited conversation to collaborators Nov 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

build: Bump `native_clang` up to 17.0.2 #28732

build: Bump `native_clang` up to 17.0.2 #28732

Uh oh!

hebasto commented Oct 25, 2023

Uh oh!

DrahtBot commented Oct 25, 2023 •

edited

Loading

Uh oh!

fanquake commented Oct 25, 2023

Uh oh!

maflcko commented Oct 25, 2023 •

edited

Loading

Uh oh!

DrahtBot commented Oct 26, 2023

Uh oh!

fanquake commented Oct 26, 2023

Uh oh!

hebasto commented Oct 26, 2023

Uh oh!

fanquake commented Oct 26, 2023 •

edited

Loading

Uh oh!

fanquake commented Oct 31, 2023

Uh oh!

fanquake commented Oct 31, 2023

Uh oh!

hebasto commented Nov 2, 2023

Uh oh!

Uh oh!

build: Bump native_clang up to 17.0.2 #28732

build: Bump native_clang up to 17.0.2 #28732

Uh oh!

Conversation

hebasto commented Oct 25, 2023

Uh oh!

DrahtBot commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage

Reviews

Uh oh!

fanquake commented Oct 25, 2023

Uh oh!

maflcko commented Oct 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Oct 26, 2023

Guix builds (on x86_64)

Uh oh!

fanquake commented Oct 26, 2023

Uh oh!

hebasto commented Oct 26, 2023

Uh oh!

fanquake commented Oct 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fanquake commented Oct 31, 2023

Uh oh!

fanquake commented Oct 31, 2023

Uh oh!

hebasto commented Nov 2, 2023

Uh oh!

Uh oh!

build: Bump `native_clang` up to 17.0.2 #28732

build: Bump `native_clang` up to 17.0.2 #28732

DrahtBot commented Oct 25, 2023 •

edited

Loading

maflcko commented Oct 25, 2023 •

edited

Loading

fanquake commented Oct 26, 2023 •

edited

Loading