Skip to content

Conversation

vuittont60
Copy link
Contributor

No description provided.

@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 10, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK maflcko, hebasto, jarolrod

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Docs label Oct 10, 2023
@maflcko
Copy link
Member

maflcko commented Oct 10, 2023

lgtm ACK 57131bf

@hebasto
Copy link
Member

hebasto commented Oct 10, 2023

Why this typo is not caught by the linter?

See: #28605.

@vuittont60
Copy link
Contributor Author

Yes, linter is the requirement for branch-off.
And we can see, not all typos can be caught by the linter.
And I caught the fish that escaped the net.

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 57131bf, the codespell is powerless to catch this typo.

Copy link
Member

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 57131bf

@fanquake fanquake merged commit 154404e into bitcoin:master Oct 11, 2023
Frank-GER pushed a commit to syscoin/syscoin that referenced this pull request Oct 13, 2023
57131bf docs: fix typo (vuittont60)

Pull request description:

ACKs for top commit:
  maflcko:
    lgtm ACK 57131bf
  hebasto:
    ACK 57131bf, the `codespell` is powerless to catch this typo.
  jarolrod:
    ACK 57131bf

Tree-SHA512: 816dfc5ff64531ea92acf35feca2286a71c75344df2524ff003a3d375e60100b8531e1678be0ed11863d03ab522d5733d8a0bf4b6f5f79c495a65246fe0b697f
@maflcko maflcko mentioned this pull request Oct 26, 2023
@bitcoin bitcoin locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants