test: Add Wallet Unlock Context Manager #28617
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
a6bded9 to
a3e3d3c
Compare
a0c1822 to
c633551
Compare
Add Context Manager to manage wallet locking/unlocking with passphrase
c633551 to
004903e
Compare
|
@maflcko could you please review the changes |
|
lgtm ACK 004903e |
|
lgtm ACK 004903e |
|
Hey @BrandonOdiwuor, nice work on these changes. I know that this PR has been closed, but I finally finished my review of all the files. Apologies for the delay. I'm trying to get up to speed and have to work very slowly at the moment. I learned a ton from your work and have already gotten some value from the code review, but I'm not sure of the best way to contribute these changes. They can be found here: master...kashifs:bitcoin:master Please let me know what you think. Thanks! |
Fixes #28601, see #28403 (comment)
Add Context Manager to manage the locking and unlocking of locked wallets with a passphrase during testing.