ci: Avoid cache depends/work/build #28595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
maflcko
commented
Oct 5, 2023
| @@ -21,6 +21,8 @@ if [ -z "$DANGER_RUN_CI_ON_HOST" ]; then | |||
| "${BASE_READ_ONLY_DIR}" | |||
| docker volume create "${CONTAINER_NAME}_ccache" || true | |||
| docker volume create "${CONTAINER_NAME}_depends" || true | |||
| docker volume create "${CONTAINER_NAME}_depends_sources" || true | |||
| docker volume create "${CONTAINER_NAME}_depends_SDKs_android" || true | |||
There was a problem hiding this comment.
For context, they are needed for Android, see the cirrus yaml from when Android was removed: fa22538.
I guess they can't hurt the other tasks.
Yes, sorry, should have been |
|
Adjusted title |
Frank-GER
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 13, 2023
fac88a8 ci: Avoid cache depends/build (MarcoFalke) Pull request description: Fixes bitcoin#28365 (maybe?) ACKs for top commit: hebasto: ACK fac88a8 Tree-SHA512: c121f335f4b7d1f5f8f0508a17cee4d33dcf43c3928f9003a01dcc9ed0c45d1d912f7ff976e605b06c2f293ed21371d2dcace5562fe466bc444144790353bdd3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28365 (maybe?)