Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Oct 2, 2023

Followup to #28385 (comment).

@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 2, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK MarcoFalke, hebasto, glozow

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@fanquake fanquake force-pushed the bench_drop_thread_safety branch from a3a90b3 to d67aa25 Compare October 2, 2023 13:28
@fanquake fanquake requested a review from glozow October 2, 2023 13:56
@maflcko
Copy link
Member

maflcko commented Oct 2, 2023

lgtm ACK d67aa25

Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d67aa25, tested on Ubuntu 22.04 with clang 18.0.

Copy link
Member

@glozow glozow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK d67aa25

@glozow glozow merged commit fd8ab08 into bitcoin:master Oct 2, 2023
@fanquake fanquake deleted the bench_drop_thread_safety branch October 2, 2023 15:22
Frank-GER pushed a commit to syscoin/syscoin that referenced this pull request Oct 5, 2023
d67aa25 bench: drop NO_THREAD_SAFETY_ANALYSIS from disconnected_txs (fanquake)

Pull request description:

  Followup to bitcoin#28385 (comment).

ACKs for top commit:
  MarcoFalke:
    lgtm ACK d67aa25
  hebasto:
    ACK d67aa25, tested on Ubuntu 22.04 with clang 18.0.
  glozow:
    utACK d67aa25

Tree-SHA512: a9a9a8cc70a50d4fbd51779a3203bbc2a29d354b557e8a99cfd649d5998b71ff1087f5bae7170471bed9a917a93c8f3351ae90c9a6e87d88928c35912d007b64
@bitcoin bitcoin locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants