Make -checkpoints argument no longer debug-only #28524
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code CoverageFor detailed information about the code coverage, see the test coverage report. ReviewsSee the guideline for information on the review process. |
Not sure. If we aren't completely convinced about actually dropping them yet, I'm not sure that making the option more apparent to users is the right thing to do. |
|
That makes sense. Marking this as draft until we feel confident enough to advertise this option. I've been running it for half a year :-) |
2c56ae4 to
ffc604e
Compare
|
Closing for now. This is a simple change, but doesn't make sense yet, and can easily be reopened / redone once there is a clear path forward for #25725. |
A small step towards dropping checkpoints entirely, make the option to disable them a bit easier to find.
Before this PR this required
bitcoind --help-debug.A potential next step could be to change the default to 0 in a future release, then drop the checkpoints in the next release (#28524) and then drop all the checkpoint code one release later.