RPC: descriptorprocesspsbt returns hex encoded tx if complete
#28492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If processed psbt is complete return hex encoded network transaction in the output.
Test that if the processed psbt is complete the hex encoded tx is returned and remove unneccessary rpc call to finalize the psbt.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
pinheadmz
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
ACK a99e9e6
reviewed code and tested locally 👍
Show Signature
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
ACK a99e9e655a58b2364a74aec5cafb827a73c6b0c4
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmUEszgACgkQ5+KYS2KJ
yTqdKA//XiTF0aXFKBoFAxJLU1oPrMNTD5RpgP9mvSu0rHuKf8g1KvAqUv1doeUH
A2/RpbWPxHJyivbg7S3h3Dfzfrzbh5TRCO+47zSiIKzINtJ92VG1CXwe+Uu7O35v
Ez6eUBk6tYeZOo+udIbtKXhQFfE8MQ8IiJ/qjJj4UGw1ehvJZ9FiKF80JHGv7HK0
pRVrZqNsYpQ44DYuwAxUJQuiz0uX/hPulpheAxdk1kAoFaVmWXH+YEhXfuvqwIPc
FyTZE/BWaVYTQaT9S0bT0QXntq5L9x/jQI9fANrPZ10REpySHgD9uuJxfF1ZZ077
rlLgq7S9+kY8kTr+mfXSgBJdr/dHQRnY9yrFrwUbLOZx0DI6Y439k0V1ZXmbuLmb
xVQ78rNNomEUE3KznhiTXAmFiJEYKOnpEqOf8Dny/UQ4nuNUvEtzPJmm2f4hFkfC
xM6C9bjZp2oYFyE0dKpp2Pcw6TDroUW8kdt4R21hm4rwWZ2gz0/JHlimPQP1qtPf
PFy5gWSMM9P0z4F5xFZfqgaPDCxYEPQ5Zsu/WonS1oE8glIhVPLeE++vAtd0iqAZ
Ibs8qTFQDaZUlfkdyEVB+Bx+OykD67sFUd5f62579d08LeCaat1Hlddk0tuWbNXs
TcTop9JnD9ihmWGyU6oM8agHO8EqXmJDccfEWXxf52BkutECzhM=
=R4/T
-----END PGP SIGNATURE-----
pinheadmz's public key is on keybase
ishaanam
reviewed
Sep 16, 2023
|
ACK a99e9e6 |
Frank-GER
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 25, 2023
… tx if complete a99e9e6 doc: add release note (ismaelsadeeq) 2b4edf8 test: check `descriptorprocesspsbt` return hex encoded tx (ismaelsadeeq) c405207 rpc: `descriptorprocesspsbt` return hex encoded tx (ismaelsadeeq) Pull request description: Coming from [bitcoin#28414 comment](bitcoin#28414 (review)) Same thing also for `descriptorprocesspsbt`. Before this PR `descriptorprocesspsbt` returns a boolean `complete` which indicates that the psbt is final, users then have to call `finalizepsbt` to get the hex encoded network transaction. In this PR if the psbt is complete the return object also has the hex encoded network transaction ready for broadcast with `sendrawtransaction`. This save users calling `finalizepsbt` with the descriptor, if it is already complete. ACKs for top commit: achow101: ACK a99e9e6 pinheadmz: ACK a99e9e6 ishaanam: ACK a99e9e6 Tree-SHA512: c3f1b1391d4df05216c463127cd593f8703840430a99febb54890bc66fadabf9d9530860605f347ec54c1694019173247a0e7a9eb879d3cbb420f9e8d9839b75
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 26, 2023
… tx if complete a99e9e6 doc: add release note (ismaelsadeeq) 2b4edf8 test: check `descriptorprocesspsbt` return hex encoded tx (ismaelsadeeq) c405207 rpc: `descriptorprocesspsbt` return hex encoded tx (ismaelsadeeq) Pull request description: Coming from [bitcoin#28414 comment](bitcoin#28414 (review)) Same thing also for `descriptorprocesspsbt`. Before this PR `descriptorprocesspsbt` returns a boolean `complete` which indicates that the psbt is final, users then have to call `finalizepsbt` to get the hex encoded network transaction. In this PR if the psbt is complete the return object also has the hex encoded network transaction ready for broadcast with `sendrawtransaction`. This save users calling `finalizepsbt` with the descriptor, if it is already complete. ACKs for top commit: achow101: ACK a99e9e6 pinheadmz: ACK a99e9e6 ishaanam: ACK a99e9e6 Tree-SHA512: c3f1b1391d4df05216c463127cd593f8703840430a99febb54890bc66fadabf9d9530860605f347ec54c1694019173247a0e7a9eb879d3cbb420f9e8d9839b75
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from #28414 comment Same thing also for
descriptorprocesspsbt.Before this PR
descriptorprocesspsbtreturns a booleancompletewhich indicates that the psbt is final, users then have to callfinalizepsbtto get the hex encoded network transaction.In this PR if the psbt is complete the return object also has the hex encoded network transaction ready for broadcast with
sendrawtransaction.This save users calling
finalizepsbtwith the descriptor, if it is already complete.