ci: use LLVM/Clang 17 in tidy job #28482

fanquake · 2023-09-14T15:05:23Z

Also update MSAN to use 17.0.2.

Related to #28465.

DrahtBot · 2023-09-14T15:05:26Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

maflcko · 2023-09-14T17:37:25Z

For reference, I cancelled the tasks here, except for tidy, because they are not needed on this draft-pull and there was a backlog of 20 pull requests * 12 tasks (=240 tasks) on https://cirrus-ci.com/github/bitcoin/bitcoin

maflcko · 2023-09-14T17:43:22Z

(tidy passed, so I guess this is good to go once the iwyu branch is available)

ci/test/01_base_install.sh

DrahtBot · 2023-09-20T22:00:56Z

Guix builds (on x86_64)

File	commit `ff564c7` (master)	commit `9cc7949` (master and this pull)
SHA256SUMS.part	`981398bf96618280...`	`e148dcb81fab8ffb...`
*-aarch64-linux-gnu-debug.tar.gz	`b5ba491f19f81d99...`	`c5f7b6dcd678a7df...`
*-aarch64-linux-gnu.tar.gz	`d8f956f48dcc4b7a...`	`04de76c319fd77e8...`
*-arm-linux-gnueabihf-debug.tar.gz	`157cbc7a443c454d...`	`35440bf337bc38fd...`
*-arm-linux-gnueabihf.tar.gz	`4039ab72018bbc73...`	`87640b014b2967c4...`
*-arm64-apple-darwin-unsigned.tar.gz	`85f1ef47f3e4a06c...`	`5f634f0497a22ba2...`
*-arm64-apple-darwin-unsigned.zip	`43a97e811d5c8f57...`	`bf03dd99af24253c...`
*-arm64-apple-darwin.tar.gz	`962ae228ba52fc7f...`	`c377d3db9cd2b103...`
*-powerpc64-linux-gnu-debug.tar.gz	`2cec20c7fa9b4ea3...`	`530b21fa8fef36c0...`
*-powerpc64-linux-gnu.tar.gz	`5535ae062729336a...`	`18b02ba2e29dba46...`
*-powerpc64le-linux-gnu-debug.tar.gz	`264510179fe26b1e...`	`daa8d80454f046a8...`
*-powerpc64le-linux-gnu.tar.gz	`447224e806b89ec0...`	`d4665aa1146e0deb...`
*-riscv64-linux-gnu-debug.tar.gz	`8b62022ab6e5f337...`	`d20162d7b35e131e...`
*-riscv64-linux-gnu.tar.gz	`77ce785aa1b72983...`	`23cc03931664eba9...`
*-x86_64-apple-darwin-unsigned.tar.gz	`78a8fa924cdf73f8...`	`f5002e8a6b9d2fd3...`
*-x86_64-apple-darwin-unsigned.zip	`7d5d75ff080c0137...`	`530b179e840217ee...`
*-x86_64-apple-darwin.tar.gz	`ed8e677f06d86030...`	`cfcef9a53cead33c...`
*-x86_64-linux-gnu-debug.tar.gz	`2c9e947b15a34679...`	`b593b7c4bc728bbf...`
*-x86_64-linux-gnu.tar.gz	`b48c19cfba93d938...`	`dd9de75ac6f4c3ec...`
*.tar.gz	`d7c0c117bd75c33d...`	`b3cbc30a75dac68b...`
guix_build.log	`f260bbca51ee3402...`	`67727e17b88aa5b6...`
guix_build.log.diff		`df60ba7db3e7bf7d...`

fanquake · 2023-10-09T16:03:58Z

Given the discussion in include-what-you-use/include-what-you-use#1276, it seems there might not actually be a new release of IWYU until a breaking change in LLVM (the master branch "seems" to be working ok here, and with LLVM 17). I wonder if we should just pick a commit from the repo, to move things forward.

maflcko

Yes, seems fine to hard-code the current master commit

ci/test/01_base_install.sh

maflcko · 2023-10-10T10:04:15Z

lgtm ACK 8735e2c

fanquake · 2023-10-10T12:11:10Z

Tidy is green. MSAN failure is an out-of-space https://cirrus-ci.com/task/4727416686379008?logs=ci#L8613:

COMMIT ci_native_msan
Error: committing container for step {Env:[FILE_ENV=./ci/test/00_setup_env_native_msan.sh PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin] Command:run Args:[bash -c cd /ci_container_base/ && set -o errexit && source ./ci/test/00_setup_env.sh && ./ci/test/01_base_install.sh] Flags:[] Attrs:map[json:true] Message:RUN bash -c cd /ci_container_base/ && set -o errexit && source ./ci/test/00_setup_env.sh && ./ci/test/01_base_install.sh Original:RUN ["bash", "-c", "cd /ci_container_base/ && set -o errexit && source ./ci/test/00_setup_env.sh && ./ci/test/01_base_install.sh"]}: copying layers and metadata for container "9078ecd7c02b7fbc1c0de1d5d4534f78e13de447a360657750598e2941b10ce8": writing blob: adding layer with blob "sha256:4292df0af79f12a96574004b5501db4696d6f32549f7fdf6cf97f02981331925": processing tar file(write /msan/llvm-project/llvm/test/CodeGen/AMDGPU/twoaddr-regsequence.mir: no space left on device): exit status 1

maflcko · 2023-10-10T13:13:04Z

For now, you can re-run. The machines have 80GB, which should be enough for all tasks to store their images:

podman image ls
REPOSITORY                                     TAG         IMAGE ID      CREATED       SIZE
localhost/ci_native_qt5                        latest      e8fdb0e1b968  2 days ago    1.01 GB
localhost/ci_win64                             latest      0edf4d450648  5 days ago    2.13 GB
localhost/ci_native_nowallet_libbitcoinkernel  latest      c3d13f300783  2 weeks ago   722 MB
localhost/ci_macos_cross                       latest      6af49a13445b  2 weeks ago   1.07 GB
localhost/ci_native_msan                       latest      de994cb050d8  2 weeks ago   5.7 GB
localhost/ci_i686_centos                       latest      1bc6df012537  2 weeks ago   656 MB
docker.io/library/debian                       buster      4ad95f81332e  2 weeks ago   119 MB
docker.io/library/debian                       bullseye    909f4919a453  2 weeks ago   129 MB
<none>                                         <none>      9f25d95a5e92  3 weeks ago   80.4 MB
<none>                                         <none>      5846a450a8d0  6 weeks ago   80.4 MB
<none>                                         <none>      c8cf6c4e81f8  6 weeks ago   80.4 MB
quay.io/centos/amd64                           stream9     75bbb0f90548  7 weeks ago   160 MB
docker.io/amd64/ubuntu                         23.10       58f19d7ce16d  7 weeks ago   73.3 MB
<none>                                         <none>      3945dca58267  7 weeks ago   80.4 MB
docker.io/amd64/debian                         bookworm    3a37950934ff  7 weeks ago   121 MB
docker.io/library/ubuntu                       22.04       01f29b872827  2 months ago  80.4 MB
docker.io/amd64/ubuntu                         22.04       01f29b872827  2 months ago  80.4 MB
docker.io/library/ubuntu                       20.04       6df894023726  2 months ago  75.2 MB

Maybe using a depends_sources volume that is shared across all tasks can help reduce the disk usage?

DrahtBot added the Tests label Sep 14, 2023

maflcko reviewed Sep 15, 2023

View reviewed changes

ci/test/01_base_install.sh Outdated Show resolved Hide resolved

fanquake force-pushed the llvm_clang_17_tidy_job branch from fb3a37a to 8af00bb Compare September 15, 2023 09:44

DrahtBot added the CI failed label Sep 15, 2023

DrahtBot mentioned this pull request Sep 19, 2023

ci: Use nproc over MAKEJOBS in 01_base_install #28504

Merged

fanquake force-pushed the llvm_clang_17_tidy_job branch from 8af00bb to b4b20fd Compare September 20, 2023 13:40

maflcko added the DrahtBot Guix build requested label Sep 20, 2023

DrahtBot added the Needs rebase label Sep 20, 2023

fanquake force-pushed the llvm_clang_17_tidy_job branch from b4b20fd to fac9b61 Compare September 20, 2023 17:20

DrahtBot removed the Needs rebase label Sep 20, 2023

DrahtBot removed DrahtBot Guix build requested CI failed labels Sep 20, 2023

DrahtBot added CI failed and removed CI failed labels Oct 1, 2023

fanquake force-pushed the llvm_clang_17_tidy_job branch 2 times, most recently from 6f18284 to c414453 Compare October 6, 2023 09:59

DrahtBot added the CI failed label Oct 6, 2023

maflcko reviewed Oct 10, 2023

View reviewed changes

ci/test/01_base_install.sh Outdated Show resolved Hide resolved

ci/test/01_base_install.sh Outdated Show resolved Hide resolved

ci: use LLVM 17.0.2 in MSAN jobs

ce46b68

fanquake force-pushed the llvm_clang_17_tidy_job branch from c414453 to 1a658ab Compare October 10, 2023 09:40

fanquake marked this pull request as ready for review October 10, 2023 09:41

maflcko reviewed Oct 10, 2023

View reviewed changes

ci/test/01_base_install.sh Show resolved Hide resolved

ci: use LLVM/Clang 17 in tidy job

8735e2c

fanquake force-pushed the llvm_clang_17_tidy_job branch from 1a658ab to 8735e2c Compare October 10, 2023 10:02

DrahtBot removed the CI failed label Oct 10, 2023

fanquake merged commit bf32ae3 into bitcoin:master Oct 11, 2023

fanquake deleted the llvm_clang_17_tidy_job branch October 11, 2023 10:30

Frank-GER pushed a commit to syscoin/syscoin that referenced this pull request Oct 13, 2023

Merge bitcoin#28482: ci: use LLVM/Clang 17 in tidy job

2d2b1e5

bitcoin locked and limited conversation to collaborators Oct 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: use LLVM/Clang 17 in tidy job #28482

ci: use LLVM/Clang 17 in tidy job #28482

Uh oh!

fanquake commented Sep 14, 2023 •

edited

Loading

Uh oh!

DrahtBot commented Sep 14, 2023 •

edited

Loading

Uh oh!

maflcko commented Sep 14, 2023

Uh oh!

maflcko commented Sep 14, 2023

Uh oh!

Uh oh!

DrahtBot commented Sep 20, 2023

Uh oh!

fanquake commented Oct 9, 2023

Uh oh!

maflcko left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maflcko commented Oct 10, 2023

Uh oh!

fanquake commented Oct 10, 2023

Uh oh!

maflcko commented Oct 10, 2023

Uh oh!

Uh oh!

ci: use LLVM/Clang 17 in tidy job #28482

ci: use LLVM/Clang 17 in tidy job #28482

Uh oh!

Conversation

fanquake commented Sep 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Sep 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage

Reviews

Conflicts

Uh oh!

maflcko commented Sep 14, 2023

Uh oh!

maflcko commented Sep 14, 2023

Uh oh!

Uh oh!

DrahtBot commented Sep 20, 2023

Guix builds (on x86_64)

Uh oh!

fanquake commented Oct 9, 2023

Uh oh!

maflcko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maflcko commented Oct 10, 2023

Uh oh!

fanquake commented Oct 10, 2023

Uh oh!

maflcko commented Oct 10, 2023

Uh oh!

Uh oh!

fanquake commented Sep 14, 2023 •

edited

Loading

DrahtBot commented Sep 14, 2023 •

edited

Loading