fuzz: coinselection, improve `min_viable_change`/`change_output_size` #28372

brunoerg · 2023-08-30T18:48:50Z

Instead of "randomly" fuzzing min_viable_change and change_output_size, and since they're correlated, this PR changes the approach to fuzz them according to the logic in CreateTransactionInternal.

DrahtBot · 2023-08-30T18:49:22Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage

For detailed information about the code coverage, see the test coverage report.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	furszy, murchandamus, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

murchandamus · 2023-08-30T19:57:27Z

src/wallet/test/fuzz/coinselection.cpp

    coin_params.change_spend_size = fuzzed_data_provider.ConsumeIntegralInRange<int>(41, 1000);
-    coin_params.m_cost_of_change = coin_params.m_change_fee + coin_params.m_discard_feerate.GetFee(coin_params.change_spend_size);
+    const auto change_spend_fee{coin_params.m_discard_feerate.GetFee(coin_params.change_spend_size)};
+    coin_params.m_cost_of_change = coin_params.m_change_fee + change_spend_fee;
+    const auto dust{GetDustThreshold(change_prototype_txout, coin_params.m_discard_feerate)};
+    coin_params.min_viable_change = std::max(change_spend_fee + 1, dust);


I was pondering whether the input size being rolled randomly and the dust being only based on the output type could lead to min_viable_change being smaller than cost_of_change - change_fee, but this seems right to me now. 🤔

Approach ACK, will throw into my fuzzer for a while.

murchandamus · 2023-08-30T20:01:04Z

src/wallet/test/fuzz/coinselection.cpp

+static CTxOut GetChangePrototypeTxout(FuzzedDataProvider& fuzzed_data_provider)
+{
+    const CTxDestination tx_destination{ConsumeTxDestination(fuzzed_data_provider)};
+    CScript script_change{GetScriptForDestination(tx_destination)};
+    return CTxOut(0, script_change);
+}


This will narrow down the range of output sizes being fuzzed.

An alternative would perhaps be to randomly roll change output size and change input size, while calculating all the other derived values from those, but my gut says that there shouldn’t be all that much exciting happening anyway. Will revisit this question when I’ve fuzzed a bit.

Did you revisit it?

This will narrow down the range of output sizes being fuzzed.

Agree.
You don't need to create valid known destinations, we only care about the change output size. All yours:

diff --git a/src/wallet/test/fuzz/coinselection.cpp b/src/wallet/test/fuzz/coinselection.cpp --- a/src/wallet/test/fuzz/coinselection.cpp (revision ccb25a1ddc1f79f432a6718604f01ed97dced15f) +++ b/src/wallet/test/fuzz/coinselection.cpp (date 1702581796902) @@ -11,6 +11,7 @@ #include <test/util/setup_common.h> #include <wallet/coinselection.h> +#include <algorithm> #include <vector> namespace wallet { @@ -74,13 +75,6 @@ return result; } -static CTxOut GetChangePrototypeTxout(FuzzedDataProvider& fuzzed_data_provider) -{ - const CTxDestination tx_destination{ConsumeTxDestination(fuzzed_data_provider)}; - CScript script_change{GetScriptForDestination(tx_destination)}; - return CTxOut(0, script_change); -} - // Returns true if the result contains an error and the message is not empty static bool HasErrorMsg(const util::Result<SelectionResult>& res) { return !util::ErrorString(res).empty(); } @@ -101,14 +95,16 @@ coin_params.m_subtract_fee_outputs = subtract_fee_outputs; coin_params.m_long_term_feerate = long_term_fee_rate; coin_params.m_effective_feerate = effective_fee_rate; - auto change_prototype_txout{GetChangePrototypeTxout(fuzzed_data_provider)}; - coin_params.change_output_size = GetSerializeSize(change_prototype_txout); + coin_params.change_output_size = fuzzed_data_provider.ConsumeIntegralInRange(1, MAX_SCRIPT_SIZE); coin_params.m_change_fee = effective_fee_rate.GetFee(coin_params.change_output_size); coin_params.m_discard_feerate = discard_fee_rate; coin_params.change_spend_size = fuzzed_data_provider.ConsumeIntegralInRange<int>(41, 1000); const auto change_spend_fee{coin_params.m_discard_feerate.GetFee(coin_params.change_spend_size)}; coin_params.m_cost_of_change = coin_params.m_change_fee + change_spend_fee; - const auto dust{GetDustThreshold(change_prototype_txout, coin_params.m_discard_feerate)}; + // We only care about the change output size + CScript change_out_script; + std::fill_n(change_out_script.begin(), coin_params.change_output_size, OP_TRUE); + const auto dust{GetDustThreshold(CTxOut{/*nValueIn=*/0, change_out_script}, coin_params.m_discard_feerate)}; coin_params.min_viable_change = std::max(change_spend_fee + 1, dust); int next_locktime{0};

maflcko · 2023-08-31T08:00:29Z

Added milestone, because this is a fuzz blocker

murchandamus · 2023-09-01T19:04:59Z

I found a crash:

fuzz: ../../src/wallet/test/fuzz/coinselection.cpp:130: void wallet::coinselection_fuzz_target(FuzzBufferType): Assertion `result_bnb->GetChange(coin_params.m_cost_of_change, CAmount{0}) == 0' failed.

You can run the crash seed using:

$ echo "FP93w8PDw8PDw8PDw8PDw8PDw8PDw8PDw8PDw8PDw8PDw8PDw8PDw8PDw8PDw8PDw8PDw8PDw8PDw8N3d1h3d4h3d3cUAjsTsTsTsTOOd3d3d5t3d3d3WHd3iHd3d3d3d///yZkblPEYAAB3d3d3d3cKJ3d3d////wAyd3d3d3c093d3d3d3dwonAAD/kiEA" | base64 -d > crash.input
$ FUZZ=coinselection src/test/fuzz/fuzz crash.input

brunoerg · 2023-09-02T18:46:27Z

@murchandamus The crash happens because GetChange is returning exactly the cost_of_change, instead of 0.

In that crash the m_subtract_fee_outputs is True. So m_use_effective in GetChange is False.

See:

CAmount SelectionResult::GetChange(const CAmount min_viable_change, const CAmount change_fee) const
{
    // change = SUM(inputs) - SUM(outputs) - fees
    // 1) With SFFO we don't pay any fees
    // 2) Otherwise we pay all the fees:
    //  - input fees are covered by GetSelectedEffectiveValue()
    //  - non_input_fee is included in m_target
    //  - change_fee
    const CAmount change = m_use_effective
                           ? GetSelectedEffectiveValue() - m_target - change_fee
                           : GetSelectedValue() - m_target;

    if (change < min_viable_change) {
        return 0;
    }

    return change;
}

I tested m_use_effective with True and the change is 0.

maflcko · 2023-10-05T16:03:51Z

Are you still working on this? What is the current status here?

furszy · 2023-10-05T16:27:32Z

Are you still working on this? What is the current status here?

#28395 (review)

brunoerg · 2023-10-05T16:31:49Z

Are you still working on this? What is the current status here?

This is just an improvement in the logic and it's not an attempt to fix the crash since it's a real bug in BnB.

maflcko · 2023-10-05T16:36:12Z

Ok, removed milestone for now.

Looks like this crashes in any case? #28372 (comment)

So maybe mark as draft for now, while this is not yet ready for review.

brunoerg · 2023-10-16T18:14:11Z

Draft while waiting for a fix in BnB

brunoerg · 2023-12-13T15:10:02Z

Rebased

brunoerg · 2023-12-13T16:57:25Z

CI error seems unrelated:

2023-12-13T15:26:02.5983445Z 54/286 - rpc_signer.py failed, Duration: 3 s
2023-12-13T15:26:02.5983915Z 
2023-12-13T15:26:02.5984128Z stdout:
2023-12-13T15:26:02.5985467Z 2023-12-13T15:25:59.249000Z TestFramework (INFO): PRNG seed is: 6112864330657271854
2023-12-13T15:26:02.5986266Z 
2023-12-13T15:26:02.5994148Z 2023-12-13T15:25:59.249000Z TestFramework (INFO): Initializing test directory D:\a\_temp\test_runner_₿_🏃_20231213_151925\rpc_signer_229
2023-12-13T15:26:02.5995453Z 
2023-12-13T15:26:02.5996137Z 2023-12-13T15:26:00.333000Z TestFramework (ERROR): Assertion failed
2023-12-13T15:26:02.5996821Z 
2023-12-13T15:26:02.5997101Z Traceback (most recent call last):
2023-12-13T15:26:02.5997578Z 
2023-12-13T15:26:02.5998332Z   File "D:\a\bitcoin\bitcoin\test\functional\test_framework\test_framework.py", line 556, in start_nodes
2023-12-13T15:26:02.5999355Z 
2023-12-13T15:26:02.5999728Z     node.wait_for_rpc_connection()
2023-12-13T15:26:02.6000194Z 
2023-12-13T15:26:02.6001027Z   File "D:\a\bitcoin\bitcoin\test\functional\test_framework\test_node.py", line 249, in wait_for_rpc_connection
2023-12-13T15:26:02.6002062Z 
2023-12-13T15:26:02.6002391Z     raise FailedToStartError(self._node_msg(
2023-12-13T15:26:02.6002931Z 
2023-12-13T15:26:02.6005067Z test_framework.test_node.FailedToStartError: [node 1] bitcoind exited with status 1 during initialization. Error: Error parsing command line arguments: Invalid parameter -signer=py -3 D:\a\bitcoin\bitcoin\test\functional\mocks\signer.py

murchandamus · 2023-12-14T03:09:21Z

Just kicked off 10×10h of fuzzing, will take a look tomorrow

murchandamus · 2023-12-14T14:06:19Z

Most of them, but not all crashed on this:

#626233 REDUCE cov: 1289 ft: 13823 corp: 4183/16Mb lim: 66076 exec/s: 206 rss: 88Mb L: 157/65635 MS: 1 EraseBytes-
fuzz: ../../src/wallet/test/fuzz/coinselection.cpp:131: void wallet::coinselection_fuzz_target(FuzzBufferType): Assertion `result_bnb->GetChange(coin_params.m_cost_of_change, CAmount{0}) == 0' failed.

I think we might have misdiagnosed the issue, when we thought it could only happen when SFFO is active

furszy

I think we might have misdiagnosed the issue, when we thought it could only happen when SFFO is active

@murchandamus. The code here has not fixed the issue I mentioned #28918 (comment).
Need to provide min_viable_change to the BnB result GetChange() function, not cost_of_change. @brunoerg

brunoerg · 2023-12-14T14:11:43Z

Need to provide min_viable_change to the BnB function, not cost_of_change. @brunoerg

Yes, I'm addressing it.

furszy · 2023-12-14T14:22:05Z

Yes, I'm addressing it.

Before pushing the changes, can verify them against the issue #28918 (comment).

brunoerg · 2023-12-14T14:31:27Z

Also, I think it would be more appropriate if we don't set change_spend_size randomly. Perhaps we could use CalculateMaximumSignedInputSize and the same approach in CreateTransactionInternal.

murchandamus · 2023-12-14T14:49:48Z

I think it would be fine to roll input and output sizes randomly as long as they remain greater than zero and all the related values are derived from them. E.g. it would be an issue if cost_of_change or min_viable_change were independent of change_spend_size

brunoerg · 2023-12-14T18:10:01Z

Need to provide min_viable_change to the BnB result GetChange() function, not cost_of_change. @brunoerg

Got same crash with it.

diff --git a/src/wallet/test/fuzz/coinselection.cpp b/src/wallet/test/fuzz/coinselection.cpp
index b35bf34db3..5a3250bdd7 100644
--- a/src/wallet/test/fuzz/coinselection.cpp
+++ b/src/wallet/test/fuzz/coinselection.cpp
@@ -128,7 +128,7 @@ FUZZ_TARGET(coinselection)
     auto result_bnb = coin_params.m_subtract_fee_outputs ? util::Error{Untranslated("BnB disabled when SFFO is enabled")} :
                       SelectCoinsBnB(group_pos, target, coin_params.m_cost_of_change, MAX_STANDARD_TX_WEIGHT);
     if (result_bnb) {
-        assert(result_bnb->GetChange(coin_params.m_cost_of_change, CAmount{0}) == 0);
+        assert(result_bnb->GetChange(coin_params.min_viable_change, CAmount{0}) == 0);
         assert(result_bnb->GetSelectedValue() >= target);
         (void)result_bnb->GetShuffledInputVector();
         (void)result_bnb->GetInputSet();

echo "//////////////////8AKH4pAAAsICkpAAAAAAgARSwLCwv//////////wsLCwsL                   
Cwt+MPILCwsLCwsLCwsLCwEAAAsHCwsLTJV4CwsLCwsLCwsBAAALCwsLCwsLCwsL
CwsA+f8nAAsLCwsLAf//JgImJtAB/w==" | base64 --decode > coinselection.crash

murchandamus · 2023-12-14T18:41:44Z

It seems to me that the check in line 131 is simply wrong:

assert(result_bnb->GetChange(coin_params.m_cost_of_change, CAmount{0}) == 0);

The function definition is CAmount SelectionResult::GetChange(const CAmount min_viable_change, const CAmount change_fee) const

So, instead of passing coin_params.m_cost_of_change and 0, we should be passing coin_params.min_viable_change and coin_params.m_change_fee. Just fixing one or the other was insufficient, but when I replace both all my fuzz crashes pass.

@@ -128,7 +128,7 @@ FUZZ_TARGET(coinselection)
     auto result_bnb = coin_params.m_subtract_fee_outputs ? util::Error{Untranslated("BnB disabled when SFFO is enabled")} :
                       SelectCoinsBnB(group_pos, target, coin_params.m_cost_of_change, MAX_STANDARD_TX_WEIGHT);
     if (result_bnb) {
-        assert(result_bnb->GetChange(coin_params.m_cost_of_change, CAmount{0}) == 0);
+        assert(result_bnb->GetChange(coin_params.min_viable_change, coin_params.m_change_fee) == 0);
         assert(result_bnb->GetSelectedValue() >= target);
         (void)result_bnb->GetShuffledInputVector();
         (void)result_bnb->GetInputSet();

furszy · 2023-12-14T19:04:13Z

So, instead of passing coin_params.m_cost_of_change and 0, we should be passing coin_params.min_viable_change and coin_params.m_change_fee. Just fixing one or the other was insufficient, but when I replace both all my fuzz crashes pass.

Yeah, thats good.
It is because cost_of_change, the BnB upper bound, includes change_fee while min_viable_change does not.

furszy

Left a comment

furszy · 2023-12-14T19:28:53Z

src/wallet/test/fuzz/coinselection.cpp

+static CTxOut GetChangePrototypeTxout(FuzzedDataProvider& fuzzed_data_provider)
+{
+    const CTxDestination tx_destination{ConsumeTxDestination(fuzzed_data_provider)};
+    CScript script_change{GetScriptForDestination(tx_destination)};
+    return CTxOut(0, script_change);
+}


This will narrow down the range of output sizes being fuzzed.

Agree.
You don't need to create valid known destinations, we only care about the change output size. All yours:

diff --git a/src/wallet/test/fuzz/coinselection.cpp b/src/wallet/test/fuzz/coinselection.cpp --- a/src/wallet/test/fuzz/coinselection.cpp (revision ccb25a1ddc1f79f432a6718604f01ed97dced15f) +++ b/src/wallet/test/fuzz/coinselection.cpp (date 1702581796902) @@ -11,6 +11,7 @@ #include <test/util/setup_common.h> #include <wallet/coinselection.h> +#include <algorithm> #include <vector> namespace wallet { @@ -74,13 +75,6 @@ return result; } -static CTxOut GetChangePrototypeTxout(FuzzedDataProvider& fuzzed_data_provider) -{ - const CTxDestination tx_destination{ConsumeTxDestination(fuzzed_data_provider)}; - CScript script_change{GetScriptForDestination(tx_destination)}; - return CTxOut(0, script_change); -} - // Returns true if the result contains an error and the message is not empty static bool HasErrorMsg(const util::Result<SelectionResult>& res) { return !util::ErrorString(res).empty(); } @@ -101,14 +95,16 @@ coin_params.m_subtract_fee_outputs = subtract_fee_outputs; coin_params.m_long_term_feerate = long_term_fee_rate; coin_params.m_effective_feerate = effective_fee_rate; - auto change_prototype_txout{GetChangePrototypeTxout(fuzzed_data_provider)}; - coin_params.change_output_size = GetSerializeSize(change_prototype_txout); + coin_params.change_output_size = fuzzed_data_provider.ConsumeIntegralInRange(1, MAX_SCRIPT_SIZE); coin_params.m_change_fee = effective_fee_rate.GetFee(coin_params.change_output_size); coin_params.m_discard_feerate = discard_fee_rate; coin_params.change_spend_size = fuzzed_data_provider.ConsumeIntegralInRange<int>(41, 1000); const auto change_spend_fee{coin_params.m_discard_feerate.GetFee(coin_params.change_spend_size)}; coin_params.m_cost_of_change = coin_params.m_change_fee + change_spend_fee; - const auto dust{GetDustThreshold(change_prototype_txout, coin_params.m_discard_feerate)}; + // We only care about the change output size + CScript change_out_script; + std::fill_n(change_out_script.begin(), coin_params.change_output_size, OP_TRUE); + const auto dust{GetDustThreshold(CTxOut{/*nValueIn=*/0, change_out_script}, coin_params.m_discard_feerate)}; coin_params.min_viable_change = std::max(change_spend_fee + 1, dust); int next_locktime{0};

murchandamus · 2023-12-14T20:42:41Z

@@ -128,7 +128,7 @@ FUZZ_TARGET(coinselection)
     auto result_bnb = coin_params.m_subtract_fee_outputs ? util::Error{Untranslated("BnB disabled when SFFO is enabled")} :
                       SelectCoinsBnB(group_pos, target, coin_params.m_cost_of_change, MAX_STANDARD_TX_WEIGHT);
     if (result_bnb) {
-        assert(result_bnb->GetChange(coin_params.m_cost_of_change, CAmount{0}) == 0);
+        assert(result_bnb->GetChange(coin_params.min_viable_change, coin_params.m_change_fee) == 0);
         assert(result_bnb->GetSelectedValue() >= target);
         (void)result_bnb->GetShuffledInputVector();
         (void)result_bnb->GetInputSet();

Fuzzed for 1h with that change and got no new crash.

brunoerg · 2023-12-14T21:18:47Z

So, instead of passing coin_params.m_cost_of_change and 0, we should be passing coin_params.min_viable_change and coin_params.m_change_fee. Just fixing one or the other was insufficient, but when I replace both all my fuzz crashes pass.

Cool, I think the 0 came from the way we call ComputeAndSetWaste internally in SelectCoinsBnB.

brunoerg · 2023-12-14T21:19:53Z

Thanks, @furszy and @murchandamus. I will address the suggestions and leave it running for some time before pushing.

Just an observation on @furszy's suggestion - I think it will cause stack-buffer-overflow:

-    const auto dust{GetDustThreshold(change_prototype_txout, coin_params.m_discard_feerate)};
+    // We only care about the change output size
+    CScript change_out_script;
+    std::fill_n(change_out_script.begin(), coin_params.change_output_size, OP_TRUE);
+    const auto dust{GetDustThreshold(CTxOut{/*nValueIn=*/0, change_out_script}, coin_params.m_discard_feerate)};

furszy · 2023-12-14T21:46:41Z

Just an observation on @furszy's suggestion - I think it will cause stack-buffer-overflow:

-    const auto dust{GetDustThreshold(change_prototype_txout, coin_params.m_discard_feerate)};
+    // We only care about the change output size
+    CScript change_out_script;
+    std::fill_n(change_out_script.begin(), coin_params.change_output_size, OP_TRUE);
+    const auto dust{GetDustThreshold(CTxOut{/*nValueIn=*/0, change_out_script}, coin_params.m_discard_feerate)};

I coded it on the fly. You can just push the opcodes manually if std::fill_n() doesn't work or correct it in some way. The rationale is to not construct only known destinations as you are doing here. Coin selection doesn't care about them, it just uses the script size.

Change it to use same approach from `CreateTransactionInternal`.

brunoerg · 2023-12-15T09:30:53Z

Force-pushed addressing #28372 (comment) and #28372 (comment). Thanks @murchandamus and @furszy for the review!

Left it running for 10h before pushing and did not crash.

furszy

Code ACK cd81007

murchandamus · 2023-12-19T13:33:03Z

ACK cd81007

Passes all my fuzzing crashes and no new crashes with some light additional fuzzing, code LGTM.

achow101 · 2023-12-21T00:38:13Z

ACK cd81007

Change it to use same approach from `CreateTransactionInternal`. Github-Pull: bitcoin#28372 Rebased-From: cd81007

DrahtBot added the Tests label Aug 30, 2023

murchandamus reviewed Aug 30, 2023

View reviewed changes

murchandamus mentioned this pull request Aug 30, 2023

fuzz: improve coinselection #27585

Merged

DrahtBot mentioned this pull request Aug 31, 2023

wallet: don't duplicate change output if already exist #27601

Closed

maflcko added this to the 26.0 milestone Aug 31, 2023

furszy mentioned this pull request Sep 2, 2023

wallet: fix BnB selection upper bound #28395

Closed

DrahtBot added CI failed and removed CI failed labels Sep 3, 2023

maflcko removed this from the 26.0 milestone Oct 5, 2023

brunoerg marked this pull request as draft October 16, 2023 18:13

dergoegge mentioned this pull request Nov 20, 2023

fuzz, coinselection: Assertion 'result_bnb->GetChange(coin_params.m_cost_of_change, CAmount{0}) == 0' failed #28918

Closed

brunoerg force-pushed the 2023-08-fuzz-coinselection-min-viable-change branch from bb7b9e1 to ccb25a1 Compare December 13, 2023 15:09

brunoerg marked this pull request as ready for review December 13, 2023 15:09

furszy reviewed Dec 14, 2023

View reviewed changes

fuzz: coinselection, improve min_viable_change/change_output_size

cd81007

Change it to use same approach from `CreateTransactionInternal`.

brunoerg force-pushed the 2023-08-fuzz-coinselection-min-viable-change branch from ccb25a1 to cd81007 Compare December 15, 2023 09:29

furszy approved these changes Dec 15, 2023

View reviewed changes

achow101 merged commit 7524fcf into bitcoin:master Dec 21, 2023

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Mar 15, 2024

fuzz: coinselection, improve min_viable_change/change_output_size

462f2be

Change it to use same approach from `CreateTransactionInternal`. Github-Pull: bitcoin#28372 Rebased-From: cd81007

luke-jr pushed a commit to bitcoinknots/bitcoin that referenced this pull request Mar 18, 2024

fuzz: coinselection, improve min_viable_change/change_output_size

5125135

Change it to use same approach from `CreateTransactionInternal`. Github-Pull: bitcoin#28372 Rebased-From: cd81007

bitcoin locked and limited conversation to collaborators Dec 20, 2024

fuzz: coinselection, improve min_viable_change/change_output_size #28372

fuzz: coinselection, improve min_viable_change/change_output_size #28372

Uh oh!

Conversation

brunoerg commented Aug 30, 2023

Uh oh!

DrahtBot commented Aug 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage

Reviews

Conflicts

Uh oh!

murchandamus Aug 30, 2023

Choose a reason for hiding this comment

Uh oh!

murchandamus Aug 30, 2023

Choose a reason for hiding this comment

Uh oh!

brunoerg Oct 5, 2023

Choose a reason for hiding this comment

Uh oh!

furszy Dec 14, 2023

Choose a reason for hiding this comment

Uh oh!

maflcko commented Aug 31, 2023

Uh oh!

murchandamus commented Sep 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brunoerg commented Sep 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maflcko commented Oct 5, 2023

Uh oh!

furszy commented Oct 5, 2023

Uh oh!

brunoerg commented Oct 5, 2023

Uh oh!

maflcko commented Oct 5, 2023

Uh oh!

brunoerg commented Oct 16, 2023

Uh oh!

brunoerg commented Dec 13, 2023

Uh oh!

brunoerg commented Dec 13, 2023

Uh oh!

murchandamus commented Dec 14, 2023

Uh oh!

murchandamus commented Dec 14, 2023

Uh oh!

furszy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brunoerg commented Dec 14, 2023

Uh oh!

furszy commented Dec 14, 2023

Uh oh!

brunoerg commented Dec 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

murchandamus commented Dec 14, 2023

Uh oh!

brunoerg commented Dec 14, 2023

Uh oh!

murchandamus commented Dec 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

furszy commented Dec 14, 2023

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

furszy Dec 14, 2023

Choose a reason for hiding this comment

Uh oh!

murchandamus commented Dec 14, 2023

Uh oh!

brunoerg commented Dec 14, 2023

Uh oh!

fuzz: coinselection, improve `min_viable_change`/`change_output_size` #28372

fuzz: coinselection, improve `min_viable_change`/`change_output_size` #28372

DrahtBot commented Aug 30, 2023 •

edited

Loading

murchandamus commented Sep 1, 2023 •

edited

Loading

brunoerg commented Sep 2, 2023 •

edited

Loading

furszy left a comment •

edited

Loading

brunoerg commented Dec 14, 2023 •

edited

Loading

murchandamus commented Dec 14, 2023 •

edited

Loading

brunoerg commented Dec 14, 2023 •

edited

Loading