guix: remove GCC 10 workaround from NSIS #28370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed upstream in 3.06, see NSIS-Dev/nsis@229b613. https://sourceforge.net/p/nsis/bugs/1248/
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
|
|
hebasto
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
ACK 588068d.
aarch64
385084fe6d80d0b563b1b20d558b29681fd5bf624bc70c403e831cd8aae45dc0 guix-build-588068d5a12b/output/dist-archive/bitcoin-588068d5a12b.tar.gz
51f9f0d9c21598d9d37132e21c786378468c50c393b46e084d81c504186238cd guix-build-588068d5a12b/output/x86_64-w64-mingw32/SHA256SUMS.part
a4a0b55a40ba17b70c93eaba132e31c94cb2380cad0fe4e2ebe199c68a49c293 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64-debug.zip
75495c9a00ee7401b96afa51c93fe56d8b10a531ce0526f5b4713b9e8aaab9a5 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64-setup-unsigned.exe
a6e8416846ebea253d2b3c5c40f60a227bd5cfb2272a477cf364a085fea140e4 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64-unsigned.tar.gz
2bbd6cd49ad0297a5b3279a5cfbcbb35586cfdd72388e5e1ef2d87e1c8a9cf97 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64.zip
There was a problem hiding this comment.
Post-merge ACK 588068d
Reproduced the build hashes on both x86_64 and aarch64.
Frank-GER
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 8, 2023
588068d guix: remove GCC 10 workaround from NSIS (fanquake) Pull request description: Fixed upstream in 3.06. See NSIS-Dev/nsis@229b613 and https://sourceforge.net/p/nsis/bugs/1248/. Split from bitcoin#27897, as that is still WIP, and GCC 12 isn't required to make this change. This commit could have gone in with bitcoin#28328. Guix Build (same for x86_64 & aarch64): ```bash 81a565bc5c719d04cb6640cf7593d7fdd6e37935dc2ac9280f638e625c1c5f87 guix-build-588068d5a12b/output/aarch64-linux-gnu/SHA256SUMS.part 6f1ed3a2a053c3e90f1511fe33239378fc2631f46d795a955807ab39e2b93dfc guix-build-588068d5a12b/output/aarch64-linux-gnu/bitcoin-588068d5a12b-aarch64-linux-gnu-debug.tar.gz c8a2904c651b862d9dce3f4094b59b66be5e745111b75c420452bd04ab9cdbe3 guix-build-588068d5a12b/output/aarch64-linux-gnu/bitcoin-588068d5a12b-aarch64-linux-gnu.tar.gz 654bb5d89e12f936e63e2c910c78842c43db7048a895052295f613a50b639857 guix-build-588068d5a12b/output/arm-linux-gnueabihf/SHA256SUMS.part 8a1b67f3c12b579b374c559f59d709bd83bcd3cff3ec5a4274119c0e5f6c388f guix-build-588068d5a12b/output/arm-linux-gnueabihf/bitcoin-588068d5a12b-arm-linux-gnueabihf-debug.tar.gz 7d8a3327599702a94be4b8d49eda7857f732c290773a775c6de507da656e271b guix-build-588068d5a12b/output/arm-linux-gnueabihf/bitcoin-588068d5a12b-arm-linux-gnueabihf.tar.gz 215786257409612206db7ff4008dbcb6a60dcf6cc92a1a437124a1483612f699 guix-build-588068d5a12b/output/arm64-apple-darwin/SHA256SUMS.part e36b41c531d34ca843028b778163bed4ce4c52310ed8056eff8a1a1b47b61fb7 guix-build-588068d5a12b/output/arm64-apple-darwin/bitcoin-588068d5a12b-arm64-apple-darwin-unsigned.dmg ecb488625bdf566e7c63781795f296ec4f630ef90edf7e6073591ed1d9b90bda guix-build-588068d5a12b/output/arm64-apple-darwin/bitcoin-588068d5a12b-arm64-apple-darwin-unsigned.tar.gz d8f9759a903cd052ea3e562d1ef186c9dad38089205650d1bcb218e7506c378f guix-build-588068d5a12b/output/arm64-apple-darwin/bitcoin-588068d5a12b-arm64-apple-darwin.tar.gz 385084fe6d80d0b563b1b20d558b29681fd5bf624bc70c403e831cd8aae45dc0 guix-build-588068d5a12b/output/dist-archive/bitcoin-588068d5a12b.tar.gz 89504c8be28482d4f70740d6865aa26db0e1854d0b35598c43462cd35f0b49c4 guix-build-588068d5a12b/output/powerpc64-linux-gnu/SHA256SUMS.part 5836bfb4c9a11318362a89db25e4cd9363688ae6be18a6abfd1974a52c0b2759 guix-build-588068d5a12b/output/powerpc64-linux-gnu/bitcoin-588068d5a12b-powerpc64-linux-gnu-debug.tar.gz 3e6f4481a594316ab08ea946c5fac6055ca8a81a91ce0a20c44976b3bc4f8d0d guix-build-588068d5a12b/output/powerpc64-linux-gnu/bitcoin-588068d5a12b-powerpc64-linux-gnu.tar.gz 4e753efe5a20cf6f1e83e604d9f8ba0d79b3c96fc5d5487ec7ed0f33c819b99a guix-build-588068d5a12b/output/powerpc64le-linux-gnu/SHA256SUMS.part 9d29e49b519ce1d683531699dd15e72495052151b21404affc50e7b228155eb1 guix-build-588068d5a12b/output/powerpc64le-linux-gnu/bitcoin-588068d5a12b-powerpc64le-linux-gnu-debug.tar.gz 511179d90bbf6beb45b6168575a78600d38a060891dc1aa8f11f0adc5ba51f87 guix-build-588068d5a12b/output/powerpc64le-linux-gnu/bitcoin-588068d5a12b-powerpc64le-linux-gnu.tar.gz d46184105524d59a75066b067b63df6bfd2203d8003c343a5898ee7d4e4f78e5 guix-build-588068d5a12b/output/riscv64-linux-gnu/SHA256SUMS.part b6434ec5a4a046b9448f36f5596f6db0f8cd71a3e4383827869fcbaa25e005e4 guix-build-588068d5a12b/output/riscv64-linux-gnu/bitcoin-588068d5a12b-riscv64-linux-gnu-debug.tar.gz 237e37ccae4095a1d8aa34d6b967655561ba0a524dfb79e3dcd4c18ad8f8a222 guix-build-588068d5a12b/output/riscv64-linux-gnu/bitcoin-588068d5a12b-riscv64-linux-gnu.tar.gz db28897936262e344da8011d37afde97ed53ba4f5ce1a3f935d258284b22e649 guix-build-588068d5a12b/output/x86_64-apple-darwin/SHA256SUMS.part 8d71763fc748cde1f68785eef4b1a498c1ec4c13cf94f02ad8727debe0d94a1d guix-build-588068d5a12b/output/x86_64-apple-darwin/bitcoin-588068d5a12b-x86_64-apple-darwin-unsigned.dmg 1e0bf2ef0f65f2e7fe5439fe0a15a4803e06d7c42dae06133be5d1b67fa30657 guix-build-588068d5a12b/output/x86_64-apple-darwin/bitcoin-588068d5a12b-x86_64-apple-darwin-unsigned.tar.gz 2d71083593583f3a3ed2e83d4a05f67338e9cb51cb730d238827eef7d3e9007e guix-build-588068d5a12b/output/x86_64-apple-darwin/bitcoin-588068d5a12b-x86_64-apple-darwin.tar.gz cc3cc2c1077a04d5643ca21a43b8b7f233b8c743eb73f066643ddfd4a1e1ce27 guix-build-588068d5a12b/output/x86_64-linux-gnu/SHA256SUMS.part e18c1c0c1cf836c9e540edd969d2657afd3847345b1e0a6e5a9bebfd35782c47 guix-build-588068d5a12b/output/x86_64-linux-gnu/bitcoin-588068d5a12b-x86_64-linux-gnu-debug.tar.gz 4c88aa50227ccd7bb9069369cfc2196de42212f5d0553902155346ae39ef2401 guix-build-588068d5a12b/output/x86_64-linux-gnu/bitcoin-588068d5a12b-x86_64-linux-gnu.tar.gz 51f9f0d9c21598d9d37132e21c786378468c50c393b46e084d81c504186238cd guix-build-588068d5a12b/output/x86_64-w64-mingw32/SHA256SUMS.part a4a0b55a40ba17b70c93eaba132e31c94cb2380cad0fe4e2ebe199c68a49c293 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64-debug.zip 75495c9a00ee7401b96afa51c93fe56d8b10a531ce0526f5b4713b9e8aaab9a5 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64-setup-unsigned.exe a6e8416846ebea253d2b3c5c40f60a227bd5cfb2272a477cf364a085fea140e4 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64-unsigned.tar.gz 2bbd6cd49ad0297a5b3279a5cfbcbb35586cfdd72388e5e1ef2d87e1c8a9cf97 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64.zip ``` ACKs for top commit: hebasto: ACK 588068d. Tree-SHA512: e5876d64ee02fef8a7152b9f649949933b356347de713e00a58aba278243b7de999c3fc50f3cc88e625d07a38e5a6ec2afcb6e836d256b6ac91e91f90f473e64
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 11, 2023
588068d guix: remove GCC 10 workaround from NSIS (fanquake) Pull request description: Fixed upstream in 3.06. See NSIS-Dev/nsis@229b613 and https://sourceforge.net/p/nsis/bugs/1248/. Split from bitcoin#27897, as that is still WIP, and GCC 12 isn't required to make this change. This commit could have gone in with bitcoin#28328. Guix Build (same for x86_64 & aarch64): ```bash 81a565bc5c719d04cb6640cf7593d7fdd6e37935dc2ac9280f638e625c1c5f87 guix-build-588068d5a12b/output/aarch64-linux-gnu/SHA256SUMS.part 6f1ed3a2a053c3e90f1511fe33239378fc2631f46d795a955807ab39e2b93dfc guix-build-588068d5a12b/output/aarch64-linux-gnu/bitcoin-588068d5a12b-aarch64-linux-gnu-debug.tar.gz c8a2904c651b862d9dce3f4094b59b66be5e745111b75c420452bd04ab9cdbe3 guix-build-588068d5a12b/output/aarch64-linux-gnu/bitcoin-588068d5a12b-aarch64-linux-gnu.tar.gz 654bb5d89e12f936e63e2c910c78842c43db7048a895052295f613a50b639857 guix-build-588068d5a12b/output/arm-linux-gnueabihf/SHA256SUMS.part 8a1b67f3c12b579b374c559f59d709bd83bcd3cff3ec5a4274119c0e5f6c388f guix-build-588068d5a12b/output/arm-linux-gnueabihf/bitcoin-588068d5a12b-arm-linux-gnueabihf-debug.tar.gz 7d8a3327599702a94be4b8d49eda7857f732c290773a775c6de507da656e271b guix-build-588068d5a12b/output/arm-linux-gnueabihf/bitcoin-588068d5a12b-arm-linux-gnueabihf.tar.gz 215786257409612206db7ff4008dbcb6a60dcf6cc92a1a437124a1483612f699 guix-build-588068d5a12b/output/arm64-apple-darwin/SHA256SUMS.part e36b41c531d34ca843028b778163bed4ce4c52310ed8056eff8a1a1b47b61fb7 guix-build-588068d5a12b/output/arm64-apple-darwin/bitcoin-588068d5a12b-arm64-apple-darwin-unsigned.dmg ecb488625bdf566e7c63781795f296ec4f630ef90edf7e6073591ed1d9b90bda guix-build-588068d5a12b/output/arm64-apple-darwin/bitcoin-588068d5a12b-arm64-apple-darwin-unsigned.tar.gz d8f9759a903cd052ea3e562d1ef186c9dad38089205650d1bcb218e7506c378f guix-build-588068d5a12b/output/arm64-apple-darwin/bitcoin-588068d5a12b-arm64-apple-darwin.tar.gz 385084fe6d80d0b563b1b20d558b29681fd5bf624bc70c403e831cd8aae45dc0 guix-build-588068d5a12b/output/dist-archive/bitcoin-588068d5a12b.tar.gz 89504c8be28482d4f70740d6865aa26db0e1854d0b35598c43462cd35f0b49c4 guix-build-588068d5a12b/output/powerpc64-linux-gnu/SHA256SUMS.part 5836bfb4c9a11318362a89db25e4cd9363688ae6be18a6abfd1974a52c0b2759 guix-build-588068d5a12b/output/powerpc64-linux-gnu/bitcoin-588068d5a12b-powerpc64-linux-gnu-debug.tar.gz 3e6f4481a594316ab08ea946c5fac6055ca8a81a91ce0a20c44976b3bc4f8d0d guix-build-588068d5a12b/output/powerpc64-linux-gnu/bitcoin-588068d5a12b-powerpc64-linux-gnu.tar.gz 4e753efe5a20cf6f1e83e604d9f8ba0d79b3c96fc5d5487ec7ed0f33c819b99a guix-build-588068d5a12b/output/powerpc64le-linux-gnu/SHA256SUMS.part 9d29e49b519ce1d683531699dd15e72495052151b21404affc50e7b228155eb1 guix-build-588068d5a12b/output/powerpc64le-linux-gnu/bitcoin-588068d5a12b-powerpc64le-linux-gnu-debug.tar.gz 511179d90bbf6beb45b6168575a78600d38a060891dc1aa8f11f0adc5ba51f87 guix-build-588068d5a12b/output/powerpc64le-linux-gnu/bitcoin-588068d5a12b-powerpc64le-linux-gnu.tar.gz d46184105524d59a75066b067b63df6bfd2203d8003c343a5898ee7d4e4f78e5 guix-build-588068d5a12b/output/riscv64-linux-gnu/SHA256SUMS.part b6434ec5a4a046b9448f36f5596f6db0f8cd71a3e4383827869fcbaa25e005e4 guix-build-588068d5a12b/output/riscv64-linux-gnu/bitcoin-588068d5a12b-riscv64-linux-gnu-debug.tar.gz 237e37ccae4095a1d8aa34d6b967655561ba0a524dfb79e3dcd4c18ad8f8a222 guix-build-588068d5a12b/output/riscv64-linux-gnu/bitcoin-588068d5a12b-riscv64-linux-gnu.tar.gz db28897936262e344da8011d37afde97ed53ba4f5ce1a3f935d258284b22e649 guix-build-588068d5a12b/output/x86_64-apple-darwin/SHA256SUMS.part 8d71763fc748cde1f68785eef4b1a498c1ec4c13cf94f02ad8727debe0d94a1d guix-build-588068d5a12b/output/x86_64-apple-darwin/bitcoin-588068d5a12b-x86_64-apple-darwin-unsigned.dmg 1e0bf2ef0f65f2e7fe5439fe0a15a4803e06d7c42dae06133be5d1b67fa30657 guix-build-588068d5a12b/output/x86_64-apple-darwin/bitcoin-588068d5a12b-x86_64-apple-darwin-unsigned.tar.gz 2d71083593583f3a3ed2e83d4a05f67338e9cb51cb730d238827eef7d3e9007e guix-build-588068d5a12b/output/x86_64-apple-darwin/bitcoin-588068d5a12b-x86_64-apple-darwin.tar.gz cc3cc2c1077a04d5643ca21a43b8b7f233b8c743eb73f066643ddfd4a1e1ce27 guix-build-588068d5a12b/output/x86_64-linux-gnu/SHA256SUMS.part e18c1c0c1cf836c9e540edd969d2657afd3847345b1e0a6e5a9bebfd35782c47 guix-build-588068d5a12b/output/x86_64-linux-gnu/bitcoin-588068d5a12b-x86_64-linux-gnu-debug.tar.gz 4c88aa50227ccd7bb9069369cfc2196de42212f5d0553902155346ae39ef2401 guix-build-588068d5a12b/output/x86_64-linux-gnu/bitcoin-588068d5a12b-x86_64-linux-gnu.tar.gz 51f9f0d9c21598d9d37132e21c786378468c50c393b46e084d81c504186238cd guix-build-588068d5a12b/output/x86_64-w64-mingw32/SHA256SUMS.part a4a0b55a40ba17b70c93eaba132e31c94cb2380cad0fe4e2ebe199c68a49c293 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64-debug.zip 75495c9a00ee7401b96afa51c93fe56d8b10a531ce0526f5b4713b9e8aaab9a5 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64-setup-unsigned.exe a6e8416846ebea253d2b3c5c40f60a227bd5cfb2272a477cf364a085fea140e4 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64-unsigned.tar.gz 2bbd6cd49ad0297a5b3279a5cfbcbb35586cfdd72388e5e1ef2d87e1c8a9cf97 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64.zip ``` ACKs for top commit: hebasto: ACK 588068d. Tree-SHA512: e5876d64ee02fef8a7152b9f649949933b356347de713e00a58aba278243b7de999c3fc50f3cc88e625d07a38e5a6ec2afcb6e836d256b6ac91e91f90f473e64
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 27, 2023
588068d guix: remove GCC 10 workaround from NSIS (fanquake) Pull request description: Fixed upstream in 3.06. See NSIS-Dev/nsis@229b613 and https://sourceforge.net/p/nsis/bugs/1248/. Split from bitcoin#27897, as that is still WIP, and GCC 12 isn't required to make this change. This commit could have gone in with bitcoin#28328. Guix Build (same for x86_64 & aarch64): ```bash 81a565bc5c719d04cb6640cf7593d7fdd6e37935dc2ac9280f638e625c1c5f87 guix-build-588068d5a12b/output/aarch64-linux-gnu/SHA256SUMS.part 6f1ed3a2a053c3e90f1511fe33239378fc2631f46d795a955807ab39e2b93dfc guix-build-588068d5a12b/output/aarch64-linux-gnu/bitcoin-588068d5a12b-aarch64-linux-gnu-debug.tar.gz c8a2904c651b862d9dce3f4094b59b66be5e745111b75c420452bd04ab9cdbe3 guix-build-588068d5a12b/output/aarch64-linux-gnu/bitcoin-588068d5a12b-aarch64-linux-gnu.tar.gz 654bb5d89e12f936e63e2c910c78842c43db7048a895052295f613a50b639857 guix-build-588068d5a12b/output/arm-linux-gnueabihf/SHA256SUMS.part 8a1b67f3c12b579b374c559f59d709bd83bcd3cff3ec5a4274119c0e5f6c388f guix-build-588068d5a12b/output/arm-linux-gnueabihf/bitcoin-588068d5a12b-arm-linux-gnueabihf-debug.tar.gz 7d8a3327599702a94be4b8d49eda7857f732c290773a775c6de507da656e271b guix-build-588068d5a12b/output/arm-linux-gnueabihf/bitcoin-588068d5a12b-arm-linux-gnueabihf.tar.gz 215786257409612206db7ff4008dbcb6a60dcf6cc92a1a437124a1483612f699 guix-build-588068d5a12b/output/arm64-apple-darwin/SHA256SUMS.part e36b41c531d34ca843028b778163bed4ce4c52310ed8056eff8a1a1b47b61fb7 guix-build-588068d5a12b/output/arm64-apple-darwin/bitcoin-588068d5a12b-arm64-apple-darwin-unsigned.dmg ecb488625bdf566e7c63781795f296ec4f630ef90edf7e6073591ed1d9b90bda guix-build-588068d5a12b/output/arm64-apple-darwin/bitcoin-588068d5a12b-arm64-apple-darwin-unsigned.tar.gz d8f9759a903cd052ea3e562d1ef186c9dad38089205650d1bcb218e7506c378f guix-build-588068d5a12b/output/arm64-apple-darwin/bitcoin-588068d5a12b-arm64-apple-darwin.tar.gz 385084fe6d80d0b563b1b20d558b29681fd5bf624bc70c403e831cd8aae45dc0 guix-build-588068d5a12b/output/dist-archive/bitcoin-588068d5a12b.tar.gz 89504c8be28482d4f70740d6865aa26db0e1854d0b35598c43462cd35f0b49c4 guix-build-588068d5a12b/output/powerpc64-linux-gnu/SHA256SUMS.part 5836bfb4c9a11318362a89db25e4cd9363688ae6be18a6abfd1974a52c0b2759 guix-build-588068d5a12b/output/powerpc64-linux-gnu/bitcoin-588068d5a12b-powerpc64-linux-gnu-debug.tar.gz 3e6f4481a594316ab08ea946c5fac6055ca8a81a91ce0a20c44976b3bc4f8d0d guix-build-588068d5a12b/output/powerpc64-linux-gnu/bitcoin-588068d5a12b-powerpc64-linux-gnu.tar.gz 4e753efe5a20cf6f1e83e604d9f8ba0d79b3c96fc5d5487ec7ed0f33c819b99a guix-build-588068d5a12b/output/powerpc64le-linux-gnu/SHA256SUMS.part 9d29e49b519ce1d683531699dd15e72495052151b21404affc50e7b228155eb1 guix-build-588068d5a12b/output/powerpc64le-linux-gnu/bitcoin-588068d5a12b-powerpc64le-linux-gnu-debug.tar.gz 511179d90bbf6beb45b6168575a78600d38a060891dc1aa8f11f0adc5ba51f87 guix-build-588068d5a12b/output/powerpc64le-linux-gnu/bitcoin-588068d5a12b-powerpc64le-linux-gnu.tar.gz d46184105524d59a75066b067b63df6bfd2203d8003c343a5898ee7d4e4f78e5 guix-build-588068d5a12b/output/riscv64-linux-gnu/SHA256SUMS.part b6434ec5a4a046b9448f36f5596f6db0f8cd71a3e4383827869fcbaa25e005e4 guix-build-588068d5a12b/output/riscv64-linux-gnu/bitcoin-588068d5a12b-riscv64-linux-gnu-debug.tar.gz 237e37ccae4095a1d8aa34d6b967655561ba0a524dfb79e3dcd4c18ad8f8a222 guix-build-588068d5a12b/output/riscv64-linux-gnu/bitcoin-588068d5a12b-riscv64-linux-gnu.tar.gz db28897936262e344da8011d37afde97ed53ba4f5ce1a3f935d258284b22e649 guix-build-588068d5a12b/output/x86_64-apple-darwin/SHA256SUMS.part 8d71763fc748cde1f68785eef4b1a498c1ec4c13cf94f02ad8727debe0d94a1d guix-build-588068d5a12b/output/x86_64-apple-darwin/bitcoin-588068d5a12b-x86_64-apple-darwin-unsigned.dmg 1e0bf2ef0f65f2e7fe5439fe0a15a4803e06d7c42dae06133be5d1b67fa30657 guix-build-588068d5a12b/output/x86_64-apple-darwin/bitcoin-588068d5a12b-x86_64-apple-darwin-unsigned.tar.gz 2d71083593583f3a3ed2e83d4a05f67338e9cb51cb730d238827eef7d3e9007e guix-build-588068d5a12b/output/x86_64-apple-darwin/bitcoin-588068d5a12b-x86_64-apple-darwin.tar.gz cc3cc2c1077a04d5643ca21a43b8b7f233b8c743eb73f066643ddfd4a1e1ce27 guix-build-588068d5a12b/output/x86_64-linux-gnu/SHA256SUMS.part e18c1c0c1cf836c9e540edd969d2657afd3847345b1e0a6e5a9bebfd35782c47 guix-build-588068d5a12b/output/x86_64-linux-gnu/bitcoin-588068d5a12b-x86_64-linux-gnu-debug.tar.gz 4c88aa50227ccd7bb9069369cfc2196de42212f5d0553902155346ae39ef2401 guix-build-588068d5a12b/output/x86_64-linux-gnu/bitcoin-588068d5a12b-x86_64-linux-gnu.tar.gz 51f9f0d9c21598d9d37132e21c786378468c50c393b46e084d81c504186238cd guix-build-588068d5a12b/output/x86_64-w64-mingw32/SHA256SUMS.part a4a0b55a40ba17b70c93eaba132e31c94cb2380cad0fe4e2ebe199c68a49c293 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64-debug.zip 75495c9a00ee7401b96afa51c93fe56d8b10a531ce0526f5b4713b9e8aaab9a5 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64-setup-unsigned.exe a6e8416846ebea253d2b3c5c40f60a227bd5cfb2272a477cf364a085fea140e4 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64-unsigned.tar.gz 2bbd6cd49ad0297a5b3279a5cfbcbb35586cfdd72388e5e1ef2d87e1c8a9cf97 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64.zip ``` ACKs for top commit: hebasto: ACK 588068d. Tree-SHA512: e5876d64ee02fef8a7152b9f649949933b356347de713e00a58aba278243b7de999c3fc50f3cc88e625d07a38e5a6ec2afcb6e836d256b6ac91e91f90f473e64
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Dec 6, 2023
588068d guix: remove GCC 10 workaround from NSIS (fanquake) Pull request description: Fixed upstream in 3.06. See NSIS-Dev/nsis@229b613 and https://sourceforge.net/p/nsis/bugs/1248/. Split from bitcoin#27897, as that is still WIP, and GCC 12 isn't required to make this change. This commit could have gone in with bitcoin#28328. Guix Build (same for x86_64 & aarch64): ```bash 81a565bc5c719d04cb6640cf7593d7fdd6e37935dc2ac9280f638e625c1c5f87 guix-build-588068d5a12b/output/aarch64-linux-gnu/SHA256SUMS.part 6f1ed3a2a053c3e90f1511fe33239378fc2631f46d795a955807ab39e2b93dfc guix-build-588068d5a12b/output/aarch64-linux-gnu/bitcoin-588068d5a12b-aarch64-linux-gnu-debug.tar.gz c8a2904c651b862d9dce3f4094b59b66be5e745111b75c420452bd04ab9cdbe3 guix-build-588068d5a12b/output/aarch64-linux-gnu/bitcoin-588068d5a12b-aarch64-linux-gnu.tar.gz 654bb5d89e12f936e63e2c910c78842c43db7048a895052295f613a50b639857 guix-build-588068d5a12b/output/arm-linux-gnueabihf/SHA256SUMS.part 8a1b67f3c12b579b374c559f59d709bd83bcd3cff3ec5a4274119c0e5f6c388f guix-build-588068d5a12b/output/arm-linux-gnueabihf/bitcoin-588068d5a12b-arm-linux-gnueabihf-debug.tar.gz 7d8a3327599702a94be4b8d49eda7857f732c290773a775c6de507da656e271b guix-build-588068d5a12b/output/arm-linux-gnueabihf/bitcoin-588068d5a12b-arm-linux-gnueabihf.tar.gz 215786257409612206db7ff4008dbcb6a60dcf6cc92a1a437124a1483612f699 guix-build-588068d5a12b/output/arm64-apple-darwin/SHA256SUMS.part e36b41c531d34ca843028b778163bed4ce4c52310ed8056eff8a1a1b47b61fb7 guix-build-588068d5a12b/output/arm64-apple-darwin/bitcoin-588068d5a12b-arm64-apple-darwin-unsigned.dmg ecb488625bdf566e7c63781795f296ec4f630ef90edf7e6073591ed1d9b90bda guix-build-588068d5a12b/output/arm64-apple-darwin/bitcoin-588068d5a12b-arm64-apple-darwin-unsigned.tar.gz d8f9759a903cd052ea3e562d1ef186c9dad38089205650d1bcb218e7506c378f guix-build-588068d5a12b/output/arm64-apple-darwin/bitcoin-588068d5a12b-arm64-apple-darwin.tar.gz 385084fe6d80d0b563b1b20d558b29681fd5bf624bc70c403e831cd8aae45dc0 guix-build-588068d5a12b/output/dist-archive/bitcoin-588068d5a12b.tar.gz 89504c8be28482d4f70740d6865aa26db0e1854d0b35598c43462cd35f0b49c4 guix-build-588068d5a12b/output/powerpc64-linux-gnu/SHA256SUMS.part 5836bfb4c9a11318362a89db25e4cd9363688ae6be18a6abfd1974a52c0b2759 guix-build-588068d5a12b/output/powerpc64-linux-gnu/bitcoin-588068d5a12b-powerpc64-linux-gnu-debug.tar.gz 3e6f4481a594316ab08ea946c5fac6055ca8a81a91ce0a20c44976b3bc4f8d0d guix-build-588068d5a12b/output/powerpc64-linux-gnu/bitcoin-588068d5a12b-powerpc64-linux-gnu.tar.gz 4e753efe5a20cf6f1e83e604d9f8ba0d79b3c96fc5d5487ec7ed0f33c819b99a guix-build-588068d5a12b/output/powerpc64le-linux-gnu/SHA256SUMS.part 9d29e49b519ce1d683531699dd15e72495052151b21404affc50e7b228155eb1 guix-build-588068d5a12b/output/powerpc64le-linux-gnu/bitcoin-588068d5a12b-powerpc64le-linux-gnu-debug.tar.gz 511179d90bbf6beb45b6168575a78600d38a060891dc1aa8f11f0adc5ba51f87 guix-build-588068d5a12b/output/powerpc64le-linux-gnu/bitcoin-588068d5a12b-powerpc64le-linux-gnu.tar.gz d46184105524d59a75066b067b63df6bfd2203d8003c343a5898ee7d4e4f78e5 guix-build-588068d5a12b/output/riscv64-linux-gnu/SHA256SUMS.part b6434ec5a4a046b9448f36f5596f6db0f8cd71a3e4383827869fcbaa25e005e4 guix-build-588068d5a12b/output/riscv64-linux-gnu/bitcoin-588068d5a12b-riscv64-linux-gnu-debug.tar.gz 237e37ccae4095a1d8aa34d6b967655561ba0a524dfb79e3dcd4c18ad8f8a222 guix-build-588068d5a12b/output/riscv64-linux-gnu/bitcoin-588068d5a12b-riscv64-linux-gnu.tar.gz db28897936262e344da8011d37afde97ed53ba4f5ce1a3f935d258284b22e649 guix-build-588068d5a12b/output/x86_64-apple-darwin/SHA256SUMS.part 8d71763fc748cde1f68785eef4b1a498c1ec4c13cf94f02ad8727debe0d94a1d guix-build-588068d5a12b/output/x86_64-apple-darwin/bitcoin-588068d5a12b-x86_64-apple-darwin-unsigned.dmg 1e0bf2ef0f65f2e7fe5439fe0a15a4803e06d7c42dae06133be5d1b67fa30657 guix-build-588068d5a12b/output/x86_64-apple-darwin/bitcoin-588068d5a12b-x86_64-apple-darwin-unsigned.tar.gz 2d71083593583f3a3ed2e83d4a05f67338e9cb51cb730d238827eef7d3e9007e guix-build-588068d5a12b/output/x86_64-apple-darwin/bitcoin-588068d5a12b-x86_64-apple-darwin.tar.gz cc3cc2c1077a04d5643ca21a43b8b7f233b8c743eb73f066643ddfd4a1e1ce27 guix-build-588068d5a12b/output/x86_64-linux-gnu/SHA256SUMS.part e18c1c0c1cf836c9e540edd969d2657afd3847345b1e0a6e5a9bebfd35782c47 guix-build-588068d5a12b/output/x86_64-linux-gnu/bitcoin-588068d5a12b-x86_64-linux-gnu-debug.tar.gz 4c88aa50227ccd7bb9069369cfc2196de42212f5d0553902155346ae39ef2401 guix-build-588068d5a12b/output/x86_64-linux-gnu/bitcoin-588068d5a12b-x86_64-linux-gnu.tar.gz 51f9f0d9c21598d9d37132e21c786378468c50c393b46e084d81c504186238cd guix-build-588068d5a12b/output/x86_64-w64-mingw32/SHA256SUMS.part a4a0b55a40ba17b70c93eaba132e31c94cb2380cad0fe4e2ebe199c68a49c293 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64-debug.zip 75495c9a00ee7401b96afa51c93fe56d8b10a531ce0526f5b4713b9e8aaab9a5 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64-setup-unsigned.exe a6e8416846ebea253d2b3c5c40f60a227bd5cfb2272a477cf364a085fea140e4 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64-unsigned.tar.gz 2bbd6cd49ad0297a5b3279a5cfbcbb35586cfdd72388e5e1ef2d87e1c8a9cf97 guix-build-588068d5a12b/output/x86_64-w64-mingw32/bitcoin-588068d5a12b-win64.zip ``` ACKs for top commit: hebasto: ACK 588068d. Tree-SHA512: e5876d64ee02fef8a7152b9f649949933b356347de713e00a58aba278243b7de999c3fc50f3cc88e625d07a38e5a6ec2afcb6e836d256b6ac91e91f90f473e64
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 20, 2024
Summary: > guix: update python-oscrypto to 1.3.0 > > This is required for bumping the time-machine, for compatibility with > OpenSSL: > > oscrypto: openssl backend, 1.2.1, /tmp/guix-build-python-oscrypto-1.2.1.drv-0/source/oscrypto > Traceback (most recent call last): > File "/tmp/guix-build-python-oscrypto-1.2.1.drv-0/source/oscrypto/_openssl/_libcrypto_ctypes.py", line 304, in <module> > libcrypto.EVP_PKEY_size.argtypes = [ > File "/gnu/store/9dkl9fnidcdpw19ncw5pk0p7dljx7ijb-python-3.10.7/lib/python3.10/ctypes/__init__.py", line 387, in __getattr__ > func = self.__getitem__(name) > File "/gnu/store/9dkl9fnidcdpw19ncw5pk0p7dljx7ijb-python-3.10.7/lib/python3.10/ctypes/__init__.py", line 392, in __getitem__ > func = self._FuncPtr((name_or_ordinal, self)) > AttributeError: /gnu/store/2hr7w64zhr6jjznidyc2xi40d5ynhj9c-openssl-3.0.8/lib/libcrypto.so.3: undefined symbol: EVP_PKEY_size. Did you mean: 'EVP_PKEY_free'? bitcoin/bitcoin@f1a4afb > guix: update time-machine to 160f78a4d92205df986ed9efcce7d3aac188cb24 > > In our time-machine environment this changes the following: > > GCC 10.3.0 -> 10.4.0 > Binutils 2.37 -> 2.38 > Linux Libre Headers 5.15.37 -> 5.15.127 > git 2.36.0 -> 2.41.0 > mingw-w64 8.0.0 -> 11.0.1 > NSIS 3.05 -> 3.09 > xorriso 1.5.2 -> 1.5.6.pl02 > Python 3.9 -> 3.10.7 > Python-asn1crypto 1.4.0 -> 1.5.1 > > GCC 12.3.0 becomes available. > LLVM 15.0.7 becomes available. bitcoin/bitcoin@ea4387e > guix: use cross-* keyword arguments > > Using the new time-machine results in warnings about consistently using > keyword arguments: > ```bash > guix environment: warning: 'cross-kernel-headers' must be used with keyword arguments > guix environment: warning: 'cross-libc' must be used with keyword arguments > ``` bitcoin/bitcoin@1f6c75e > guix: drop NSIS patch now that we use 3.09 > > See https://sourceforge.net/p/nsis/bugs/1283/. bitcoin/bitcoin@a1d4a42 > guix: drop Windows broken-longjmp.patch > > This is no-longer required, now that we are building using GCC 10.4.0. bitcoin/bitcoin@6cbedc3 > guix: remove GCC 10 workaround from NSIS > > Fixed upstream in 3.06, see > NSIS-Dev/nsis@229b613. > https://sourceforge.net/p/nsis/bugs/1248/ From the PR discussion: > This commit could have gone in with [[bitcoin/bitcoin#28328 | core#28328]] bitcoin/bitcoin@588068d This is a backport of [[bitcoin/bitcoin#28328 | core#28328]] and [[bitcoin/bitcoin#28370 | core#28370]] Depends on D15488 Test Plan: `contrib/guix/guix-build` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D15490
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed upstream in 3.06.
See NSIS-Dev/nsis@229b613 and https://sourceforge.net/p/nsis/bugs/1248/.
Split from #27897, as that is still WIP, and GCC 12 isn't required to make this change.
This commit could have gone in with #28328.
Guix Build (same for x86_64 & aarch64):