Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Aug 22, 2023

This PR is an amendment for #28282.

It avoids skipping builds when some pushes were done consequentially:

image

From GitHub Actions docs:

When a concurrent ... workflow is queued, if another ... workflow using the same concurrency group in the repository is in progress, the queued ... workflow will be pending. Any previously pending ... workflow in the concurrency group will be canceled.

No behavior change for pull requests:

image

@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 22, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK MarcoFalke, dergoegge

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Aug 22, 2023
@hebasto hebasto marked this pull request as draft August 22, 2023 10:20
@hebasto hebasto marked this pull request as ready for review August 22, 2023 10:20
Otherwise, any previously pending workflow will be canceled on the
following push.
@hebasto hebasto requested a review from maflcko August 22, 2023 11:23
@maflcko
Copy link
Member

maflcko commented Aug 22, 2023

review only ACK e7d67ef

@hebasto hebasto requested a review from fanquake August 22, 2023 13:15
real-or-random added a commit to bitcoin-core/secp256k1 that referenced this pull request Aug 23, 2023
ee1be62 ci: Use concurrency for pull requests only (Hennadii Stepanov)

Pull request description:

  This PR is an amendment for #1403.

  It avoids skipping builds when some pushes were done consequentially.

  From GitHub Actions [docs](https://docs.github.com/en/actions/using-jobs/using-concurrency):

  > When a concurrent ... workflow is queued, if another ... workflow using the same concurrency group in the repository is in progress, the queued ... workflow will be pending. **Any previously pending ... workflow in the concurrency group will be canceled.**

  No behavior change for pull requests.

  Same as bitcoin/bitcoin#28322.

ACKs for top commit:
  real-or-random:
    ACK ee1be62

Tree-SHA512: ce26378c3224a7647eb3b351d19e9308650ad49b933a68d37a0eca8516767a63f55580a33b02864caa539392c9aab0b4b54ecbace85bea6082bf533539a37c9c
Copy link
Member

@dergoegge dergoegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ACK e7d67ef

@hebasto
Copy link
Member Author

hebasto commented Aug 24, 2023

@fanquake

Anything else I need to do here?

@fanquake fanquake merged commit 94af164 into bitcoin:master Aug 24, 2023
@hebasto hebasto deleted the 230822-concurr branch August 24, 2023 09:28
@hebasto
Copy link
Member Author

hebasto commented Aug 24, 2023

It works as expected. No job skipped:

image

Frank-GER pushed a commit to syscoin/syscoin that referenced this pull request Sep 8, 2023
e7d67ef ci: Use concurrency for pull requests only (Hennadii Stepanov)

Pull request description:

  This PR is an amendment for bitcoin#28282.

  It avoids skipping builds when some pushes were done consequentially:

  ![image](https://github.com/bitcoin/bitcoin/assets/32963518/977e9ead-1856-4020-82eb-d16dbead5753)

  From GitHub Actions [docs](https://docs.github.com/en/actions/using-jobs/using-concurrency):

  > When a concurrent ... workflow is queued, if another ... workflow using the same concurrency group in the repository is in progress, the queued ... workflow will be pending. **Any previously pending ... workflow in the concurrency group will be canceled.**

  No behavior change for pull requests:

  ![image](https://github.com/bitcoin/bitcoin/assets/32963518/4865ae04-fc42-4028-b91e-500c0b36bce6)

ACKs for top commit:
  MarcoFalke:
    review only ACK e7d67ef
  dergoegge:
    lgtm ACK e7d67ef

Tree-SHA512: 360be9dbb46354d988935643e8793ea630c3416609c45aab4c39075a00a427487446a34a4fb93b490ece43cabe43640fcc6fb2ac97760e2c6ee54b95241da826
@bitcoin bitcoin locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants