rpc: remove one more quote from non-string oneline description #28289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a silent conflict betwen bitcoin#28123 and bitcoin#27460
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
jonatack
reviewed
Aug 17, 2023
There was a problem hiding this comment.
ACK 2394314
With this change, ./test/functional/test_runner.py --jobs=11 --timeout-factor=0 --coverage no longer warns as it does on current master
Uncovered RPC commands:
- Internal
and .oneline_description in this RPC is set to a value similar to that in the other RPCs.
|
utACK 2394314 |
|
lgtm ACK 2394314 |
hebasto
approved these changes
Aug 18, 2023
Frank-GER
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 8, 2023
…ne description 2394314 rpc: remove one more quote from non-string oneline description (Martin Zumsande) Pull request description: This fixes a silent conflict between bitcoin#28123 (which removed all `\"options\"`) and bitcoin#27460 (which added a new one). It should fix the current CI failures. ACKs for top commit: ajtowns: utACK 2394314 MarcoFalke: lgtm ACK 2394314 jonatack: ACK 2394314 hebasto: ACK 2394314 Tree-SHA512: feb0c2b936a77be45d9c65aa7d738277b2266b5153665fee3b1413045de521195dc7d5efa2fc8b37b22f16e9b8d0ee8de25bfd151a428666122b31f64056557a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a silent conflict between #28123 (which removed all
\"options\") and #27460 (which added a new one).It should fix the current CI failures.