fuzz: Flatten all FUZZ_TARGET macros into one #28065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
fad67d8 to
fae353d
Compare
|
Concept ACK |
dergoegge
reviewed
Jul 11, 2023
sipa
reviewed
Jul 11, 2023
|
Thanks for the comments. Fixed everything. |
fa35b0c to
fa6fa1f
Compare
dergoegge
approved these changes
Jul 13, 2023
fa64a9f to
fa34d1f
Compare
added 2 commits
July 13, 2023 20:37
* This allows to reduce the number of total macros. * Also, adding a new option no longer requires doubling the number of macros in the worst case.
-BEGIN VERIFY SCRIPT-
ren() { sed --regexp-extended -i "s|$1|$2|g" $(git grep -l --extended-regexp "$1"); }
# Replace FUZZ_TARGET_INIT
ren 'FUZZ_TARGET_INIT\((.+), (.+)\)' 'FUZZ_TARGET(\1, .init = \2)'
# Delete unused FUZZ_TARGET_INIT
sed -i -e '37,39d' src/test/fuzz/fuzz.h
-END VERIFY SCRIPT-
fa34d1f to
fa6dfaa
Compare
maflcko
commented
Jul 13, 2023
| { | ||
| const auto it_ins = FuzzTargets().try_emplace(name, std::move(target), std::move(init), hidden); | ||
| const auto it_ins{FuzzTargets().try_emplace(name, FuzzTarget /* temporary can be dropped in C++20 */ {std::move(target), std::move(opts)})}; |
There was a problem hiding this comment.
Suggested change
| const auto it_ins{FuzzTargets().try_emplace(name, FuzzTarget /* temporary can be dropped in C++20 */ {std::move(target), std::move(opts)})}; | |
| const auto it_ins{FuzzTargets().try_emplace(name, std::move(target), std::move(opts))}; |
Haven't tracked down which C++20 LWG paper this was. Let me know if someone finds something.
dergoegge
approved these changes
Jul 17, 2023
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 17, 2023
fa6dfaa scripted-diff: Use new FUZZ_TARGET macro everywhere (MarcoFalke) fa36ad8 fuzz: Accept options in FUZZ_TARGET macro (MarcoFalke) Pull request description: The `FUZZ_TARGET` macros have many issues: * The developer will have to pick the right macro to pass the wanted option. * Adding a new option requires doubling the number of existing macros in the worst case. Fix all issues by using only a single macro. This refactor does not change behavior. ACKs for top commit: dergoegge: ACK fa6dfaa Tree-SHA512: 49a34553867a1734ce89e616b2d7c29b784a67cd8990db6573f0c7b18957636ef0c81d3d0d444a04c12cdc98bc4c4aa7a2ec94e6232dc363620a746e28416444
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
FUZZ_TARGETmacros have many issues:Fix all issues by using only a single macro.
This refactor does not change behavior.