net: remove unused CConnmanTest
#27957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Ayush170-Future
approved these changes
Jun 23, 2023
theStack
approved these changes
Jun 24, 2023
There was a problem hiding this comment.
ACK 9f0d129
I was very surprised that it's even possible to specify a non-existing struct as a friend. Some background on this topic: https://stackoverflow.com/questions/42008500/why-is-a-friend-class-not-verified-for-existence
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 26, 2023
9f0d129 net: remove unused `CConnmanTest` (brunoerg) Pull request description: `CConnmanTest` was removed in fa72fce. ACKs for top commit: theStack: ACK 9f0d129 Tree-SHA512: 9ad974e8db700e6914a3ed5c936bfe0077cb7dcac915f4efccfe14ecf1917a0eafb37ad5ce6903ed81194bd99359ab300dababa3407f6f7b4d888d459782ad58
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CConnmanTestwas removed in fa72fce.