test: (refactor) Use datadir from options in chainstatemanager test #27876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make the test less reliant on details of the test setup -BEGIN VERIFY SCRIPT- sed -i 's/m_args.GetDataDirNet()/chainman.m_options.datadir/g' src/test/validation_chainstatemanager_tests.cpp -END VERIFY SCRIPT-
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
maflcko
approved these changes
Jun 13, 2023
| @@ -382,7 +382,7 @@ struct SnapshotTestSetup : TestChain100Setup { | |||
| m_node.notifications = std::make_unique<KernelNotifications>(); | |||
| const ChainstateManager::Options chainman_opts{ | |||
| .chainparams = ::Params(), | |||
| .datadir = m_args.GetDataDirNet(), | |||
| .datadir = chainman.m_options.datadir, | |||
There was a problem hiding this comment.
review note, this creates a copy and is not a reference, thus memory-safe
|
Concept ACK. |
|
ACK d54819d |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 15, 2023
…instatemanager test d54819d scripted-diff: Use datadir from options in chainstatemanager test (TheCharlatan) Pull request description: This should make the test less reliant on argument state from the test setup. This is a follow-up PR as requested in bitcoin#27576 (comment). ACKs for top commit: achow101: ACK d54819d MarcoFalke: lgtm ACK d54819d kevkevinpal: ACK bitcoin@d54819d ryanofsky: Code review ACK d54819d Tree-SHA512: 939fde2505c5585d993545a3d05d3a00caec40f860c74fa002caebdf4c1b70e774cfb028a8a8f780525f8968844157d2c568d9f2c8dd5ec32b093173d8644c34
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the test less reliant on argument state from the test setup. This is a follow-up PR as requested in #27576 (comment).