-
Notifications
You must be signed in to change notification settings - Fork 37.7k
fuzz: Change LIMIT_TO_MESSAGE_TYPE from a compile-time to a run-time setting #27766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK
fa0a0b8
to
1111c9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 1111c9a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK
Nice. Should help with oss-fuzz disk issues. Related to bitcoin-core/qa-assets#131 |
post-merge ACK 1111c9a |
The
process_message_${msg_type}
fuzz targets have many issues:./process_message_${msg_type}
) is accompanied by a similar input in the general folder (./process_message
) or a in another specific folder. The size seems to be ~3GB for the sum of all folders vs 0.3GB for the general folder.process_messages
fuzz target, and historically always has been? So maybe it can even be removed completely in the future?Fix all issues by turning the compile-time setting into a run-time setting, thus removing the extra executables and fuzz folders. The same approach is also taken by the
rpc
fuzz target.If someone wants to limit their fuzzing to a specific message type, they can still do it. For example,