Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented May 20, 2023

This PR makes the IWYU output in the CI 'tidy' task more useful by avoiding most cases where a comment ends with an ellipsis like that:

#include "primitives/transaction.h"  // for CTxIn, CMutableTransaction, CTra...

@DrahtBot
Copy link
Contributor

DrahtBot commented May 20, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #27710 (ci, iwyu: Update mappings by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 98ea798

Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fanquake fanquake merged commit 9a8318f into bitcoin:master May 22, 2023
@hebasto hebasto deleted the 230520-tidy branch May 22, 2023 08:45
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request May 23, 2023
@bitcoin bitcoin locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants