Skip to content

Conversation

fanquake
Copy link
Member

This always just needs "bumping" (see previous rc type pulls), and the version number is already whichever version of the code you acquired bips.md with.

This always just needs "bumping", and the version number is already
whichever version of the code you acquired bips.md with.
@DrahtBot
Copy link
Contributor

DrahtBot commented May 11, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK MarcoFalke, theStack, hebasto, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Docs label May 11, 2023
@maflcko
Copy link
Member

maflcko commented May 11, 2023

lgtm ACK 308caf3

Copy link
Contributor

@theStack theStack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 308caf3

theStack
theStack approved these changes May 11, 2023
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 308caf3

@achow101
Copy link
Member

ACK 308caf3

Remembering to do this for every release is quite annoying.

@achow101 achow101 merged commit 9d85c03 into bitcoin:master May 11, 2023
@fanquake fanquake deleted the remove_bips_md_version_number branch May 11, 2023 17:46
@luke-jr
Copy link
Member

luke-jr commented Jun 23, 2023

late nit: release-process.md still talks about the "version number on the first line" :/

knst pushed a commit to knst/dash that referenced this pull request Jan 13, 2024
308caf3 doc: remove version number from bips.md (fanquake)

Pull request description:

  This always just needs "bumping" (see previous rc type pulls), and the version number is already whichever version of the code you acquired bips.md with.

ACKs for top commit:
  MarcoFalke:
    lgtm ACK 308caf3
  achow101:
    ACK 308caf3
  theStack:
    ACK 308caf3
  hebasto:
    ACK 308caf3

Tree-SHA512: fcb98e7cdc0c1f8960bfba86be09c2badb36b613060fae394a56e1561c69d28f433434f573c8b1ae1d71ae326277dea2a4841d5c08ad39f8e8848300743146e7
knst pushed a commit to knst/dash that referenced this pull request Jan 15, 2024
308caf3 doc: remove version number from bips.md (fanquake)

Pull request description:

  This always just needs "bumping" (see previous rc type pulls), and the version number is already whichever version of the code you acquired bips.md with.

ACKs for top commit:
  MarcoFalke:
    lgtm ACK 308caf3
  achow101:
    ACK 308caf3
  theStack:
    ACK 308caf3
  hebasto:
    ACK 308caf3

Tree-SHA512: fcb98e7cdc0c1f8960bfba86be09c2badb36b613060fae394a56e1561c69d28f433434f573c8b1ae1d71ae326277dea2a4841d5c08ad39f8e8848300743146e7
knst pushed a commit to knst/dash that referenced this pull request Jan 15, 2024
308caf3 doc: remove version number from bips.md (fanquake)

Pull request description:

  This always just needs "bumping" (see previous rc type pulls), and the version number is already whichever version of the code you acquired bips.md with.

ACKs for top commit:
  MarcoFalke:
    lgtm ACK 308caf3
  achow101:
    ACK 308caf3
  theStack:
    ACK 308caf3
  hebasto:
    ACK 308caf3

Tree-SHA512: fcb98e7cdc0c1f8960bfba86be09c2badb36b613060fae394a56e1561c69d28f433434f573c8b1ae1d71ae326277dea2a4841d5c08ad39f8e8848300743146e7
knst pushed a commit to knst/dash that referenced this pull request Jan 16, 2024
308caf3 doc: remove version number from bips.md (fanquake)

Pull request description:

  This always just needs "bumping" (see previous rc type pulls), and the version number is already whichever version of the code you acquired bips.md with.

ACKs for top commit:
  MarcoFalke:
    lgtm ACK 308caf3
  achow101:
    ACK 308caf3
  theStack:
    ACK 308caf3
  hebasto:
    ACK 308caf3

Tree-SHA512: fcb98e7cdc0c1f8960bfba86be09c2badb36b613060fae394a56e1561c69d28f433434f573c8b1ae1d71ae326277dea2a4841d5c08ad39f8e8848300743146e7
knst pushed a commit to knst/dash that referenced this pull request Jan 17, 2024
308caf3 doc: remove version number from bips.md (fanquake)

Pull request description:

  This always just needs "bumping" (see previous rc type pulls), and the version number is already whichever version of the code you acquired bips.md with.

ACKs for top commit:
  MarcoFalke:
    lgtm ACK 308caf3
  achow101:
    ACK 308caf3
  theStack:
    ACK 308caf3
  hebasto:
    ACK 308caf3

Tree-SHA512: fcb98e7cdc0c1f8960bfba86be09c2badb36b613060fae394a56e1561c69d28f433434f573c8b1ae1d71ae326277dea2a4841d5c08ad39f8e8848300743146e7
knst pushed a commit to knst/dash that referenced this pull request Jan 19, 2024
308caf3 doc: remove version number from bips.md (fanquake)

Pull request description:

  This always just needs "bumping" (see previous rc type pulls), and the version number is already whichever version of the code you acquired bips.md with.

ACKs for top commit:
  MarcoFalke:
    lgtm ACK 308caf3
  achow101:
    ACK 308caf3
  theStack:
    ACK 308caf3
  hebasto:
    ACK 308caf3

Tree-SHA512: fcb98e7cdc0c1f8960bfba86be09c2badb36b613060fae394a56e1561c69d28f433434f573c8b1ae1d71ae326277dea2a4841d5c08ad39f8e8848300743146e7
PastaPastaPasta pushed a commit to knst/dash that referenced this pull request Jan 19, 2024
308caf3 doc: remove version number from bips.md (fanquake)

Pull request description:

  This always just needs "bumping" (see previous rc type pulls), and the version number is already whichever version of the code you acquired bips.md with.

ACKs for top commit:
  MarcoFalke:
    lgtm ACK 308caf3
  achow101:
    ACK 308caf3
  theStack:
    ACK 308caf3
  hebasto:
    ACK 308caf3

Tree-SHA512: fcb98e7cdc0c1f8960bfba86be09c2badb36b613060fae394a56e1561c69d28f433434f573c8b1ae1d71ae326277dea2a4841d5c08ad39f8e8848300743146e7
@bitcoin bitcoin locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants