ci: Remove CI_EXEC bloat #27616
Merged
ci: Remove CI_EXEC bloat #27616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[WARN] The commit is obviously broken and will not run the CI system. In the rare case this is hit in a git bisect, just skip the commit. The goal here was to make it trivial to review with the git option: --color-moved=dimmed-zebra It is required to move everything into one file because "exit 0" will otherwise stop working as intended when the containing bash script is no longer executed with "source ...". If there is desire to split up 06_script_b.sh into logical chunks in the future, it will also be easier after the following commit.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
d6a4f7c to
5cad9e8
Compare
|
concept ACK |
5cad9e8 to
fa01c3c
Compare
|
Concept ACK |
maflcko
commented
May 12, 2023
| bash -c "./configure $BITCOIN_CONFIG_ALL $BITCOIN_CONFIG" || ( (cat config.log) && false) | ||
| make "${MAKEJOBS}" && cd src/qt && ANDROID_HOME=${ANDROID_HOME} ANDROID_NDK_HOME=${ANDROID_NDK_HOME} make apk | ||
| bash -c "${PRINT_CCACHE_STATISTICS}" | ||
| exit 0 |
There was a problem hiding this comment.
Moving the exit 0 may also fix a bug where the CI Pod for ARM64 Android APK [jammy] is left alive even if the test passed.
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 15, 2023
fanquake
added a commit
to bitcoin-core/gui
that referenced
this pull request
May 16, 2023
5d49d98 ci: Fix "Number of CPUs" output (Hennadii Stepanov) Pull request description: This PR is a follow-up to bitcoin/bitcoin#27616: - on [master](https://api.cirrus-ci.com/v1/task/5809898840129536/logs/ci.log): ``` Number of CPUs \(nproc\): $(nproc) ``` - this [PR](https://api.cirrus-ci.com/v1/task/6495994095861760/logs/ci.log): ``` Number of CPUs (nproc): 32 ``` ACKs for top commit: MarcoFalke: lgtm ACK 5d49d98 Tree-SHA512: d97ee3587dbadb604a381aa9990b58d75441307fc98e7ae674436f8318200c8faef7171348655cdcc3ed360c8ca22eacf063cb430b826a40cb0952a436c511f3
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 17, 2023
5d49d98 ci: Fix "Number of CPUs" output (Hennadii Stepanov) Pull request description: This PR is a follow-up to bitcoin#27616: - on [master](https://api.cirrus-ci.com/v1/task/5809898840129536/logs/ci.log): ``` Number of CPUs \(nproc\): $(nproc) ``` - this [PR](https://api.cirrus-ci.com/v1/task/6495994095861760/logs/ci.log): ``` Number of CPUs (nproc): 32 ``` ACKs for top commit: MarcoFalke: lgtm ACK 5d49d98 Tree-SHA512: d97ee3587dbadb604a381aa9990b58d75441307fc98e7ae674436f8318200c8faef7171348655cdcc3ed360c8ca22eacf063cb430b826a40cb0952a436c511f3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI_EXEChas many issues:bash -c "$*", meaning that the full command will be treated as a single string, ignoring tokens.Fix all issues by removing it almost completely.