msvc: Rename libbitcoinconsensus to libbitcoin_consensus and other adjustments
#27615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This build artifact is not a user-exposed shared library (DLL) but a convenience static library. See: https://github.com/bitcoin/bitcoin/blob/master/doc/design/libraries.md -BEGIN VERIFY SCRIPT- sed -i 's/libbitcoinconsensus/libbitcoin_consensus/g' $(git grep -l "libbitcoinconsensus" -- build_msvc) git mv build_msvc/libbitcoinconsensus build_msvc/libbitcoin_consensus git mv build_msvc/libbitcoin_consensus/libbitcoinconsensus.vcxproj build_msvc/libbitcoin_consensus/libbitcoin_consensus.vcxproj -END VERIFY SCRIPT-
See `libbitcoin_consensus_a_SOURCES` in the `src/Makefile.am`.
The `HAVE_CONSENSUS_LIB` symbol is supposed to be defined when a user-exposed shared library (DLL) is built which is not the case here.
|
Other than renaming things, what does this acheive? Unclear it's worth doing if everything done here is going to be thrown away when we switch to CMake. |
|
As the rename makes the naming more correct seems reasonable to me. ACK a94d75f. |
sipsorcery
approved these changes
May 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Autotools-based build system operates with two build artifacts:
LIBBITCOIN_CONSENSUSwhich is defined as "Stable, backwards-compatible consensus functionality used by libbitcoin_node and libbitcoin_wallet"LIBBITCOINCONSENSUSwhich is defined as "Shared library build of static libbitcoin_consensus library"The way how the
libbitcoinconsensus.vcxprojproject is used in the MSVC build system obviously shows that it is the former use case.This PR makes the related adjustments to the MSVC build system.