bugfix: Properly handle "unknown" Address Type #27473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
Given that we shouldn't ever accept |
Fixes bitcoin#27472 Signed-off-by: Pttn <28868425+Pttn@users.noreply.github.com>
dfec384 to
0d6383f
Compare
|
Makes sense, commit updated. |
|
Looks like this may have been introduced in f5649db, so not a regression in 25.x, but 24.x? |
|
ACK 0d6383f |
|
lgtm ACK 0d6383f In a follow-up, might be good to at least add a regression test, or even extend the fuzz tests, see #27472 (comment) |
furszy
approved these changes
Apr 17, 2023
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Apr 17, 2023
Fixes bitcoin#27472 Signed-off-by: Pttn <28868425+Pttn@users.noreply.github.com> Github-Pull: bitcoin#27473 Rebased-From: 0d6383f
|
Backported to 24.x in #27474. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 17, 2023
0d6383f Don't return OutputType::UNKNOWN in ParseOutputType (Pttn) Pull request description: Fixes bitcoin#27472 by also handling at the relevant places the case where ParseOutputType returns `OutputType::UNKNOWN`, and not just when it returns `std::nullopt`. ACKs for top commit: achow101: ACK 0d6383f MarcoFalke: lgtm ACK 0d6383f furszy: ACK bitcoin@0d6383f Tree-SHA512: 776793027b926283d3162e69fb9c8883c814b19bcce4574ccdf8e3140a1ec4ebc4aa8ccd1abae7ef3571f942d2e6c35305fd1244259540d90605106e01afc34c
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Apr 18, 2023
dc711fb doc: update 24.1 release notes (fanquake) fc8c1a8 doc: fix/improve warning helps in {create,load,unload,restore}wallet (Jon Atack) 3a26b19 bugfix: rest: avoid segfault for invalid URI (pablomartin4btc) c40b1da depends: fix compiling bdb with clang-16 on aarch64 (fanquake) 0bac52d Don't return OutputType::UNKNOWN in ParseOutputType (Pttn) Pull request description: Backports: * bitcoin#27279 (only f73782a) * bitcoin#27462 * bitcoin#27468 * bitcoin#27473 ACKs for top commit: stickies-v: ACK dc711fb hebasto: re-ACK dc711fb jonatack: ACK dc711fb Tree-SHA512: 72c673be82689e3c3a1c2564a1fdd6afe0b357b7aa8bec9524fe6999804fbccf310da0b074e647af14b753e5e695024e268fe4f69aa58747f541f7f429ebede6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27472 by also handling at the relevant places the case where ParseOutputType returns
OutputType::UNKNOWN, and not just when it returnsstd::nullopt.