doc: Add example of how to mix private and public keys in descriptors #27414
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
ACK 4210771 |
| @@ -243,7 +243,18 @@ Often it is useful to communicate a description of scripts along with the | |||
| necessary private keys. For this reason, anywhere a public key or xpub is | |||
| supported, a private key in WIF format or xprv may be provided instead. | |||
| This is useful when private keys are necessary for hardened derivation | |||
| steps, or for dumping wallet descriptors including private key material. | |||
| steps, signing transactions, or for dumping wallet descriptors | |||
There was a problem hiding this comment.
| steps, signing transactions, or for dumping wallet descriptors | |
| steps, for signing transactions, or for dumping wallet descriptors |
(alternatively, s/for dumping/dumping/
|
Concept ACK |
|
Concept ACK Please squash your commits |
|
There hasn't been much activity lately. What is the status here? Finding reviewers may take time. However, if the patch is no longer relevant, please close this pull request. If the author lost interest or time to work on this, please close it and mark it 'Up for grabs' with the label, so that it can be picked up in the future. |
|
I think this can be closed "Up for grabs"? Does someone want to pick it up? |
|
For reference, the docs on how to squash commits: https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits |
I'd like to pick this up. |
|
Superseded by #28373 |
…escriptors 24b67fa doc: Add example of mixing private and public keys in descriptors (Anton A) Pull request description: closes: #27414 ACKs for top commit: achow101: ACK 24b67fa alfonsoromanz: Re ACK 24b67fa Tree-SHA512: 8c063f23199ac0ff35909f786a5b0de1b4a9b15d1e93bdcdac10cb4bd2002c12e99b6fb1c2e56d16971e7622b67d910b79088429df92c48279be2d7797049911
…ys in descriptors 24b67fa doc: Add example of mixing private and public keys in descriptors (Anton A) Pull request description: closes: bitcoin#27414 ACKs for top commit: achow101: ACK 24b67fa alfonsoromanz: Re ACK 24b67fa Tree-SHA512: 8c063f23199ac0ff35909f786a5b0de1b4a9b15d1e93bdcdac10cb4bd2002c12e99b6fb1c2e56d16971e7622b67d910b79088429df92c48279be2d7797049911
…ys in descriptors 24b67fa doc: Add example of mixing private and public keys in descriptors (Anton A) Pull request description: closes: bitcoin#27414 ACKs for top commit: achow101: ACK 24b67fa alfonsoromanz: Re ACK 24b67fa Tree-SHA512: 8c063f23199ac0ff35909f786a5b0de1b4a9b15d1e93bdcdac10cb4bd2002c12e99b6fb1c2e56d16971e7622b67d910b79088429df92c48279be2d7797049911
It took me quite a while to understand how to use both xpriv and public keys in a single descriptor. The trick was to use xprv key + derivation path. Also, it was not obvious that Bitcoin Core would figure it out and sign a multisig transaction if the xpriv is present in the descriptor. As a newbie to Bitcoin Core, I had to consult stackexchange to understand that.
Adding an example would make it easier to "gotcha" for the reader.