Skip to content

ci: Use clang-15 in "tidy" task #27311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2023
Merged

ci: Use clang-15 in "tidy" task #27311

merged 1 commit into from
Mar 23, 2023

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Mar 23, 2023

Newer tools usually are better in terms of features and bug fixes.

Requested in #26642 (comment).

Split from #26766.

@DrahtBot
Copy link
Contributor

DrahtBot commented Mar 23, 2023 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK MarcoFalke

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Mar 23, 2023
@hebasto hebasto mentioned this pull request Mar 23, 2023
Merged
@dergoegge
Copy link
Member

clang-16 was released recently, any reason not to switch to that directly while we're at it?

@maflcko
Copy link
Member

maflcko commented Mar 23, 2023

lgtm ACK 8fe27fb

clang-16 was released recently, any reason not to switch to that directly while we're at it?

Sounds good to do this, once iwyu has a release with clang-16 support. Maybe in a follow-up?

@hebasto
Copy link
Member Author

hebasto commented Mar 23, 2023

clang-16 was released recently, any reason not to switch to that directly while we're at it?

Well, it is available as a package in Ubuntu Lunar, but I'm not sure if we want to bring a short-lived distro into our CI.

@fanquake fanquake merged commit f380bb9 into bitcoin:master Mar 23, 2023
@hebasto hebasto deleted the 230322-clang15 branch March 23, 2023 13:30
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 23, 2023
@fanquake
Merge bitcoin#27311: ci: Use clang-15 in "tidy" task
4a57f99
@fanquake fanquake mentioned this pull request Apr 3, 2023
Merged
fanquake added a commit to bitcoin-core/gui that referenced this pull request Apr 5, 2023
@fanquake
Merge bitcoin/bitcoin#27404: ci: use clang-16 in tidy task
0459548 
a56c965 ci: use clang-16 in tidy task (fanquake)

Pull request description:

  Follow up to bitcoin/bitcoin#27311 (comment), as IWYU now has a [clang_16 branch](https://github.com/include-what-you-use/include-what-you-use/tree/clang_16).

  This also removes some workarounds for (now fixed) clang-tidy issues, and simplifies the IWYU install steps.

ACKs for top commit:
  MarcoFalke:
    lgtm ACK a56c965
  josibake:
    ACK bitcoin/bitcoin@a56c965
  hebasto:
    ACK a56c965

Tree-SHA512: 5bbec6cc196c3305302895c77986f3695fc6f4024363ee57503654d54e0ebf108719a7a1d7908817f84115dcaa13377493eb764b00bdf574f1290c73251426fa
@bitcoin bitcoin locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hebasto @DrahtBot @dergoegge @maflcko @fanquake