refactor: rpc: Remove unnecessary uses of ParseNonRFCJSONValue() and rename it #27256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
0f22456 to
f43b98b
Compare
maflcko
reviewed
Mar 16, 2023
f43b98b to
104e482
Compare
maflcko
reviewed
Mar 16, 2023
104e482 to
860e707
Compare
860e707 to
79ee14b
Compare
Preparation to deprecate ParseNonRFCJSONValue() but keep test coverage on the underlying UniValue::read() unaffected. The test coverage on AmountFromValue is no longer included, since that is already tested in the rpc_parse_monetary_values test case. Fuzzing coverage on ParseNonRFCJSONValue() was duplicated between string.cpp and parse_univalue.cpp, only the one in parse_univalue.cpp is kept.
As per bitcoin#26506 (review), this function is no longer necessary and we can use UniValue::read() directly. To avoid code duplication, we keep the function to throw on invalid input data but rename it to Parse() and remove it from the header.
79ee14b to
cfbc8a6
Compare
|
Force pushed to add test a test case on Addressed all of @ryanofsky's comments - thank you for the review! |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 2, 2023
fanquake
added a commit
that referenced
this pull request
Apr 17, 2024
fa4c696 test: Fix failing univalue float test (MarcoFalke) Pull request description: Currently the test may fail for some compilers, because `1e-8` may not be possible to represent exactly/consistently. ``` $ ./src/univalue/test/object object: univalue/test/object.cpp:424: void univalue_readwrite(): Assertion `v.read("0.00000000000000000000000000000000000001e+30 ") && v.get_real() == 1e-8' failed. Aborted (core dumped) ``` Fixes #27256 (comment) ACKs for top commit: laanwj: ACK fa4c696 stickies-v: ACK fa4c696 , thanks for fixing! Tree-SHA512: dea4f4f843381d5e8ffaa812b2290a11e081b29f8777d041751c4aa9942e60f1f8d2d1a652d9a52b41dec470a490c9fe26ca9bc762dd593c3521b328a8af2826
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #26612 (comment). As per #26506 (review),
ParseNonRFCJSONValue()is no longer necessary and we can useUniValue::read()directly:The implementation of
ParseNonRFCJSONValue()was already simplified in #26612 and test coverage updated to ensure behaviour didn't change.To avoid code duplication, we keep the function to throw on invalid input data but rename it to
Parse()and remove it from the header.The existing test coverage we had on
ParseNonRFCJSONValue()is moved over toUniValue::read().