A few follow-ups to #17487 (coins write without cache drop) #26999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
Github code review ACK Thanks for doing these! I'll clone and test locally soon. |
34d63e4 to
2e16054
Compare
|
ACK 2e16054 |
|
utACK 2e16054
|
jamesob
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
ACK 2e16054 (jamesob/ackr/26999.1.sipa.a_few_follow_ups_to_1748)
Built, reviewed diff, ran tests locally.
Show signature data
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
ACK 2e16054a66b0576ec93d4032d6b74f0930a44fef ([`jamesob/ackr/26999.1.sipa.a_few_follow_ups_to_1748`](https://github.com/jamesob/bitcoin/tree/ackr/26999.1.sipa.a_few_follow_ups_to_1748))
Built, reviewed diff, ran tests locally.
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEGNRVI1NPYuZCSIrGepNdrbLETwUFAmPYIBkACgkQepNdrbLE
TwVNIxAAiyTgokcHrKdzbD4NbrweHcjs8t0jXl4iSLQ6vMHHk/DU/BPMLbJaw1V8
bXNueFYw8Z6ptbS5yqd9BdETdMTqvnCUW+zV5p6pdaOxBCNFjKyz5obQBksv/RZc
u+0gJfhwHJm5Pm0KUCzGjdttC1S8gsD5thE6bo4VxGBd8KmMCCrN78ejzd+G/+vx
Zfhw3z6feivkg8QjDJRejRCGkFdSqmlSn5YspEOsVd5Au9e51KywLFTdV9ESnLJ8
By7JUiXjN4b5Sk9FyAPx1Lb2MDt1CE30/AcDy2oEWNtePEBXrkhYK08c5dEl1xdx
3ZOhjeiLcLWaucGOTF8OwoYUOvtFeZUnvtqhtHYKIe5qKV9TytWr5RGn0K4kwfq8
jiz766M2kHePRHkYvYpkA38PAtjpvJD0neOg78ke9ekPpFNAERTipbO0YPP00qhw
bUYJ88cIEZqEbLTp6oM6Wgn8Sp+Z/PCoTe5HwcWWh4UhQJoC3dvpGpzxdBStVnhD
pLcil5eaCZB4xZH2hWgUrRqNPGVgvh8vW48S1l3dj15PRK/hETgnmDE67YZ/7gUI
as4NxkMXU6kmQ9c9wTZ42Qe8nhmu3dUszMppFmEOMsBXrE8uge6lo+cRVidzoU5c
W6LHVtZRtMLWI4ydJPXDlNCCBDyFtuIh04qTQ515WobVnCeRuHs=
=RV3M
-----END PGP SIGNATURE-----
Show platform data
Tested on Linux-6.1.6-arch1-3-x86_64-with-glibc2.36
Configured with ./configure LDFLAGS=-L/home/james/src/bitcoin2/db4/lib/ CPPFLAGS=-I/home/james/src/bitcoin2/db4/include/ 'CXXFLAGS=-fPIE -pipe -O2 -g -Wthread-safety-analysis -Wall -Werror=sign-compare -Wsign-compare -Werror=thread-safety-analysis' --enable-wallet --enable-debug --with-daemon --enable-natpmp-default
Compiled with /usr/bin/ccache /usr/bin/clang++ -std=c++17 -mavx -mavx2 -mpclmul -fPIE -pipe -O2 -g -Wthread-safety-analysis -Wall -Werror=sign-compare -Wsign-compare -Werror=thread-safety-analysis -O0 -g3 -ftrapv -fdebug-prefix-map=$(abs_top_srcdir)=. -Wstack-protector -fstack-protector-all -fcf-protection=full -fstack-clash-protection -msse4.1 -msse4.2 -msse4 -msha i
Compiler version: clang version 15.0.7
|
ACK 2e16054 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 30, 2023
…ithout cache drop) 2e16054 Add assertions that BatchWrite(erase=true) erases (Pieter Wuille) 941feb6 Avoid unclear {it = ++it;} (Pieter Wuille) 98db35c Follow coding style for named arguments (Pieter Wuille) bb00357 Make test/fuzz/coins_view exercise CCoinsViewCache::Sync() (Pieter Wuille) Pull request description: This addresses a few nits left open in bitcoin#17487. ACKs for top commit: jonatack: ACK 2e16054 Sjors: utACK 2e16054 achow101: ACK 2e16054 jamesob: ACK 2e16054 ([`jamesob/ackr/26999.1.sipa.a_few_follow_ups_to_1748`](https://github.com/jamesob/bitcoin/tree/ackr/26999.1.sipa.a_few_follow_ups_to_1748)) Tree-SHA512: 5e64807b850fa12ce858e87470420555ad081f2f63d53649d9904034ed5311592005eb979a8a4df2b70ecb56cf022db9750cd6999e5480bc8226184d4be22ce4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a few nits left open in #17487.