Skip to content

Conversation

instagibbs
Copy link
Member

Quick follow-up to #25877

@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 20, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK sipa

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@fanquake fanquake requested review from sipa and ajtowns January 20, 2023 14:54
@fanquake fanquake changed the title Add unit test for ComputeTapleafHash test: Add unit test for ComputeTapleafHash Jan 20, 2023
@DrahtBot DrahtBot added the Tests label Jan 20, 2023
Copy link
Member

@sipa sipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f34ada8

I verified the hash values against the test framework implementation.

@maflcko maflcko merged commit c0b6c40 into bitcoin:master Jan 20, 2023
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 20, 2023
f34ada8 Add unit test for ComputeTapleafHash (Greg Sanders)

Pull request description:

  Quick follow-up to bitcoin#25877

ACKs for top commit:
  sipa:
    ACK f34ada8

Tree-SHA512: ebec658c9b33859874a3e5d13ca0a00a2484233f00f2da09c7d3fb47ed7f56fc6d476ddd0473fe1396a514dffd6ea6a200f26c6dbca45bac2473e729ffef04c2
@ajtowns ajtowns mentioned this pull request Jan 21, 2023
@bitcoin bitcoin locked and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants