test: skip sqlite3 tests if it isn't available #26882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
maflcko
reviewed
Jan 12, 2023
Fixes bitcoin#26819. Related too bitcoin#26873.
2deb6ac to
eea73d4
Compare
brunoerg
approved these changes
Jan 13, 2023
There was a problem hiding this comment.
ACK eea73d4
Removed sqlite3 and ran the test:
2023-01-13T12:48:05.992000Z TestFramework (WARNING): Test Skipped: sqlite3 module not available.
2023-01-13T12:48:06.047000Z TestFramework (INFO): Stopping nodes
2023-01-13T12:48:06.047000Z TestFramework (INFO): Cleaning up /var/folders/7j/m0yjzmhj4ys9jgl353v2mqph0000gn/T/bitcoin_func_test_bb6sbr9w on exit
2023-01-13T12:48:06.047000Z TestFramework (INFO): Test skippedWith sqlite3:
2023-01-13T12:47:35.815000Z TestFramework (INFO): Initializing test directory /var/folders/7j/m0yjzmhj4ys9jgl353v2mqph0000gn/T/bitcoin_func_test_lfqi98qf
2023-01-13T12:47:36.295000Z TestFramework (INFO): Making a descriptor wallet
2023-01-13T12:47:36.335000Z TestFramework (INFO): Checking wallet info
2023-01-13T12:47:36.335000Z TestFramework (INFO): Test that getnewaddress and getrawchangeaddress work
2023-01-13T12:47:36.420000Z TestFramework (INFO): Test sending and receiving
2023-01-13T12:47:36.422000Z TestFramework (INFO): Test disabled RPCs
2023-01-13T12:47:36.427000Z TestFramework (INFO): Test encryption
2023-01-13T12:47:36.886000Z TestFramework (INFO): Test that getnewaddress still works after keypool is exhausted in an encrypted wallet
2023-01-13T12:47:37.107000Z TestFramework (INFO): Test that unlock is needed when deriving only hardened keys in an encrypted wallet
2023-01-13T12:47:37.286000Z TestFramework (INFO): Test born encrypted wallets
2023-01-13T12:47:37.699000Z TestFramework (INFO): Test blank descriptor wallets
2023-01-13T12:47:37.701000Z TestFramework (INFO): Test descriptor wallet with disabled private keys
2023-01-13T12:47:37.703000Z TestFramework (INFO): Test descriptor exports
2023-01-13T12:47:37.740000Z TestFramework (INFO): Testing descriptor address type for legacy external
2023-01-13T12:47:37.741000Z TestFramework (INFO): Testing the same descriptor is returned for address type legacy external
2023-01-13T12:47:37.749000Z TestFramework (INFO): Testing import of exported legacy descriptor
2023-01-13T12:47:37.764000Z TestFramework (INFO): Testing descriptor address type for p2sh-segwit external
2023-01-13T12:47:37.765000Z TestFramework (INFO): Testing the same descriptor is returned for address type p2sh-segwit external
2023-01-13T12:47:37.774000Z TestFramework (INFO): Testing import of exported p2sh-segwit descriptor
2023-01-13T12:47:37.789000Z TestFramework (INFO): Testing descriptor address type for bech32 external
2023-01-13T12:47:37.790000Z TestFramework (INFO): Testing the same descriptor is returned for address type bech32 external
2023-01-13T12:47:37.798000Z TestFramework (INFO): Testing import of exported bech32 descriptor
2023-01-13T12:47:37.814000Z TestFramework (INFO): Testing descriptor address type for bech32m external
2023-01-13T12:47:37.814000Z TestFramework (INFO): Testing the same descriptor is returned for address type bech32m external
2023-01-13T12:47:37.824000Z TestFramework (INFO): Testing import of exported bech32m descriptor
2023-01-13T12:47:37.844000Z TestFramework (INFO): Testing descriptor address type for legacy internal
2023-01-13T12:47:37.845000Z TestFramework (INFO): Testing the same descriptor is returned for address type legacy internal
2023-01-13T12:47:37.852000Z TestFramework (INFO): Testing import of exported legacy descriptor
2023-01-13T12:47:37.867000Z TestFramework (INFO): Testing descriptor address type for p2sh-segwit internal
2023-01-13T12:47:37.868000Z TestFramework (INFO): Testing the same descriptor is returned for address type p2sh-segwit internal
2023-01-13T12:47:37.876000Z TestFramework (INFO): Testing import of exported p2sh-segwit descriptor
2023-01-13T12:47:37.891000Z TestFramework (INFO): Testing descriptor address type for bech32 internal
2023-01-13T12:47:37.892000Z TestFramework (INFO): Testing the same descriptor is returned for address type bech32 internal
2023-01-13T12:47:37.899000Z TestFramework (INFO): Testing import of exported bech32 descriptor
2023-01-13T12:47:37.914000Z TestFramework (INFO): Testing descriptor address type for bech32m internal
2023-01-13T12:47:37.915000Z TestFramework (INFO): Testing the same descriptor is returned for address type bech32m internal
2023-01-13T12:47:37.924000Z TestFramework (INFO): Testing import of exported bech32m descriptor
2023-01-13T12:47:37.944000Z TestFramework (INFO): Test that loading descriptor wallet containing legacy key types throws error
2023-01-13T12:47:38.041000Z TestFramework (INFO): Stopping nodes
2023-01-13T12:47:38.152000Z TestFramework (INFO): Cleaning up /var/folders/7j/m0yjzmhj4ys9jgl353v2mqph0000gn/T/bitcoin_func_test_lfqi98qf on exit
2023-01-13T12:47:38.152000Z TestFramework (INFO): Tests successful
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26819. Related too #26873, which adds the missing documentation.