test: Fix intermittent timeout in p2p_permissions.py #26854
Conversation
33dc224 to
fa3a90d
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
fa3a90d to
fa1bf4e
Compare
|
Thanks. Fixed by replacing |
|
Is this also a fix for the mempool timeouts in #26440? |
|
Seems likely, but not sure if this is possible to tell without having Cirrus CI upload the full datadir + test log of the failure |
There was a problem hiding this comment.
ACK fa1bf4e
This makes the test code dependent on their being a ping right after connection setup (which is the case today because m_ping_start=0us initially, but one could imagine other ways of initialization.
Another possibility might be to expose fSuccessfullyConnected via RPC (e.g. in getpeerinfo) and use that, but I'm not sure if that is better if that field is not really interesting to user and just used by tests.
In the unlikely case that this is changed, it should be possible to just call the |
There was a problem hiding this comment.
ACK fa1bf4e
I verified I could reproduce the failure on master with rr but not on this branch.
The sync is based on
bytesrecv_per_msg["verack"]. However, the bytes are counted before processing the message, so they are not sufficient to ensure the connection is fully up.