Skip to content

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Jan 5, 2023

These headers are already included in a default set which are checked early during configure.

We already use at least sys/types.h and unistd.h unconditionally in configure.

These headers are already included in a default set which are checked
early during configure.

We already use at least sys/types.h and unistd.h unconditionally in
configure.
@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 5, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Copy link
Contributor

@TheCharlatan TheCharlatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK 94d0c41

These are e.g. in ac_includes_default.

@fanquake fanquake merged commit 535adce into bitcoin:master Jan 12, 2023
@fanquake fanquake deleted the remove_already_tested_headers branch January 12, 2023 09:42
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 12, 2023
@bitcoin bitcoin locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants