Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Dec 29, 2022

This PR reverts cc7335e from #25528 partially.

C++20 has introduced some new headers, and it is premature to consider them when using the IWYU tool.

Required for #26763 and #26766.

Related discussions:

This change reverts cc7335e partially.

C++20 has introduced some new headers, and it is premature to consider
them when using the IWYU tool.
@hebasto hebasto added the Tests label Dec 29, 2022
@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 29, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK MarcoFalke

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@hebasto
Copy link
Member Author

hebasto commented Dec 29, 2022

Friendly ping @0xB10C @MarcoFalke :)

@maflcko
Copy link
Member

maflcko commented Dec 29, 2022

review only ACK afc6052

Not sure why this was moved, but if CI passes now, this should be fine.

@maflcko
Copy link
Member

maflcko commented Dec 29, 2022

Ah, this was a leftover from a previous iteration that used ./depends, see commit commit 8b1eac9: --enable-c++20 does not work with ./depends out of the box

@maflcko maflcko merged commit 65de8ee into bitcoin:master Dec 29, 2022
@hebasto hebasto deleted the 221229-c++20 branch December 29, 2022 20:09
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 30, 2022
@bitcoin bitcoin deleted a comment Dec 31, 2022
@bitcoin bitcoin locked and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants