Skip to content

test: add coverage for unparsable -maxuploadtarget #26714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2023
Merged

test: add coverage for unparsable -maxuploadtarget #26714

merged 1 commit into from
Feb 16, 2023

Conversation

brunoerg
Copy link
Contributor

This PR adds test coverage for the following error:

bitcoin/src/init.cpp

Lines 1096 to 1099 in 7386da7

auto opt_max_upload = ParseByteUnits(args.GetArg("-maxuploadtarget", DEFAULT_MAX_UPLOAD_TARGET), ByteUnit::M);
if (!opt_max_upload) {
return InitError(strprintf(_("Unable to parse -maxuploadtarget: '%s'"), args.GetArg("-maxuploadtarget", "")));
}

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@DrahtBot DrahtBot added the Tests label Dec 16, 2022
@brunoerg brunoerg marked this pull request as draft December 16, 2022 17:53
@brunoerg brunoerg force-pushed the 2022-12-maxuploadtarget-parse-test branch from a204ada to 7a83aa0 Compare December 16, 2022 17:57
@brunoerg brunoerg marked this pull request as ready for review December 16, 2022 18:56
fanquake
fanquake approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@fanquake fanquake requested a review from maflcko February 16, 2023 09:50
@maflcko maflcko merged commit 437dfe1 into bitcoin:master Feb 16, 2023
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 16, 2023
@bitcoin-core-merge-script
Merge bitcoin#26714: test: add coverage for unparsable `-maxuploadtar…
e459cb6 
…get`

7a83aa0 test: add coverage for unparsable `-maxuploadtarget` (brunoerg)

Pull request description:

  This PR adds test coverage for the following error:
  https://github.com/bitcoin/bitcoin/blob/7386da7a0b08cd2df8ba88dae1fab9d36424b15c/src/init.cpp#L1096-L1099

Top commit has no ACKs.

Tree-SHA512: c115b2b4d2d0eb2316bf9fafd7e0046aa18c9650062779b3a82d6145d188765bff5317f4ca5f79607732fde6d83e1f67756ac20a12c98d060ee68d8acc20c76e
@bitcoin bitcoin locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fanquake fanquake fanquake approved these changes

@maflcko maflcko Awaiting requested review from maflcko

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brunoerg @DrahtBot @fanquake @maflcko