Skip to content

Conversation

dergoegge
Copy link
Member

The process_message(s) targets can't exercise the Erlay logic at the moment as the config setting is off by default and not switched on in the fuzz targets.

This PR enables the -txreconciliation setting in both targets.

@DrahtBot
Copy link
Contributor

DrahtBot commented Dec 12, 2022

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fanquake
Concept ACK glozow, naumenkogs

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@DrahtBot DrahtBot added the Tests label Dec 12, 2022
@glozow glozow requested a review from naumenkogs December 13, 2022 11:27
@glozow
Copy link
Member

glozow commented Dec 13, 2022

Concept ACK based on description

@dergoegge
Copy link
Member Author

I think the addition in process_messages might be not doing much right now, as the version handshake is hard coded (without sendtxrcncl) but the next Erlay PR is adding more messages so might as well flip the option on here.

@naumenkogs
Copy link
Member

Concept ACK

Copy link
Member

@fanquake fanquake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 58c2bbd

@fanquake
Copy link
Member

Seems ok todo @MarcoFalke?

@maflcko maflcko merged commit 05e3468 into bitcoin:master Jan 19, 2023
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jan 19, 2023
… targets

58c2bbd [fuzz] Enable erlay in process_message(s) targets (dergoegge)

Pull request description:

  The process_message(s) targets can't exercise the Erlay logic at the moment as the config setting is off by default and not switched on in the fuzz targets.

  This PR enables the `-txreconciliation` setting in both targets.

ACKs for top commit:
  fanquake:
    ACK 58c2bbd

Tree-SHA512: a2754fd04549bdcac94d8225244c5c83fe4c26114c0c2fdf316257480625e05e4e6b1b791974e1f1021451d3f81cb59a109261fb73178ad03911f0a3db963077
@bitcoin bitcoin locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants