util: Include full version id in bug reports #26645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
For example: |
|
utACK fa825bd |
|
Concept ACK. |
theStack
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
ACK fa825bd
Output diff of the trigger_internal_bug-test between master and PR, once without and once with local changes (files have been created with e.g. ./src/bitcoin-cli -named echo 'arg9=trigger_internal_bug' 2> /tmp/master):
diff --git a/tmp/master b/tmp/pr
index aa5ae158a..a81a965a8 100644
--- a/tmp/master
+++ b/tmp/pr
@@ -2,5 +2,6 @@ error code: -1
error message:
Internal bug detected: "request.params[9].get_str() != "trigger_internal_bug""
rpc/node.cpp:315 (operator())
+Bitcoin Core v24.99.0-fa825bd227b9
Please report this issue here: https://github.com/bitcoin/bitcoin/issuesdiff --git a/tmp/master b/tmp/pr_dirty
index aa5ae158a..60598c2e6 100644
--- a/tmp/master
+++ b/tmp/pr_dirty
@@ -2,5 +2,6 @@ error code: -1
error message:
Internal bug detected: "request.params[9].get_str() != "trigger_internal_bug""
rpc/node.cpp:315 (operator())
+Bitcoin Core v24.99.0-fa825bd227b9-dirty
Please report this issue here: https://github.com/bitcoin/bitcoin/issues|
Concept ACK |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 8, 2022
fa825bd util: Include full version id in bug reports (MarcoFalke) Pull request description: This will show the unique id of the full source code when the bug occurred, which can help debugging ACKs for top commit: 1440000bytes: utACK bitcoin@fa825bd theStack: ACK fa825bd john-moffett: ACK fa825bd Tree-SHA512: a7a775718f5f9796b5cffafbb3ace8adb5c163414ec584a57143157fc9dfb86f799e3b9c8365fcb831ee1e9eafc59d699d1653d772c68392de421b3de74dcd61
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Dec 10, 2022
This change is required to make the following commits compatible with the recent bitcoin#26645.
Closed
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Dec 12, 2022
After bitcoin#26645, this change is required to be able to `#include clientversion.h` in the `libbitcoinconsensus` code without dependency on `util/translation.h`.
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Dec 12, 2022
After bitcoin#26645, this change is required to be able to `#include clientversion.h` in the `libbitcoinconsensus` code without dependency on `util/translation.h`.
DashCoreAutoGuix
pushed a commit
to DashCoreAutoGuix/dash
that referenced
this pull request
Jul 9, 2025
- Modified format_internal_error macro to include PACKAGE_NAME and FormatFullVersion() - Added clientversion.h include to util/check.h - Reverted util/check.cpp to original state (no changes needed) The previous implementation incorrectly added entire functions to the .cpp file when the change should only modify the existing macro in the header file to match Bitcoin's functionality while preserving Dash's macro-based structure. Original commit: fa825bd
PastaPastaPasta
added a commit
to DashCoreAutoGuix/dash
that referenced
this pull request
Jul 9, 2025
* Fix bitcoin#26645: Include full version id in bug reports - Modified format_internal_error macro to include PACKAGE_NAME and FormatFullVersion() - Added clientversion.h include to util/check.h - Reverted util/check.cpp to original state (no changes needed) The previous implementation incorrectly added entire functions to the .cpp file when the change should only modify the existing macro in the header file to match Bitcoin's functionality while preserving Dash's macro-based structure. Original commit: fa825bd * Remove unrelated change in src/util/check.cpp The change in src/util/check.cpp was unrelated to the Bitcoin commit. Bitcoin's commit modifies the StrFormatInternalBug function, but Dash uses a macro-based approach in the header file instead. The only required change is the format_internal_error macro in src/util/check.h which correctly includes PACKAGE_NAME and FormatFullVersion(). 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude Code <claude@anthropic.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
PastaPastaPasta
added a commit
to DashCoreAutoGuix/dash
that referenced
this pull request
Jul 10, 2025
* Fix bitcoin#26645: Include full version id in bug reports - Modified format_internal_error macro to include PACKAGE_NAME and FormatFullVersion() - Added clientversion.h include to util/check.h - Reverted util/check.cpp to original state (no changes needed) The previous implementation incorrectly added entire functions to the .cpp file when the change should only modify the existing macro in the header file to match Bitcoin's functionality while preserving Dash's macro-based structure. Original commit: fa825bd * Remove unrelated change in src/util/check.cpp The change in src/util/check.cpp was unrelated to the Bitcoin commit. Bitcoin's commit modifies the StrFormatInternalBug function, but Dash uses a macro-based approach in the header file instead. The only required change is the format_internal_error macro in src/util/check.h which correctly includes PACKAGE_NAME and FormatFullVersion(). 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude Code <claude@anthropic.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
PastaPastaPasta
added a commit
to DashCoreAutoGuix/dash
that referenced
this pull request
Jul 15, 2025
* Fix bitcoin#26645: Include full version id in bug reports - Modified format_internal_error macro to include PACKAGE_NAME and FormatFullVersion() - Added clientversion.h include to util/check.h - Reverted util/check.cpp to original state (no changes needed) The previous implementation incorrectly added entire functions to the .cpp file when the change should only modify the existing macro in the header file to match Bitcoin's functionality while preserving Dash's macro-based structure. Original commit: fa825bd * Remove unrelated change in src/util/check.cpp The change in src/util/check.cpp was unrelated to the Bitcoin commit. Bitcoin's commit modifies the StrFormatInternalBug function, but Dash uses a macro-based approach in the header file instead. The only required change is the format_internal_error macro in src/util/check.h which correctly includes PACKAGE_NAME and FormatFullVersion(). 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude Code <claude@anthropic.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
PastaPastaPasta
added a commit
to DashCoreAutoGuix/dash
that referenced
this pull request
Jul 15, 2025
* Fix bitcoin#26645: Include full version id in bug reports - Modified format_internal_error macro to include PACKAGE_NAME and FormatFullVersion() - Added clientversion.h include to util/check.h - Reverted util/check.cpp to original state (no changes needed) The previous implementation incorrectly added entire functions to the .cpp file when the change should only modify the existing macro in the header file to match Bitcoin's functionality while preserving Dash's macro-based structure. Original commit: fa825bd * Remove unrelated change in src/util/check.cpp The change in src/util/check.cpp was unrelated to the Bitcoin commit. Bitcoin's commit modifies the StrFormatInternalBug function, but Dash uses a macro-based approach in the header file instead. The only required change is the format_internal_error macro in src/util/check.h which correctly includes PACKAGE_NAME and FormatFullVersion(). 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude Code <claude@anthropic.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
PastaPastaPasta
added a commit
to DashCoreAutoGuix/dash
that referenced
this pull request
Jul 16, 2025
* Fix bitcoin#26645: Include full version id in bug reports - Modified format_internal_error macro to include PACKAGE_NAME and FormatFullVersion() - Added clientversion.h include to util/check.h - Reverted util/check.cpp to original state (no changes needed) The previous implementation incorrectly added entire functions to the .cpp file when the change should only modify the existing macro in the header file to match Bitcoin's functionality while preserving Dash's macro-based structure. Original commit: fa825bd * Remove unrelated change in src/util/check.cpp The change in src/util/check.cpp was unrelated to the Bitcoin commit. Bitcoin's commit modifies the StrFormatInternalBug function, but Dash uses a macro-based approach in the header file instead. The only required change is the format_internal_error macro in src/util/check.h which correctly includes PACKAGE_NAME and FormatFullVersion(). 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude Code <claude@anthropic.com> Co-authored-by: PastaPastaPasta <6443210+PastaPastaPasta@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will show the unique id of the full source code when the bug occurred, which can help debugging