Skip to content

refactor: Move txmempool_entry.h --> kernel/mempool_entry.h #26609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2022
Merged

refactor: Move txmempool_entry.h --> kernel/mempool_entry.h #26609

merged 1 commit into from
Dec 6, 2022

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Nov 30, 2022

This PR addresses the #17786 (comment):

why not move it to the right place, that is to kernel/txmempool_entry.h?

@DrahtBot
Copy link
Contributor

DrahtBot commented Nov 30, 2022 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK MarcoFalke

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #26590 (net, refactor: Kill proxy globals by dergoegge)
  • #24539 (Add a "tx output spender" index by sstone)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@hebasto hebasto mentioned this pull request Nov 30, 2022
Merged
This was referenced Dec 1, 2022
Closed
Closed
Open
Closed
@hebasto hebasto added the Mempool label Dec 2, 2022
@glozow glozow requested a review from maflcko December 6, 2022 17:20
@glozow
Copy link
Member

glozow commented Dec 6, 2022

Makes sense to me, given src/kernel/mempool_limits.h is there

@maflcko
Copy link
Member

maflcko commented Dec 6, 2022

review ACK 38941a7 📊

Show signature

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

review ACK 38941a703e079709bb465ad1fcde50e11350f8f1 📊
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUhB+Av+Mjyg97YXKq3Wn9HWq8YhVBCwYg2ryPwjthV16MJpoYA0pWdxqPPPcZK2
z6kSh2WRAVjyqegez70y0sBo1WmSeR9BABOTP0/OHe81XK2ku7VIXt6TIDIqbu3B
/J3TVJ+sEkR5RKyu8ydi0PlmoS0GNrc/a7osieRbpySQz1jaxus1x680qa5Zulz2
3ASaDcUEzDa+6SZ9zb38v21z3FS8IEdTb3MFiLv3eoPtSxeRT0PaLUQgqB24bk3w
6TKOnWWpjPMCc1CGrNI22/1tGIj9Jduy36DZYuAsgKzhqOfpPuaJ2YqBgBreIpTG
6VmkwuIguV5MPQ0GFJkPVlhLc9wUZX0sMeJW3OAktQxj8LzCWP8tlkMnvCJkDEkd
FHFmuUENuxO5tPt8vO9Ru4DCp+7p36jFhwbO3FIPgX35B3mMDOExARAgSx42Ut0B
qRLsvBWZY09H0crkidL94M6OitoKbzR4HUtZSSeSp14ikOnnOFAJhBTxVWkOWGCA
STW1iLGl
=4JVU
-----END PGP SIGNATURE-----

@maflcko maflcko merged commit 1ff7929 into bitcoin:master Dec 6, 2022
@hebasto hebasto deleted the 221130-move branch December 6, 2022 18:20
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 6, 2022
Merge bitcoin#26609: refactor: Move txmempool_entry.h --> `kernel/mem…
98492d5 
…pool_…
@hebasto hebasto mentioned this pull request Dec 7, 2022
Merged
@bitcoin bitcoin locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maflcko maflcko Awaiting requested review from maflcko

Assignees
No one assigned
Labels
Mempool Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hebasto @DrahtBot @glozow @maflcko