ci: Skip COMMIT_RANGE if no CIRRUS_PR #26588
Conversation
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
|
Concept ACK. Thank you for taking this up! |
| echo | ||
| git log --no-merges --oneline "$COMMIT_RANGE" | ||
| echo |
There was a problem hiding this comment.
I'm not sure if moving git log --no-merges --oneline "$COMMIT_RANGE" up is an improvement. At least for me, it is very convenient to look at the list of commits at the end of the log.
There was a problem hiding this comment.
Is there even any value in keeping it. Now that it only runs on PRs, it should be only be needed for rare debugging of CI infrastructure bugs? In the normal case it will just be equal to the list of commits that GitHub displays, no?
There was a problem hiding this comment.
In the normal case it will just be equal to the list of commits that GitHub displays, no?
Exactly. That is why I check it out to ensure that it is normal :)
Anyway, I'm OK with the current state of this PR.
|
Should this PR be backported to release branches? |
fad1c55 lint: Skip COMMIT_RANGE if no CIRRUS_PR (MarcoFalke) Pull request description: Identical commit from #26588 Untested, but this may fix the red-ness in https://cirrus-ci.com/github/bitcoin/bitcoin/24.x, e.g. https://cirrus-ci.com/task/4697153604419584: Backport requested in #26588 (comment) ACKs for top commit: hebasto: ACK fad1c55, the same commit as in #26588. Tree-SHA512: 8d8a735e25bc1f774f8cbf058b95b7019941138ab78fb7819852755c7a416a783ee116457b97031d447639002353d7bf12ee8445275b7b5eec4abc7421cc171d
It doesn't make sense to run this for non-PRs, because:
Moreover, the test fails on non-master:
Fix all issues by skipping it.