Make static nLastFlush and nLastWrite Chainstate members #26513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsNo conflicts as of last run. |
This was referenced Nov 17, 2022
Closed
|
Concept ACK! |
|
ACK 07dfbb5 ( Reviewed, built, ran tests locally. Very simple, common-sense change that should |
|
RFM? |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 8, 2022
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 18, 2023
Summary: > Now that assumeutxo is well on the way, and multiple CChainState exist, we should review the mutable static local variables in CChainState methods. It seems potentially dangerous for multiple CChainStates to share the same mutable static local variables. ref T3378 This is a backport of [[bitcoin/bitcoin#26513 | core#26513]] Depends on D15001 Test Plan: `ninja all check-all` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Maniphest Tasks: T3378 Differential Revision: https://reviews.bitcoinabc.org/D15002
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22189.
The
static std::multimap<uint256, FlatFilePos> mapBlocksUnknownParent;referenced in the issue was already fixed by #25571. I don't believe Chainstate references any other static variables.