[23.x] guix: use --build={arch}-guix-linux-gnu in cross toolchain
#26474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technically we are always cross-compiling, so make that explicit. Fixes: bitcoin#22458. Github-Pull: bitcoin#25861 Rebased-From: 56e79fe
hebasto
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
ACK 0f4583e, tested on arm64:
9fd4601412738e9135e2732cfc8af911c54af8a1349c2af568b4748dd1907c3d guix-build-0f4583e5c114/output/aarch64-linux-gnu/SHA256SUMS.part
36df2797cd7845ccb4f416b52f9dbd4cc7dd0242782c3143206d0c15239e8b02 guix-build-0f4583e5c114/output/aarch64-linux-gnu/bitcoin-0f4583e5c114-aarch64-linux-gnu-debug.tar.gz
6aa022173b23827ec2690823178b9d2d06108e159a9074e1a54a7d1a74b6c5db guix-build-0f4583e5c114/output/aarch64-linux-gnu/bitcoin-0f4583e5c114-aarch64-linux-gnu.tar.gz
9c787047070b1fe8c2beead22093dc73481e7c921993d95fb0e4ce8739f8e515 guix-build-0f4583e5c114/output/dist-archive/bitcoin-0f4583e5c114.tar.gz
|
GUIX hashes x86 (not really relevant for this pr): arm64 (building): |
fanquake
added a commit
that referenced
this pull request
Nov 22, 2022
87c2ff8 doc: add release notes for 23.1rc2 (fanquake) 5b2c99e doc: Update manual pages for 23.1rc2 (fanquake) a02ae07 build: Bump version to 23.1rc2 (fanquake) a1fcd56 doc: add 23.0 relase notes (fanquake) Pull request description: Bump the version to 23.1rc2. Regenerate the man pages. Add historical 23.0 release notes. Add WIP 23.1 release notes. Changes since rc1: * #26474 * #26522 ACKs for top commit: hebasto: ACK 87c2ff8, I have reviewed the code and it looks OK, I agree it can be merged. jarolrod: ACK 87c2ff8 Tree-SHA512: f185c33bfe2bf26f9df48f8d1e95ab784fef055bc7465282e2418960d348bd8b35f8fc57808b47250f8536a9def3be2d1dbe8ae309f052a81220925c425108f1
jamesdorfman
added a commit
to jamesdorfman/elements
that referenced
this pull request
Sep 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #25861 to the 23.x branch, which fixes Guix building for
aarch64-linux-gnuon aarch64 hardware. Fixing Guix building for thisHOST, for the current release branch, seems like a worthwhile change, especially given more Guix builders are using aarch64 hardware. I thought I'd already backported this; noticed while building sigs for 23.1rc1, which I started doing on aarch64.Guix Build (aarch64, no
x86_64-apple-darwinorarm64-apple-darwin):