Skip to content

ci: Use macos-ventura-xcode:14.1 image for "macOS native" task #26388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2022
Merged

ci: Use macos-ventura-xcode:14.1 image for "macOS native" task #26388

merged 2 commits into from
Oct 27, 2022

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Oct 25, 2022 •
edited
Loading

The "macOS native" CI task always uses the recent OS image.

This PR updates it up to the recent macOS release.

Cirrus Labs stopped updating macOS images for x86_64, therefore, an arm64 image been used.

Also make test-security-check has been dropped as it "isn't even expected to pass" on arm64 in CI.

@hebasto hebasto changed the title ci: Use macos-ventura-xcode:14.1 image for "macOS native" task ci: Use macos-ventura-xcode:14.1 image for "macOS native" task Oct 25, 2022
maflcko
maflcko reviewed Oct 25, 2022
View reviewed changes
@fanquake
Copy link
Member

Also make test-security-check has been dropped as it "isn't even expected to pass" on arm64.

Yes it is expected to pass; in a Guix build. Not in the randomly bumped / changed CI environment.

maflcko
maflcko approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Sjors
Copy link
Member

Sjors commented Oct 27, 2022

Also make test-security-check has been dropped as it "isn't even expected to pass" on arm64 in CI.

Could be worth pointing to that issue in the commit message.

utACK da16893

Tangentially related: I'm able to build and run the tests on an Intel mac after updating to Ventura 13.0. Surprisingly :-)

@maflcko maflcko merged commit bd47889 into bitcoin:master Oct 27, 2022
@hebasto hebasto deleted the 221025-ventura branch October 28, 2022 10:10
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Oct 28, 2022
Merge bitcoin#26388: ci: Use macos-ventura-xcode:14.1 image for "macO…
d8f5541 
…S nat…
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Oct 30, 2022
Revert "Merge bitcoin#26388: ci: Use macos-ventura-xcode:14.1 image f…
49b99c6 
…or "macOS nat…"

This reverts commit d8f5541.
@ajtowns ajtowns mentioned this pull request Jan 12, 2023
Merged
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Jan 12, 2023
@hebasto @fanquake
ci: Make getopt path architecture agnostic
b59b289 
Github-Pull: bitcoin#26388
Rebased-From: 7028365
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Jan 12, 2023
@hebasto @fanquake
ci: Use macos-ventura-xcode:14.1 image for "macOS native" task
0200864 
Github-Pull: bitcoin#26388
Rebased-From: da16893
@fanquake fanquake mentioned this pull request Jan 12, 2023
Merged
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Jan 12, 2023
@hebasto @fanquake
ci: Make getopt path architecture agnostic
9ac5d4a 
Github-Pull: bitcoin#26388
Rebased-From: 7028365
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Jan 12, 2023
@hebasto
ci: Make getopt path architecture agnostic
50ad39d 
Github-Pull: bitcoin#26388
Rebased-From: 7028365
maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Jan 12, 2023
@hebasto
ci: Use macos-ventura-xcode:14.1 image for "macOS native" task
95ec960 
Github-Pull: bitcoin#26388
Rebased-From: da16893
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Jan 12, 2023
@hebasto @fanquake
ci: Make getopt path architecture agnostic
8f2e58f 
Github-Pull: bitcoin#26388
Rebased-From: 7028365
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Jan 12, 2023
@hebasto @fanquake
ci: Make getopt path architecture agnostic
5d7bac3 
Github-Pull: bitcoin#26388
Rebased-From: 7028365
jarolrod pushed a commit to jarolrod/bitcoin that referenced this pull request Jan 13, 2023
@hebasto @jarolrod
ci: Make getopt path architecture agnostic
4f0b233 
Github-Pull: bitcoin#26388
Rebased-From: 7028365
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Jan 13, 2023
@hebasto @fanquake
ci: Make getopt path architecture agnostic
3bbcbf2 
Github-Pull: bitcoin#26388
Rebased-From: 7028365
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Jan 13, 2023
@hebasto @fanquake
ci: Make getopt path architecture agnostic
72c8d37 
Github-Pull: bitcoin#26388
Rebased-From: 7028365
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Jan 16, 2023
@hebasto @fanquake
ci: Make getopt path architecture agnostic
53fd827 
Github-Pull: bitcoin#26388
Rebased-From: 7028365
fanquake pushed a commit to fanquake/bitcoin that referenced this pull request Jan 16, 2023
@hebasto @fanquake
ci: Use macos-ventura-xcode:14.1 image for "macOS native" task
a3db8bd 
Github-Pull: bitcoin#26388
Rebased-From: da16893
@theuni
Copy link
Member

theuni commented May 16, 2023 •
edited
Loading

As seen here, this seems to have removed RUN_SECURITY_TESTS for x86 too? Ping @hebasto

@fanquake
Copy link
Member

As #27676 (comment), this seems to have removed RUN_SECURITY_TESTS for x86 too?

See #27683.

@hebasto hebasto mentioned this pull request Jun 14, 2023
Merged
fanquake added a commit that referenced this pull request Jun 14, 2023
@fanquake
Merge #27881: ci: Use latest macos-ventura-xcode:14.3.1 image
681ecac 
a13c3f3 ci: Use latest `macos-ventura-xcode:14.3.1` image (Hennadii Stepanov)

Pull request description:

  As documented: https://github.com/bitcoin/bitcoin/blob/427853ab49f610e971b73ea4cc1d5366747e52b1/.cirrus.yml#L339

  Last time, the image was updated in #26388.

  The `check_clang` script diff:
  ```diff
  --- master
  +++ pr
  @@ -1,5 +1,5 @@
   clang --version
  -Apple clang version 14.0.0 (clang-1400.0.29.202)
  -Target: arm64-apple-darwin22.1.0
  +Apple clang version 14.0.3 (clang-1403.0.22.14.1)
  +Target: arm64-apple-darwin22.5.0
   Thread model: posix
  -InstalledDir: /Applications/Xcode-14.1.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
  +InstalledDir: /Applications/Xcode-14.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

ACKs for top commit:
  fanquake:
    ACK a13c3f3

Tree-SHA512: 18ffa97cc5900a5b35d0ecda79a55d7427610c6e799742b5811e1c470ef320fd98f9400168c4c517f8668f1bf76e57d68cd373a41fa346d15084855aa2c409b3
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jun 15, 2023
@fanquake
Merge bitcoin#27881: ci: Use latest macos-ventura-xcode:14.3.1 image
b391c9f 
a13c3f3 ci: Use latest `macos-ventura-xcode:14.3.1` image (Hennadii Stepanov)

Pull request description:

  As documented: https://github.com/bitcoin/bitcoin/blob/427853ab49f610e971b73ea4cc1d5366747e52b1/.cirrus.yml#L339

  Last time, the image was updated in bitcoin#26388.

  The `check_clang` script diff:
  ```diff
  --- master
  +++ pr
  @@ -1,5 +1,5 @@
   clang --version
  -Apple clang version 14.0.0 (clang-1400.0.29.202)
  -Target: arm64-apple-darwin22.1.0
  +Apple clang version 14.0.3 (clang-1403.0.22.14.1)
  +Target: arm64-apple-darwin22.5.0
   Thread model: posix
  -InstalledDir: /Applications/Xcode-14.1.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
  +InstalledDir: /Applications/Xcode-14.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

ACKs for top commit:
  fanquake:
    ACK a13c3f3

Tree-SHA512: 18ffa97cc5900a5b35d0ecda79a55d7427610c6e799742b5811e1c470ef320fd98f9400168c4c517f8668f1bf76e57d68cd373a41fa346d15084855aa2c409b3
supernormand pushed a commit to supernormand/extracoin that referenced this pull request Jul 10, 2023
@fanquake @supernormand
Merge bitcoin#27881: ci: Use latest macos-ventura-xcode:14.3.1 image
d165294 
a13c3f3 ci: Use latest `macos-ventura-xcode:14.3.1` image (Hennadii Stepanov)

Pull request description:

  As documented: https://github.com/bitcoin/bitcoin/blob/427853ab49f610e971b73ea4cc1d5366747e52b1/.cirrus.yml#L339

  Last time, the image was updated in bitcoin#26388.

  The `check_clang` script diff:
  ```diff
  --- master
  +++ pr
  @@ -1,5 +1,5 @@
   clang --version
  -Apple clang version 14.0.0 (clang-1400.0.29.202)
  -Target: arm64-apple-darwin22.1.0
  +Apple clang version 14.0.3 (clang-1403.0.22.14.1)
  +Target: arm64-apple-darwin22.5.0
   Thread model: posix
  -InstalledDir: /Applications/Xcode-14.1.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
  +InstalledDir: /Applications/Xcode-14.3.1.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

ACKs for top commit:
  fanquake:
    ACK a13c3f3

Tree-SHA512: 18ffa97cc5900a5b35d0ecda79a55d7427610c6e799742b5811e1c470ef320fd98f9400168c4c517f8668f1bf76e57d68cd373a41fa346d15084855aa2c409b3
@hebasto hebasto mentioned this pull request Jul 30, 2023
Merged
achow101 added a commit to bitcoin-core/gui that referenced this pull request Aug 15, 2023
@achow101
Merge bitcoin/bitcoin#28187: ci: Run "macOS native x86_64" job on Git…
b97b050 
…Hub Actions

9658d0d ci: Run "macOS native x86_64" job on GitHub Actions (Hennadii Stepanov)

Pull request description:

  From bitcoin/bitcoin#28098:
  > Thus, someone would have to sponsor an amount of roughly 5kUSD/mo for those two tasks.

  > If the goal is to stay on a free plan, I think the only option is GitHub Actions CI.

  ---

  **IMPORTANT NOTE**. We currently ship macOS release binaries for both architectures: `x86_64` and `arm64`. If this PR gets merged, only `x86_64` architecture will be tested on CI, which implies some [drawbacks](bitcoin/bitcoin#28187 (comment)).

  However, it has never been the case that our CI tested both architectures simultaneously. And we hope that GitHub Actions will soon host macOS `arm64` runners.

  Historically, we moved from `x86_64` to `arm64` in bitcoin/bitcoin#26388 less than a year ago.

  ---

  Security concerns:
  - bitcoin/bitcoin#28098 (comment)
  - bitcoin/bitcoin#28098 (comment)

  `GITHUB_TOKEN` permissions (from the build log in my personal repo):
  ```
  2023-07-27T07:30:17.8313534Z ##[group]GITHUB_TOKEN Permissions
  2023-07-27T07:30:17.8314113Z Contents: read
  2023-07-27T07:30:17.8314608Z Metadata: read
  2023-07-27T07:30:17.8314957Z Packages: read
  2023-07-27T07:30:17.8315233Z ##[endgroup]
  ```

  Comparison of resources:

  | Resource | Current, Cirrus CI | Suggested, GitHub Actions |
  |---|:-:|:-:|
  | CPU | 4 | 4 \*\* |
  | RAM, GB | 8 | 14 |

  **\*\* NOTE**: However, [docs](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources) are mentioning:
  > 3-core CPU (x86_64)

ACKs for top commit:
  MarcoFalke:
    re-ACK 9658d0d 🏂
  achow101:
    ACK 9658d0d
  jarolrod:
    ACK 9658d0d

Tree-SHA512: 6123e68e6784cdf4e53c3e77b435709261db21f09091af2c22e667d3816a305fffb9d617297a5bc1bda18aaba84a6e210cec6a75c52afa7746a3780a67b69865
@knst knst mentioned this pull request Oct 11, 2023
Draft
5 tasks
@bitcoin bitcoin locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@maflcko maflcko maflcko approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
macOS Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hebasto @fanquake @Sjors @theuni @maflcko