Skip to content

Conversation

hebasto
Copy link
Member

@hebasto hebasto commented Oct 24, 2022

Fixes #26368.

@hebasto
Copy link
Member Author

hebasto commented Oct 24, 2022

#26368 (comment):

Can confirm this fixes the problem for me.

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #25696 (build: Re-enable external signer on Windows by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@Sjors
Copy link
Member

Sjors commented Oct 26, 2022

Concept ACK

Not sure how to test this for cross compilation without #25696 (which conflict with this commit), since the test needs ENABLE_EXTERNAL_SIGNER to be defined. But can test the native build.

@Sjors
Copy link
Member

Sjors commented Oct 26, 2022

tACK 884304e

Tested with native build: .\src\test_bitcoin.exe --run_test=system_tests

@maflcko maflcko merged commit 1bad29f into bitcoin:master Oct 28, 2022
@hebasto hebasto deleted the 221024-nonloc branch October 28, 2022 10:05
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Oct 28, 2022
…e and platform agnostic

884304e test: Make `system_tests/run_command` locale agnostic (Hennadii Stepanov)

Pull request description:

  Fixes bitcoin#26368.

ACKs for top commit:
  Sjors:
    tACK 884304e

Tree-SHA512: 76d4941e02b3b119dcf4dacbe60ef45a9dc8cf775bdb31b5291cd8147665285d41caaf1f5688abdfc9a47c393ddb535af7b11af839660d30ef30f1ca0d936133
@bitcoin bitcoin locked and limited conversation to collaborators Oct 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"system_tests/run_command" unit test fails on MSVC
4 participants