ci: Allow PIP_PACKAGES on centos #26234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa7634f to
fa684bc
Compare
hebasto
reviewed
Oct 3, 2022
maflcko
commented
Oct 3, 2022
| # shellcheck disable=SC2086 | ||
| ${CI_RETRY_EXE} pip3 install --user $PIP_PACKAGES | ||
| ${CI_RETRY_EXE} CI_EXEC pip3 install --user $PIP_PACKAGES |
There was a problem hiding this comment.
Review note: Adding CI_EXEC is required, otherwise it would result in a failure.
To reproduce the failure:
$ RESTART_CI_DOCKER_BEFORE_RUN=1 FILE_ENV="./ci/test/00_setup_env_i686_centos.sh" ./ci/test_run_all.sh
...
bash: line 1: pip3: command not found
There was a problem hiding this comment.
This also fixes a bug on historic commits. To reproduce the bug on the historic commits:
$ git checkout 3c3bd9022026a75e15492ba9cf8bf3b72866b9a9~ && RESTART_CI_DOCKER_BEFORE_RUN=1 FILE_ENV="./ci/test/00_setup_env_i686_multiprocess.sh" ./ci/test_run_all.sh
...
bash: line 1: pip3: command not found
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
added 2 commits
October 4, 2022 11:51
Address feedback from https://github.com/bitcoin/bitcoin/pull/24561/files#r985719812
This was added in 7fc5e86 but I can't see a reason why this should be forbidden.
maflcko
commented
Oct 4, 2022
fa684bc to
fa6054e
Compare
|
For reference, interface_zmq.py:
|
hebasto
approved these changes
Oct 4, 2022
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Oct 5, 2022
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 12, 2023
Address feedback from https://github.com/bitcoin/bitcoin/pull/24561/files#r985719812 Github-Pull: bitcoin#26234 Rebased-From: fac085a
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 12, 2023
This was added in 7fc5e86 but I can't see a reason why this should be forbidden. Github-Pull: bitcoin#26234 Rebased-From: fa6054e
Merged
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 12, 2023
Address feedback from https://github.com/bitcoin/bitcoin/pull/24561/files#r985719812 Github-Pull: bitcoin#26234 Rebased-From: fac085a
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 12, 2023
This was added in 7fc5e86 but I can't see a reason why this should be forbidden. Github-Pull: bitcoin#26234 Rebased-From: fa6054e
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 12, 2023
Github-Pull: bitcoin#26234 Rebased-From: da16893
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jan 12, 2023
Address feedback from https://github.com/bitcoin/bitcoin/pull/24561/files#r985719812 Github-Pull: bitcoin#26234 Rebased-From: fac085a
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jan 12, 2023
This was added in 7fc5e86 but I can't see a reason why this should be forbidden. Github-Pull: bitcoin#26234 Rebased-From: fa6054e
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 12, 2023
This was added in 7fc5e86 but I can't see a reason why this should be forbidden. Github-Pull: bitcoin#26234 Rebased-From: fa6054e
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 12, 2023
Github-Pull: bitcoin#26234 Rebased-From: da16893
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 12, 2023
Github-Pull: bitcoin#26234 Rebased-From: da16893
jarolrod
pushed a commit
to jarolrod/bitcoin
that referenced
this pull request
Jan 13, 2023
Github-Pull: bitcoin#26234 Rebased-From: da16893
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 13, 2023
Github-Pull: bitcoin#26234 Rebased-From: da16893
fanquake
pushed a commit
to fanquake/bitcoin
that referenced
this pull request
Jan 13, 2023
Github-Pull: bitcoin#26234 Rebased-From: da16893
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added in 7fc5e86 but I can't see a reason why this should be forbidden.
This is also needed for other changes (bumping the minimum python version).