build: remove stdio.h from header checks #26150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use both. Consolidate on the former.
We already use a mix of <cstdio> and stdio.h unconditionally throughout the codebase. Us checking this header also duplicates work already done by autotools. Currently stdio.h is checked for 3 times during a ./configure run, after this change, at least it's only twice.
kristapsk
approved these changes
Sep 21, 2022
|
ACK 55aad5f |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 23, 2022
55aad5f build: remove stdio.h from header checks (fanquake) b956331 refactor: use <cstdio> over stdio.h (fanquake) Pull request description: We already use a mix of `<cstdio>` and `stdio.h` unconditionally throughout the codebase. Us checking this header also duplicates work already done by autotools. Currently `stdio.h` is checked for 3 times during a ./configure run, after this change, at least it's only twice. ACKs for top commit: TheCharlatan: ACK 55aad5f kristapsk: ACK 55aad5f Tree-SHA512: a83cc724528ab92aacfa53048b12fcccec3962637ca7fad30f6c610365edeb0e951f74e37832ad7d3f79ca9b8d7203cb10165c89d0e4b63eeda7a970dab82dfb
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Sep 25, 2022
553ff45 build: remove stdlib.h from header checks (fanquake) a63d4cb refactor: use <cstdlib> over stdlib.h (fanquake) Pull request description: We already use a mix of `<cstlib>` and `stdlib.h` unconditionally throughout the codebase. Us checking this header also duplicates work already done by autotools. Currently stdlib.h is checked for 3 times during a ./configure run, after this change, at least it's only twice. Similar to bitcoin#26150. ACKs for top commit: kristapsk: ACK 553ff45 TheCharlatan: ACK 553ff45 Tree-SHA512: 0a43d39d3df180a1614dbd3a1ee1531b0969ffe4a0c09dfe9d2f3f0ec16196b5fd7523309f6722936a8c8b20908508724e1903e939dd81c3b4538d85d0f42953
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already use a mix of
<cstdio>andstdio.hunconditionally throughoutthe codebase.
Us checking this header also duplicates work already done by autotools.
Currently
stdio.his checked for 3 times during a ./configure run, afterthis change, at least it's only twice.