doc: comment "add only reachable addresses to addrman" #26040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK 9094951 |
mzumsande
reviewed
Sep 7, 2022
9094951 to
a7b4f97
Compare
Zero-1729
reviewed
Sep 8, 2022
Zero-1729
reviewed
Sep 8, 2022
vasild
approved these changes
Sep 8, 2022
I would hope "until it's fixed". :) |
a7b4f97 to
ce42570
Compare
|
Addressed additional review comments. |
amovfx
reviewed
Sep 9, 2022
Sjors
reviewed
Sep 9, 2022
| @@ -1648,6 +1648,14 @@ void CConnman::ThreadOpenConnections(const std::vector<std::string> connect) | |||
|
|
|||
| if (add_fixed_seeds_now) { | |||
| std::vector<CAddress> seed_addrs{ConvertSeeds(Params().FixedSeeds())}; | |||
| // We will not make outgoing connections to peers that are unreachable | |||
There was a problem hiding this comment.
Maybe it wants:
/* Blah
* blah
* blah */There was a problem hiding this comment.
No, there are two random funcional tests failing in each failed CI run for some reason (different one in each case), should not be related with this change.
There was a problem hiding this comment.
The second one is new to me, I opened #26051 - but yes, obviously unrelated.
vasild
approved these changes
Sep 9, 2022
Zero-1729
reviewed
Sep 9, 2022
|
ACK ce42570 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 11, 2022
…drman" ce42570 doc: comment "add only reachable addresses to addrman" (Kristaps Kaupe) Pull request description: Proposed by Sjors during review of bitcoin#25678, was likely just missed, as it also for me looks a code where comment will not hurt. bitcoin#25678 (comment) ACKs for top commit: mzumsande: ACK ce42570 vasild: ACK ce42570 Zero-1729: re-ACK ce42570 Tree-SHA512: ef085d527349de07c1b43ed39e55e34b29cb0137c9509bd14a1af88206f7d4aa7dfec1dca53a9deaed67a2d0f32fa21e0b1a04d4d5d7f8a265dfab3b62bf8c54
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed by Sjors during review of #25678, was likely just missed, as it also for me looks a code where comment will not hurt.
#25678 (comment)