fixups for BIP125 doc cleanup #25902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grammar and readability fixups. Clarifies "bip125-replaceable" helpstrings.
maflcko
reviewed
Aug 22, 2022
| @@ -255,7 +255,7 @@ static std::vector<RPCResult> MempoolEntryDescription() | |||
| {RPCResult{RPCResult::Type::STR_HEX, "transactionid", "parent transaction id"}}}, | |||
| RPCResult{RPCResult::Type::ARR, "spentby", "unconfirmed transactions spending outputs from this transaction", | |||
| {RPCResult{RPCResult::Type::STR_HEX, "transactionid", "child transaction id"}}}, | |||
| RPCResult{RPCResult::Type::BOOL, "bip125-replaceable", "Whether this transaction could be replaced due to BIP125 (replace-by-fee)"}, | |||
| RPCResult{RPCResult::Type::BOOL, "bip125-replaceable", "Whether this transaction signals BIP125 replaceability or has an unconfirmed ancestor signaling BIP125 replaceability.\n"}, | |||
There was a problem hiding this comment.
For reference, this change adds clarification around the #22209 misunderstanding
There was a problem hiding this comment.
Yeah, hopefully this can close that.
This comment was helpful background for me: #25575 (comment)
There was a problem hiding this comment.
Hmm, depending on the user there might still be a need for just finding out the signal of this tx, not taking into account the ancestors.
So I think we could return two bools, or an enum, see #25575 (comment)
There was a problem hiding this comment.
So I think we could return two bools, or an enum, see #25575 (comment)
either would make sense imo 🤷
t-bast
approved these changes
Aug 22, 2022
ariard
reviewed
Aug 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followups from #25775: