refactor: Move ChainstateManager options into m_options struct #25905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move ChainstateManager options into m_options struct to simplify class initialization, organize class members, and to name external option variables differently than internal state variables. This change was originally in bitcoin#25862, but it was suggested to split off in bitcoin#25862 (comment) so it could be merged earlier and reduce conflicts with other PRs.
This was referenced Aug 22, 2022
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
ACK 6db2c00 |
maflcko
reviewed
Aug 24, 2022
src/validation.h
Outdated
| @@ -881,6 +878,7 @@ class ChainstateManager | |||
| */ | |||
| RecursiveMutex& GetMutex() const LOCK_RETURNED(::cs_main) { return ::cs_main; } | |||
|
|
|||
| Options m_options; | |||
There was a problem hiding this comment.
Any reason to remove the const?
There was a problem hiding this comment.
ryanofsky
commented
Aug 24, 2022
There was a problem hiding this comment.
Updated 6db2c00 -> 7bc33a8 (pr/csmopt.1 -> pr/csmopt.2, compare) adding const as suggested
src/validation.h
Outdated
| @@ -881,6 +878,7 @@ class ChainstateManager | |||
| */ | |||
| RecursiveMutex& GetMutex() const LOCK_RETURNED(::cs_main) { return ::cs_main; } | |||
|
|
|||
| Options m_options; | |||
There was a problem hiding this comment.
|
ACK 7bc33a8 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
ChainstateManageroptions intom_optionsstruct to simplify class initialization, organize class members, and to name external option variables differently than internal state variables.This change was originally in #25862, but it was suggested to split off in #25862 (comment) so it could be merged earlier and reduce conflicts with other PRs.