build: Fix help string for --enable-external-signer configure option
#25770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristapsk
approved these changes
Aug 2, 2022
jarolrod
reviewed
Aug 2, 2022
There was a problem hiding this comment.
ACK 8df063e
This is correct, it's documented in the code a few lines below :)
relevant output of ./configure -help on this PR branch:
--enable-external-signer
compile external signer support (default is auto,
requires Boost::Process)
| @@ -322,7 +322,7 @@ AC_ARG_ENABLE([werror], | |||
| [enable_werror=no]) | |||
|
|
|||
| AC_ARG_ENABLE([external-signer], | |||
| [AS_HELP_STRING([--enable-external-signer],[compile external signer support (default is yes, requires Boost::Process)])], | |||
| [AS_HELP_STRING([--enable-external-signer],[compile external signer support (default is auto, requires Boost::Process)])], | |||
There was a problem hiding this comment.
the default is auto, you can also supply yes and no. Should we follow the convention used elsewhere of specifying the possible inputs, so for example, the help output could be:
--enable-external-signer[=yes|no|auto]
compile external signer support (default is auto,
requires Boost::Process)
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 4, 2022
…gner` configure option 8df063e build: Fix help string for `--enable-external-signer` configure option (Hennadii Stepanov) Pull request description: This PR is a follow up of bitcoin#24065 and fixes the help string according to the actual default value https://github.com/bitcoin/bitcoin/blob/816ca01650f4cc66a61ac2f9b0f8b74cd9cd0cf8/configure.ac#L324-L327 ACKs for top commit: kristapsk: cr utACK 8df063e jarolrod: ACK 8df063e Tree-SHA512: ad3f457a53c9238ddd8ded9efd1224e564e6cb9da8b7ff7733a11e32a7daad5c0f6c6223509218f44944a874470cb0d2447897662eaf4e78c763b30785717c50
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up of #24065 and fixes the help string according to the actual default value
bitcoin/configure.ac
Lines 324 to 327 in 816ca01