Skip to content

univalue: Avoid std::string copies #25714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2022
Merged

univalue: Avoid std::string copies #25714

merged 2 commits into from
Nov 14, 2022

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Jul 26, 2022

This shouldn't matter too much, unless a really large string is pushed into a json struct, but I think it also clarifies the code.

@fanquake
Copy link
Member

cc @martinus

@DrahtBot DrahtBot mentioned this pull request Jul 29, 2022
Merged
@DrahtBot
Copy link
Contributor

DrahtBot commented Jul 29, 2022 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

@maflcko maflcko force-pushed the 2207-univalue-types- branch 2 times, most recently from fad7b66 to fa2ceb5 Compare August 2, 2022 10:45
@DrahtBot DrahtBot mentioned this pull request Aug 19, 2022
Merged
@maflcko maflcko force-pushed the 2207-univalue-types- branch from fa2ceb5 to fa67d7c Compare September 1, 2022 16:11
@fanquake fanquake requested a review from ryanofsky September 1, 2022 16:19
ryanofsky
ryanofsky approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@ryanofsky ryanofsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK fa67d7c. Left some minor suggestions, not important

ryanofsky
ryanofsky approved these changes Sep 1, 2022
View reviewed changes
@maflcko maflcko force-pushed the 2207-univalue-types- branch 2 times, most recently from fae9c86 to fa61fd6 Compare September 5, 2022 12:36
aureleoules
aureleoules approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@aureleoules aureleoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa61fd6

@maflcko maflcko force-pushed the 2207-univalue-types- branch from fa61fd6 to fa09525 Compare November 7, 2022 08:42
aureleoules
aureleoules approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@aureleoules aureleoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reACK fa09525

@maflcko maflcko requested a review from ryanofsky November 7, 2022 09:04
ryanofsky
ryanofsky approved these changes Nov 13, 2022
View reviewed changes
Copy link
Contributor

@ryanofsky ryanofsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK fa09525

@martinus
Copy link
Contributor

Code review ACK fa09525

@maflcko maflcko merged commit 59e00c7 into bitcoin:master Nov 14, 2022
@maflcko maflcko deleted the 2207-univalue-types-🙉 branch November 14, 2022 09:23
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Nov 14, 2022
Merge bitcoin#25714: univalue: Avoid std::string copies
ff49ec4
@bitcoin bitcoin locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanofsky ryanofsky ryanofsky approved these changes

+2 more reviewers

@martinus martinus martinus approved these changes

@aureleoules aureleoules aureleoules approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maflcko @fanquake @DrahtBot @martinus @ryanofsky @aureleoules