RPC: Document "asm" and "hex" fields for scripts & fix getblock help #25691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
634e094 to
56d9244
Compare
kristapsk
approved these changes
Jul 25, 2022
maflcko
reviewed
Jul 25, 2022
| {RPCResult::Type::STR, "asm", "The asm"}, | ||
| {RPCResult::Type::STR_HEX, "hex", "The hex"}, | ||
| {RPCResult::Type::STR, "asm", "Disassembly of the public key script"}, | ||
| {RPCResult::Type::STR, "desc", "Inferred descriptor for the output"}, |
There was a problem hiding this comment.
We should probably get rid of RPCResult::Type::ELISION to have the test check for invalid docs here
There was a problem hiding this comment.
But then the docs themselves would be less helpful. Maybe there's a better way? (A flag for elided fields in place of a description?)
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jul 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #24718