Skip to content

refactor: Make CTransaction constructor explicit #25694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2022
Merged

refactor: Make CTransaction constructor explicit #25694

merged 1 commit into from
Jul 26, 2022

Conversation

maflcko
Copy link
Member

@maflcko maflcko commented Jul 25, 2022

It involves calculating two hashes, so the performance impact should be
made explicit.

Also, add the module to iwyu.

refactor: Make CTransaction constructor explicit
fa2247a 
It involves calculating two hashes, so the performance impact should be
made explicit.

Also, add the module to iwyu.
hebasto
hebasto approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@hebasto hebasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fa2247a, I have reviewed the code and it looks OK, I agree it can be merged.

@aureleoules
Copy link
Contributor

ACK fa2247a.
In my understanding, these changes disable copy-initialization of CTransaction to avoid potentially hashing twice.

On a related note, should we make all single-argument constructors explicit ?
https://github.com/isocpp/CppCoreGuidelines/blob/6f27719b2b994d1304f78194dc7824e4ddeea5f5/CppCoreGuidelines.md#c46-by-default-declare-single-argument-constructors-explicit

@maflcko
Copy link
Member Author

maflcko commented Jul 25, 2022

In my understanding, these changes disable copy-initialization of CTransaction to avoid potentially hashing twice.

Not sure what you mean, but this should not change any constructor or code logic. This simply forces devs to write CTransaction at least once if they want to construct one.

On a related note, should we make all single-argument constructors explicit ?
https://github.com/isocpp/CppCoreGuidelines/blob/6f27719b2b994d1304f78194dc7824e4ddeea5f5/CppCoreGuidelines.md#c46-by-default-declare-single-argument-constructors-explicit

Probably not, as the url you link to advises against that.

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #17529 (rpc: Faster getblock using PureBlock by MarcoFalke)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@DrahtBot DrahtBot mentioned this pull request Jul 26, 2022
Closed
@maflcko maflcko merged commit c90f86e into bitcoin:master Jul 26, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Jul 27, 2022
Merge bitcoin#25694: refactor: Make CTransaction constructor explicit
c1cc218
@bitcoin bitcoin locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hebasto hebasto hebasto approved these changes

Assignees
No one assigned
Labels
Refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maflcko @aureleoules @DrahtBot @hebasto