wallet: Faster transaction creation by removing pre-set-inputs fetching responsibility from Coin Selection #25685

furszy · 2022-07-23T13:19:19Z

# Context (Current Flow on Master)

In the transaction creation process, in order to select which coins the new transaction will spend,
we first obtain all the available coins known by the wallet, which means walking-through the
wallet txes map, gathering the ones that fulfill certain spendability requirements in a vector.

This coins vector is then provided to the Coin Selection process, which first checks if the user
has manually selected any input (which could be internal, aka known by the wallet, or external),
and if it does, it fetches them by searching each of them inside the wallet and/or inside the
Coin Control external tx data.

Then, after finding the pre-selected-inputs and gathering them in a vector, the Coin Selection
process walks-through the entire available coins vector once more just to erase coins that are
in both vectors. So the Coin Selection process doesn’t pick them twice (duplicate inputs inside
the same transaction).

# Process Workflow Changes

Now, a new method, FetchCoins will be responsible for:

Lookup the user pre-selected-inputs (which can be internal or external).
And, fetch the available coins in the wallet (excluding the already fetched ones).

Which will occur prior to the Coin Selection process. Which allows us to never include the
pre-selected-inputs inside the available coins vector in the first place, as well as doing other
nice improvements (written below).

So, Coin Selection can perform its main responsibility without mixing it with having to fetch
internal/external coins nor any slow and unneeded duplicate coins verification.

# Summarizing the Improvements:

If any pre-selected-input lookup fail, the process will return the error right away.
(before, the wallet was fetching all the wallet available coins, walking through the
entire txes map, and then failing for an invalid pre-selected-input inside SelectCoins)
The pre-selected-inputs lookup failure causes are properly described on the return error.
(before, we were returning an "Insufficient Funds" error for everything, even if the failure
was due a not solvable external input)
Faster Coin Selection: no longer need to "remove the pre-set inputs from the available coins
vector so that Coin Selection doesn't pick them" (which meant to loop-over the entire
available coins vector at Coin Selection time, erasing duplicate coins that were pre-selected).

Now, the available coins vector, which is built after the pre-selected-inputs fetching,
doesn’t include the already selected inputs in the first place.
Faster transaction creation for transactions that only use manually selected inputs.

We now will return early, as soon as we finish fetching the pre-selected-inputs and
not perform the resources expensive calculation of walking-through the entire wallet
txes map to obtain the available coins (coins that we will not use).

Added a new bench (f6d0bb2) measuring the transaction creation process, for a wallet with ~250k UTXO, only using the pre-selected-inputs inside coin control. Setting m_allow_other_inputs=false to disallow the wallet to include coins automatically.

Result on this PR (tip `f6d0bb2`):

ns/op	op/s	err%	total	benchmark
1,048,675.00	953.58	0.3%	0.06	`WalletCreateTransaction`

vs

Result on master (tip `4a4289e`):

ns/op	op/s	err%	total	benchmark
96,373,458.20	10.38	0.2%	5.30	`WalletCreateTransaction`

The benchmark took to run in master: 96.37 milliseconds, while in this PR: 1 millisecond 🚀 .

DrahtBot · 2022-07-23T15:16:33Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#26154 (refactor: Move coin_control variable to test setup section by yancyribbens)
#26152 (Bump unconfirmed ancestor transactions to target feerate by Xekyo)
#26066 (wallet: Refactor and document CoinControl by aureleoules)
#26008 (wallet: cache IsMine scriptPubKeys to improve performance of wallets with a lot of non-ranged descriptors by achow101)
#25730 (RPC: listunspent, add "include immature coinbase" flag by furszy)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

furszy · 2022-07-29T17:19:56Z

rebased, conflicts solved.

ishaanam · 2022-08-01T21:41:03Z

Concept ACK, this seems like a good improvement.

achow101 · 2022-08-02T19:51:08Z

It's not clear to me that this provides any significant benefit over a much simpler change of just excluding pre-selected inputs from AvailableCoins. The only other improvement this provides is better error reporting, but I think it would be better to just go through SelectCoins and improve its error reporting instead of pulling things out so that errors are reported elsewhere.

furszy · 2022-08-02T22:16:06Z

It's not clear to me that this provides any significant benefit over a much simpler change of just excluding pre-selected inputs from AvailableCoins. The only other improvement this provides is better error reporting, but I think it would be better to just go through SelectCoins and improve its error reporting instead of pulling things out so that errors are reported elsewhere.

There are several benefits, (aside from what I wrote in the PR description):

Sources Architecture:

Do make sense for you to be fetching, and verifying, coins in a function whose main responsibility is perform the Coin Selection process?

The Coin Selection should receive coins, and certain user/wallet parameters, so it can produce all the possible solutions for a certain target amount, picking and returning the best of them.

Just imagine how this would looks like if Coin Selection would be a separated library (which, for its increasing specialization, could easily be one in the future). You would never include the pre-selected-inputs fetching and verification process into the Coin Selection responsibilities at all because cannot/shouldn't do it there.

Tangible Improvements:

As we will do the pre-selected-inputs fetching and verification prior to calling AvailableCoins, if there is an error when the wallet fetches any of the preset-inputs, the transaction creation process can fail right away without calling AvailableCoins (Function that, as we know, walks-through the entire wallet's transactions map and performs all the internal available coins checks).

This prevents us from wasting resources that we are currently wasting for, literally, no reason.

In master, we are first looping-through the entire wallet's map inside AvailableCoins, which is a resource intensive task if you have a big wallet, just to fail right after it finishes, discarding the coins result, because one of the pre-set inputs has an error.
If the user disallowed the "other inputs selection" by setting m_allow_other_inputs=false (which means: “no coins from the AvailableCoins result function will be used during Coin Selection”): 

In master: we loop-through the entire wallet's map inside AvailableCoins first, then we discard the computed result (because we will not use it..), then we fetch and use the pre-selected-inputs only.
Which is time and processing power wasted for no reason.

In this PR: we simply select the preset inputs, skip AvailableCoins if m_allow_other_inputs=false and provides them to SelectCoins.

but I think it would be better to just go through SelectCoins and improve its error reporting instead of pulling things out so that errors are reported elsewhere.

We are currently failing inside the Coin Selection process due:

“Invalid pre-selected input”
“Not found pre-selected input”
“Not solvable pre-selected input”

These errors have nothing to do with the Coin Selection process. Why keep them there?

It's not that I located these errors on a random place. I placed them inside a "Fetch Coins" procedure whose main responsibility is fetch the coins that the user pre-selected and fetch the available coins in the wallet. Which seems totally reasonable for me.

I mean, this errors have been obscured inside Coin Selection all this time, not being properly notified, because they should had never been placed there in the first place. It's all about a proper responsibility division to make the process clearer and cleaner so it's less error-prone (and in this case, in some occasions, actually faster and less resource consuming).

furszy · 2022-08-03T18:23:29Z

To make the speed improvements more visible, pushed a new benchmark f6d0bb2.

Basically, the new bench measures the transaction creation process, for a wallet with ~250k UTXO, only using the pre-selected-inputs inside coin control. Setting m_allow_other_inputs=false to disallow the wallet to include coins automatically.

This is the result on this PR (tip `f6d0bb2`):

ns/op	op/s	err%	total	benchmark
1,048,675.00	953.58	0.3%	0.06	`WalletCreateTransaction`

vs

This is the result on current master (tip `4a4289e`):

ns/op	op/s	err%	total	benchmark
96,373,458.20	10.38	0.2%	5.30	`WalletCreateTransaction`

Summary

The benchmark took to run in master: 96.37 milliseconds, while in this PR: 1 millisecond 🚀 .

Updated PR description with the benchmark results.

src/wallet/spend.cpp

furszy · 2022-08-06T13:29:25Z

Took me a bit but, while was tackling the feedback, ended up re-organizing the commits changes better. The rationale for each modification should be clearer now.

What did was:

Eliminate the pre-set inputs second iteration inside SelectCoins by adding an AddInputs(std::vector<COutput>&) method to SelectionResult (so we don't need to iterate over the inputs just to insert them inside an ephemeral OutputGroup whom is simply not used --> SelectionResult::AddInput(OutputGroup&) takes directly the m_outputs internal field..).
Remove the FetchCoins wrapper function and the CoinsFund struct:
Moved the internals to CreateTransactionInternal, who will first call FetchSelectedInputs then call AvailableCoins.
Decouple the SelectCoins into two functions:
- AutomaticCoinSelection:
  Which is basically the previously called SelectCoins without the manually selected inputs stuff.
  So, it will purely receive a set of coins and be in charge of selecting the best subset of them to
  cover the target amount.
- SelectCoins:
  In charge of selecting all the user manually selected coins first ("pre-set inputs"), and
  if coin_control 'm_allow_other_inputs=true', call 'AutomaticCoinSelection' to select a
  set of coins such that the target - pre_set_inputs.total_amount is met. Then merge
  both results.
Have set CoinControl::m_allow_other_inputs default value to true to correct
a misleading behavior (convo started here):
- As several flows in the wallet such as sendtoaddress, sendmany
  and even the GUI don't change the m_allow_other_inputs param,
  and the default value for it has been false. The process was having
  a workaround patch to automatically fall back to select coins from the
  wallet if m_allow_other_inputs=false and no manual inputs were selected.

Goal 1: Benchmark the transaction creation process for pre-selected-inputs only. Setting `m_allow_other_inputs=false` to disallow the wallet to include coins automatically. Goal 2: Benchmark the transaction creation process for pre-selected-inputs and coin selection. ----------------------- Benchmark Setup: 1) Generates a 5k blockchain, loading the wallet with 5k transactions with two outputs each. 2) Fetch 4 random UTXO from the wallet's available coins and pre-select them as inputs inside CoinControl. Benchmark (Goal 1): Call `CreateTransaction` providing the coin control, who has set `m_allow_other_inputs=false` and the manually selected coins. Benchmark (Goal 2): Call `CreateTransaction` providing the coin control, who has set `m_allow_other_inputs=true` and the manually selected coins.

furszy · 2022-10-26T18:58:34Z

Updated per @S3RK feedback, thanks.

Only change is the ComputeAndSetWaste call after the merge of the two selection results (preset and automatic selection results). So the waste score is properly calculated for the USDT logging. Small diff

aureleoules

reACK 3fcb545

S3RK · 2022-10-27T07:26:58Z

Code Review ACK 3fcb545

achow101 · 2022-10-27T21:48:44Z

ACK 3fcb545

…pre-set…

Due to bitcoin/bitcoin#25685, we now have upstream logic for specifying pre-selected inputs in wallet/spend.cpp. This allows us to simplify the Namecoin-specific logic for spending with a predefined input (the previous name coin).

…ed total amount 7362f8e refactor: make CoinsResult total amounts members private (furszy) 3282fad wallet: add assert to SelectionResult::Merge for safety (S3RK) c4e3b7d wallet: SelectCoins, return early if wallet's UTXOs cannot cover the target (furszy) cac2725 test: bugfix, coinselector_test, use 'CoinsResult::Erase/Add' instead of direct member access (furszy) cf79384 test: Coin Selection, duplicated preset inputs selection (furszy) 341ba7f test: wallet, coverage for CoinsResult::Erase function (furszy) f930aef wallet: bugfix, 'CoinsResult::Erase' is erasing only one output of the set (furszy) Pull request description: This comes with #26559. Solving few bugs inside the wallet's transaction creation process and adding test coverage for them. Plus, making use of the `CoinsResult::total_amount` cached value inside the Coin Selection process to return early if we don't have enough funds to cover the target amount. ### Bugs 1) The `CoinsResult::Erase` method removes only one output from the available coins vector (there is a [loop break](https://github.com/bitcoin/bitcoin/blob/c1061be14a515b0ed4f4d646fcd0378c62e6ded3/src/wallet/spend.cpp#L112) that should have never been there) and not all the preset inputs. Which on master is not a problem, because since [#25685](bitcoin/bitcoin#25685) we are no longer using the method. But, it's a bug on v24 (check [#26559](bitcoin/bitcoin#26559)). This method it's being fixed and not removed because I'm later using it to solve another bug inside this PR. 2) As we update the total cached amount of the `CoinsResult` object inside `AvailableCoins` and we don't use such function inside the coin selection tests (we manually load up the `CoinsResult` object), there is a discrepancy between the outputs that we add/erase and the total amount cached value. ### Improvements * This makes use of the `CoinsResult` total amount field to early return with an "Insufficient funds" error inside Coin Selection if the tx target amount is greater than the sum of all the wallet available coins plus the preset inputs amounts (we don't need to perform the entire coin selection process if we already know that there aren't enough funds inside our wallet). ### Test Coverage 1) Adds test coverage for the duplicated preset input selection bug that we have in v24. Where the wallet invalidly selects the preset inputs twice during the Coin Selection process. Which ends up with a "good" Coin Selection result that does not cover the total tx target amount. Which, alone, crashes the wallet due an insane fee. But.. to make it worst, adding the subtract fee from output functionality to this mix ends up with the wallet by-passing the "insane" fee assertion, decreasing the output amount to fulfill the insane fee, and.. sadly, broadcasting the tx to the network. 2) Adds test coverage for the `CoinsResult::Erase` method. ------------------------------------ TO DO: * [ ] Update [#26559 ](bitcoin/bitcoin#26559) description. ACKs for top commit: achow101: ACK 7362f8e glozow: ACK 7362f8e, I assume there will be a followup PR to add coin selection sanity checks and we can discuss the best way to do that there. josibake: ACK [7362f8e](bitcoin/bitcoin@7362f8e) Tree-SHA512: 37a6828ea10d8d36c8d5873ceede7c8bef72ae4c34bef21721fa9dad83ad6dba93711c3170a26ab6e05bdbc267bb17433da08ccb83b82956d05fb16090328cba

… amount 7362f8e refactor: make CoinsResult total amounts members private (furszy) 3282fad wallet: add assert to SelectionResult::Merge for safety (S3RK) c4e3b7d wallet: SelectCoins, return early if wallet's UTXOs cannot cover the target (furszy) cac2725 test: bugfix, coinselector_test, use 'CoinsResult::Erase/Add' instead of direct member access (furszy) cf79384 test: Coin Selection, duplicated preset inputs selection (furszy) 341ba7f test: wallet, coverage for CoinsResult::Erase function (furszy) f930aef wallet: bugfix, 'CoinsResult::Erase' is erasing only one output of the set (furszy) Pull request description: This comes with bitcoin#26559. Solving few bugs inside the wallet's transaction creation process and adding test coverage for them. Plus, making use of the `CoinsResult::total_amount` cached value inside the Coin Selection process to return early if we don't have enough funds to cover the target amount. ### Bugs 1) The `CoinsResult::Erase` method removes only one output from the available coins vector (there is a [loop break](https://github.com/bitcoin/bitcoin/blob/c1061be14a515b0ed4f4d646fcd0378c62e6ded3/src/wallet/spend.cpp#L112) that should have never been there) and not all the preset inputs. Which on master is not a problem, because since [bitcoin#25685](bitcoin#25685) we are no longer using the method. But, it's a bug on v24 (check [bitcoin#26559](bitcoin#26559)). This method it's being fixed and not removed because I'm later using it to solve another bug inside this PR. 2) As we update the total cached amount of the `CoinsResult` object inside `AvailableCoins` and we don't use such function inside the coin selection tests (we manually load up the `CoinsResult` object), there is a discrepancy between the outputs that we add/erase and the total amount cached value. ### Improvements * This makes use of the `CoinsResult` total amount field to early return with an "Insufficient funds" error inside Coin Selection if the tx target amount is greater than the sum of all the wallet available coins plus the preset inputs amounts (we don't need to perform the entire coin selection process if we already know that there aren't enough funds inside our wallet). ### Test Coverage 1) Adds test coverage for the duplicated preset input selection bug that we have in v24. Where the wallet invalidly selects the preset inputs twice during the Coin Selection process. Which ends up with a "good" Coin Selection result that does not cover the total tx target amount. Which, alone, crashes the wallet due an insane fee. But.. to make it worst, adding the subtract fee from output functionality to this mix ends up with the wallet by-passing the "insane" fee assertion, decreasing the output amount to fulfill the insane fee, and.. sadly, broadcasting the tx to the network. 2) Adds test coverage for the `CoinsResult::Erase` method. ------------------------------------ TO DO: * [ ] Update [bitcoin#26559 ](bitcoin#26559) description. ACKs for top commit: achow101: ACK 7362f8e glozow: ACK 7362f8e, I assume there will be a followup PR to add coin selection sanity checks and we can discuss the best way to do that there. josibake: ACK [7362f8e](bitcoin@7362f8e) Tree-SHA512: 37a6828ea10d8d36c8d5873ceede7c8bef72ae4c34bef21721fa9dad83ad6dba93711c3170a26ab6e05bdbc267bb17433da08ccb83b82956d05fb16090328cba

Only a GUI issue, for the "use available balance" button when the user manually select inputs on the send screen. The previous behavior for getAvailableBalance when the coin control has selected inputs was to return the sum of them. Instead, we are currently returning the wallet's available total balance minus the selected coins total amount. Reason: We missed to update the GetAvailableBalance function to include the coin control selected coins on bitcoin#25685. Context: Since bitcoin#25685 we skip the selected coins inside `AvailableCoins`, the reason is that there is no need to walk through the entire wallet's txes map just to get coins that could have gotten by just doing a simple mapWallet.find).

The previous behavior for getAvailableBalance when coin control has selected coins was to return the sum of them. Instead, we are currently returning the wallet's available total balance minus the selected coins total amount. This turns into a GUI-only issue for the "use available balance" button when the user manually select coins in the send screen. Reason: We missed to update the GetAvailableBalance function to include the coin control selected coins on bitcoin#25685. Context: Since bitcoin#25685 we skip the selected coins inside `AvailableCoins`, the reason is that there is no need to traverse the wallet's txes map just to get coins that can directly be fetched by their id.

… coins 68eed5d test,gui: add coverage for PSBT creation on legacy watch-only wallets (furszy) 306aab5 test,gui: decouple widgets and model into a MiniGui struct (furszy) 2f76ac0 test,gui: decouple chain and wallet initialization from test case (furszy) cd98b71 gui: 'getAvailableBalance', include watch only balance (furszy) 74eac3a test: add coverage for 'useAvailableBalance' functionality (furszy) dc1cc1c gui: bugfix, getAvailableBalance skips selected coins (furszy) Pull request description: Fixes bitcoin-core/gui#688 and #26687. First Issue Description (bitcoin-core/gui#688): The previous behavior for `getAvailableBalance`, when the coin control had selected coins, was to return the sum of them. Instead, we are currently returning the wallet's available total balance minus the selected coins total amount. Reason: Missed to update the `GetAvailableBalance` function to include the coin control selected coins on #25685. Context: Since #25685 we skip the selected coins inside `AvailableCoins`, the reason is that there is no need to waste resources walking through the entire wallet's txes map just to get coins that could have gotten by just doing a simple `mapWallet.find`). Places Where This Generates Issues (only when the user manually select coins via coin control): 1) The GUI balance check prior the transaction creation process. 2) The GUI "useAvailableBalance" functionality. Note 1: As the GUI uses a balance cache since bitcoin-core/gui#598, this issue does not affect the regular spending process. Only arises when the user manually select coins. Note 2: Added test coverage for the `useAvailableBalance` functionality. ---------------------------------- Second Issue Description (#26687): As we are using a cached balance on `WalletModel::getAvailableBalance`, the function needs to include the watch-only available balance for wallets with private keys disabled. ACKs for top commit: Sjors: tACK 68eed5d achow101: ACK 68eed5d theStack: ACK 68eed5d Tree-SHA512: 674f3e050024dabda2ff4a04b9ed3750cf54a040527204c920e1e38bd3d7f5fd4d096e4fd08a0fea84ee6abb5070f022b5c0d450c58fd30202ef05ebfd7af6d3

The previous behavior for getAvailableBalance when coin control has selected coins was to return the sum of them. Instead, we are currently returning the wallet's available total balance minus the selected coins total amount. This turns into a GUI-only issue for the "use available balance" button when the user manually select coins in the send screen. Reason: We missed to update the GetAvailableBalance function to include the coin control selected coins on bitcoin#25685. Context: Since bitcoin#25685 we skip the selected coins inside `AvailableCoins`, the reason is that there is no need to traverse the wallet's txes map just to get coins that can directly be fetched by their id.

DrahtBot added the Wallet label Jul 23, 2022

furszy mentioned this pull request Jul 28, 2022

wallet: return error msg for "too-long-mempool-chain" #24845

Merged

DrahtBot mentioned this pull request Jul 28, 2022

wallet: Check max transaction weight in CoinSelection #25729

Merged

DrahtBot added the Needs rebase label Jul 28, 2022

furszy force-pushed the 2022_wallet_faster_coin_selection branch 3 times, most recently from 2545eab to 8cf6caf Compare July 29, 2022 13:22

DrahtBot removed the Needs rebase label Jul 29, 2022

furszy force-pushed the 2022_wallet_faster_coin_selection branch 2 times, most recently from 508f3c5 to 84b4ffe Compare July 29, 2022 14:16

DrahtBot mentioned this pull request Jul 29, 2022

wallet, refactor: #24584 follow-ups #25734

Merged

furszy force-pushed the 2022_wallet_faster_coin_selection branch from 0eb720f to f6d0bb2 Compare August 3, 2022 18:28

achow101 reviewed Aug 3, 2022

View reviewed changes

src/wallet/spend.cpp Outdated Show resolved Hide resolved

src/wallet/spend.cpp Outdated Show resolved Hide resolved

src/wallet/spend.cpp Outdated Show resolved Hide resolved

src/wallet/spend.cpp Outdated Show resolved Hide resolved

DrahtBot mentioned this pull request Aug 4, 2022

refactor: Replace BResult with util::Result #25721

Merged

DrahtBot added the Needs rebase label Aug 5, 2022

furszy force-pushed the 2022_wallet_faster_coin_selection branch 2 times, most recently from 79f3b6f to 7b7b77e Compare August 6, 2022 12:35

DrahtBot removed the Needs rebase label Aug 6, 2022

furszy added 2 commits October 26, 2022 15:54

wallet: SelectCoins, return early if target is covered by preset-inputs

a8a7534

furszy force-pushed the 2022_wallet_faster_coin_selection branch from 5bea640 to 3fcb545 Compare October 26, 2022 18:55

aureleoules approved these changes Oct 26, 2022

View reviewed changes

achow101 merged commit f37bd15 into bitcoin:master Oct 27, 2022

sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Oct 28, 2022

Merge bitcoin#25685: wallet: Faster transaction creation by removing …

1da4c50

…pre-set…

This was referenced Nov 23, 2022

[24.x] wallet: bugfix, double-counted preset inputs during Coin Selection #26559

Closed

wallet: bugfix, invalid CoinsResult cached total amount #26560

Merged

furszy mentioned this pull request Dec 14, 2022

wallet, gui: bugfix, getAvailableBalance skips selected coins #26699

Merged

Sjors mentioned this pull request Mar 31, 2023

Selecting two coins will abort with "The amount exceeds your balance." bitcoin-core/gui#688

Closed

furszy mentioned this pull request Apr 3, 2023

Mark "too-long-mempool-chain error msg" completed NYDIG/bitcoin-task-bounty#32

Merged

furszy deleted the 2022_wallet_faster_coin_selection branch May 27, 2023 01:48

bitcoin locked and limited conversation to collaborators May 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

wallet: Faster transaction creation by removing pre-set-inputs fetching responsibility from Coin Selection #25685

wallet: Faster transaction creation by removing pre-set-inputs fetching responsibility from Coin Selection #25685

Uh oh!

furszy commented Jul 23, 2022 •

edited

Loading

Uh oh!

DrahtBot commented Jul 23, 2022 •

edited

Loading

Uh oh!

furszy commented Jul 29, 2022

Uh oh!

ishaanam commented Aug 1, 2022

Uh oh!

achow101 commented Aug 2, 2022

Uh oh!

furszy commented Aug 2, 2022 •

edited

Loading

Uh oh!

furszy commented Aug 3, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

furszy commented Aug 6, 2022 •

edited

Loading

Uh oh!

furszy commented Oct 26, 2022

Uh oh!

aureleoules left a comment

Uh oh!

S3RK commented Oct 27, 2022

Uh oh!

achow101 commented Oct 27, 2022

Uh oh!

Uh oh!

wallet: Faster transaction creation by removing pre-set-inputs fetching responsibility from Coin Selection #25685

wallet: Faster transaction creation by removing pre-set-inputs fetching responsibility from Coin Selection #25685

Uh oh!

Conversation

furszy commented Jul 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

# Context (Current Flow on Master)

# Process Workflow Changes

# Summarizing the Improvements:

Result on this PR (tip f6d0bb2):

Result on master (tip 4a4289e):

Uh oh!

DrahtBot commented Jul 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

furszy commented Jul 29, 2022

Uh oh!

ishaanam commented Aug 1, 2022

Uh oh!

achow101 commented Aug 2, 2022

Uh oh!

furszy commented Aug 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Sources Architecture:

Tangible Improvements:

Uh oh!

furszy commented Aug 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This is the result on this PR (tip f6d0bb2):

This is the result on current master (tip 4a4289e):

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

furszy commented Aug 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

furszy commented Oct 26, 2022

Uh oh!

aureleoules left a comment

Choose a reason for hiding this comment

Uh oh!

S3RK commented Oct 27, 2022

Uh oh!

achow101 commented Oct 27, 2022

Uh oh!

Uh oh!

furszy commented Jul 23, 2022 •

edited

Loading

Result on this PR (tip `f6d0bb2`):

Result on master (tip `4a4289e`):

DrahtBot commented Jul 23, 2022 •

edited

Loading

furszy commented Aug 2, 2022 •

edited

Loading

furszy commented Aug 3, 2022 •

edited

Loading

This is the result on this PR (tip `f6d0bb2`):

This is the result on current master (tip `4a4289e`):

furszy commented Aug 6, 2022 •

edited

Loading