refactor: Move inbound eviction logic to its own translation unit #25500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ccde4c to
651c43f
Compare
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Jun 29, 2022
651c43f to
06d45ac
Compare
maflcko
reviewed
Jul 1, 2022
4f04786 to
2eb7256
Compare
jnewbery
reviewed
Jul 6, 2022
theuni
reviewed
Jul 6, 2022
2eb7256 to
0101d2b
Compare
|
utACK 0101d2b |
|
utACK 0101d2b. I quickly verified with |
dhruv
reviewed
Jul 12, 2022
| @@ -9,6 +9,7 @@ | |||
| #include <chainparams.h> | |||
| #include <common/bloom.h> | |||
| #include <compat.h> | |||
| #include <node/connection_types.h> | |||
There was a problem hiding this comment.
nit: Just noticed these are now out of the recommended include order
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits of the first couple commits from #25268 that move the inbound eviction logic from
net.{h,cpp}toeviction.{h,cpp}.Please look at #25268 for motivation and conceptual review.